From: Kees Cook <keescook@chromium.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux@armlinux.org.uk, linus.walleij@linaro.org, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: decompressor: disable stack protector
Date: Tue, 26 Oct 2021 10:14:36 -0700 [thread overview]
Message-ID: <202110261013.7A0CE6D71@keescook> (raw)
In-Reply-To: <20211026082752.3519140-1-ardb@kernel.org>
On Tue, Oct 26, 2021 at 10:27:52AM +0200, Ard Biesheuvel wrote:
> Enabling the stack protector in the decompressor is of dubious value,
> given that it uses a fixed value for the canary, cannot print any output
> unless CONFIG_DEBUG_LL is enabled (which relies on board specific build
> time settings), and is already disabled for a good chunk of the code
> (libfdt).
>
> So let's just disable it in the decompressor. This will make it easier
> in the future to manage the command line options that would need to be
> removed again in this context for the TLS register based stack
> protector.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Yeah, that's fine. There's no good reason to complicate the decompressor
for the stack protector. If someone is trying to exploit the kernel at
this stage, the system has a much bigger problem. ;)
Acked-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-26 17:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 8:27 [PATCH] ARM: decompressor: disable stack protector Ard Biesheuvel
2021-10-26 17:14 ` Kees Cook [this message]
2021-10-26 17:58 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202110261013.7A0CE6D71@keescook \
--to=keescook@chromium.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.