From: "Michael S. Tsirkin" <mst@redhat.com>
To: Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: Arnd Bergmann <arnd@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Stefan Hajnoczi <stefanha@redhat.com>,
Feng Li <lifeng1519@gmail.com>,
Israel Rukshin <israelr@nvidia.com>,
Arnd Bergmann <arnd@arndb.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Damien Le Moal <damien.lemoal@wdc.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio-blk: select CONFIG_SG_POOL
Date: Wed, 27 Oct 2021 05:10:18 -0400 [thread overview]
Message-ID: <20211027050920-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <29dbebdd-185d-a3be-6131-c9a471dc8d39@nvidia.com>
https://lore.kernel.org/r/20210901131434.31158-1-mgurtovoy@nvidia.com
yes - it was there. I think I dropped it while resolving
conflicts.
Thanks!
On Wed, Oct 27, 2021 at 11:56:20AM +0300, Max Gurtovoy wrote:
> This is strange, I've sent V3 with this code included.
>
> MST,
>
> which version did you take to your tree ?
>
>
> On 10/27/2021 11:24 AM, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > Switching virtio-blk to the sg_pool interfaces causes a build
> > failures when they are not part of the kernel:
> >
> > drivers/block/virtio_blk.c:182:3: error: implicit declaration of function 'sg_free_table_chained' [-Werror,-Wimplicit-function-declaration]
> > sg_free_table_chained(&vbr->sg_table,
> > ^
> > drivers/block/virtio_blk.c:195:8: error: implicit declaration of function 'sg_alloc_table_chained' [-Werror,-Wimplicit-function-declaration]
> > err = sg_alloc_table_chained(&vbr->sg_table,
> > ^
> >
> > Select this symbol through Kconfig, as is done for all other
> > users.
> >
> > Fixes: b2c5221fd074 ("virtio-blk: avoid preallocating big SGL for data")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > drivers/block/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
> > index d97eaf6adb6d..2a51dfb09c8f 100644
> > --- a/drivers/block/Kconfig
> > +++ b/drivers/block/Kconfig
> > @@ -371,6 +371,7 @@ config XEN_BLKDEV_BACKEND
> > config VIRTIO_BLK
> > tristate "Virtio block driver"
> > depends on VIRTIO
> > + select SG_POOL
> > help
> > This is the virtual block driver for virtio. It can be used with
> > QEMU based VMMs (like KVM or Xen). Say Y or M.
prev parent reply other threads:[~2021-10-27 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 8:24 [PATCH] virtio-blk: select CONFIG_SG_POOL Arnd Bergmann
2021-10-27 8:56 ` Michael S. Tsirkin
2021-10-27 8:56 ` Max Gurtovoy
2021-10-27 9:10 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211027050920-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=israelr@nvidia.com \
--cc=lifeng1519@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mgurtovoy@nvidia.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.