From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH net-next 6/9] net: sched: Protect Qdisc::bstats with u64_stats
Date: Wed, 27 Oct 2021 07:47:20 +0800 [thread overview]
Message-ID: <202110270710.aqIIkMDD-lkp@intel.com> (raw)
In-Reply-To: <20211016084910.4029084-7-bigeasy@linutronix.de>
[-- Attachment #1: Type: text/plain, Size: 4991 bytes --]
Hi Sebastian,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/Sebastian-Andrzej-Siewior/Try-to-simplify-the-gnet_stats-and-remove-qdisc-running-sequence-counter/20211016-165122
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 295711fa8fec42a55623bf6997d05a21d7855132
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/3f7dcf3ef7b80c1b54674bb0dc3fef74971cd975
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sebastian-Andrzej-Siewior/Try-to-simplify-the-gnet_stats-and-remove-qdisc-running-sequence-counter/20211016-165122
git checkout 3f7dcf3ef7b80c1b54674bb0dc3fef74971cd975
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
net/sched/sch_gred.c: In function 'gred_offload':
>> net/sched/sch_gred.c:350:1: error: the frame size of 1164 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
350 | }
| ^
cc1: all warnings being treated as errors
vim +350 net/sched/sch_gred.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 309
890d8d23ec3c9e Jakub Kicinski 2018-11-19 310 static void gred_offload(struct Qdisc *sch, enum tc_gred_command command)
890d8d23ec3c9e Jakub Kicinski 2018-11-19 311 {
890d8d23ec3c9e Jakub Kicinski 2018-11-19 312 struct gred_sched *table = qdisc_priv(sch);
890d8d23ec3c9e Jakub Kicinski 2018-11-19 313 struct net_device *dev = qdisc_dev(sch);
890d8d23ec3c9e Jakub Kicinski 2018-11-19 314 struct tc_gred_qopt_offload opt = {
890d8d23ec3c9e Jakub Kicinski 2018-11-19 315 .command = command,
890d8d23ec3c9e Jakub Kicinski 2018-11-19 316 .handle = sch->handle,
890d8d23ec3c9e Jakub Kicinski 2018-11-19 317 .parent = sch->parent,
890d8d23ec3c9e Jakub Kicinski 2018-11-19 318 };
890d8d23ec3c9e Jakub Kicinski 2018-11-19 319
890d8d23ec3c9e Jakub Kicinski 2018-11-19 320 if (!tc_can_offload(dev) || !dev->netdev_ops->ndo_setup_tc)
890d8d23ec3c9e Jakub Kicinski 2018-11-19 321 return;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 322
890d8d23ec3c9e Jakub Kicinski 2018-11-19 323 if (command == TC_GRED_REPLACE) {
890d8d23ec3c9e Jakub Kicinski 2018-11-19 324 unsigned int i;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 325
890d8d23ec3c9e Jakub Kicinski 2018-11-19 326 opt.set.grio_on = gred_rio_mode(table);
890d8d23ec3c9e Jakub Kicinski 2018-11-19 327 opt.set.wred_on = gred_wred_mode(table);
890d8d23ec3c9e Jakub Kicinski 2018-11-19 328 opt.set.dp_cnt = table->DPs;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 329 opt.set.dp_def = table->def;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 330
890d8d23ec3c9e Jakub Kicinski 2018-11-19 331 for (i = 0; i < table->DPs; i++) {
890d8d23ec3c9e Jakub Kicinski 2018-11-19 332 struct gred_sched_data *q = table->tab[i];
890d8d23ec3c9e Jakub Kicinski 2018-11-19 333
890d8d23ec3c9e Jakub Kicinski 2018-11-19 334 if (!q)
890d8d23ec3c9e Jakub Kicinski 2018-11-19 335 continue;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 336 opt.set.tab[i].present = true;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 337 opt.set.tab[i].limit = q->limit;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 338 opt.set.tab[i].prio = q->prio;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 339 opt.set.tab[i].min = q->parms.qth_min >> q->parms.Wlog;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 340 opt.set.tab[i].max = q->parms.qth_max >> q->parms.Wlog;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 341 opt.set.tab[i].is_ecn = gred_use_ecn(q);
890d8d23ec3c9e Jakub Kicinski 2018-11-19 342 opt.set.tab[i].is_harddrop = gred_use_harddrop(q);
890d8d23ec3c9e Jakub Kicinski 2018-11-19 343 opt.set.tab[i].probability = q->parms.max_P;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 344 opt.set.tab[i].backlog = &q->backlog;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 345 }
890d8d23ec3c9e Jakub Kicinski 2018-11-19 346 opt.set.qstats = &sch->qstats;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 347 }
890d8d23ec3c9e Jakub Kicinski 2018-11-19 348
890d8d23ec3c9e Jakub Kicinski 2018-11-19 349 dev->netdev_ops->ndo_setup_tc(dev, TC_SETUP_QDISC_GRED, &opt);
890d8d23ec3c9e Jakub Kicinski 2018-11-19 @350 }
890d8d23ec3c9e Jakub Kicinski 2018-11-19 351
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 69503 bytes --]
next prev parent reply other threads:[~2021-10-26 23:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 8:49 [PATCH net-next 0/9] Try to simplify the gnet_stats and remove qdisc->running sequence counter Sebastian Andrzej Siewior
2021-10-16 8:49 ` [PATCH net-next 1/9] gen_stats: Add instead Set the value in __gnet_stats_copy_basic() Sebastian Andrzej Siewior
2021-10-16 8:49 ` [PATCH net-next 2/9] gen_stats: Add gnet_stats_add_queue() Sebastian Andrzej Siewior
2021-10-16 8:49 ` [PATCH net-next 3/9] mq, mqprio: Use gnet_stats_add_queue() Sebastian Andrzej Siewior
2021-10-16 8:49 ` [PATCH net-next 4/9] gen_stats: Move remaining users to gnet_stats_add_queue() Sebastian Andrzej Siewior
2021-10-16 8:49 ` [PATCH net-next 5/9] u64_stats: Introduce u64_stats_set() Sebastian Andrzej Siewior
2021-10-16 8:49 ` [PATCH net-next 6/9] net: sched: Protect Qdisc::bstats with u64_stats Sebastian Andrzej Siewior
2021-10-26 23:47 ` kernel test robot [this message]
2021-10-16 8:49 ` [PATCH net-next 7/9] net: sched: Use _bstats_update/set() instead of raw writes Sebastian Andrzej Siewior
2021-10-16 8:49 ` [PATCH net-next 8/9] net: sched: Merge Qdisc::bstats and Qdisc::cpu_bstats data types Sebastian Andrzej Siewior
2021-10-16 8:49 ` [PATCH net-next 9/9] net: sched: Remove Qdisc::running sequence counter Sebastian Andrzej Siewior
2021-10-18 17:23 ` Eric Dumazet
2021-10-18 18:30 ` Eric Dumazet
2021-10-18 19:24 ` Eric Dumazet
2021-10-18 23:53 ` Eric Dumazet
2021-10-19 10:12 ` [PATCH net-next] net: sched: Allow statistics reads from softirq Sebastian Andrzej Siewior
2021-10-19 12:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202110270710.aqIIkMDD-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.