Re: [RFC PATCH 3/4] usb: typec: ucsi: Add support for PD cdev

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4781 bytes --]

Hi Heikki,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on next-20211026]
[cannot apply to chrome-platform/for-next peter-chen-usb/for-usb-next linus/master balbi-usb/testing/next v5.15-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Heikki-Krogerus/USB-Power-Delivery-character-device-interface/20211026-224629
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: x86_64-rhel-8.3-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/9eaf262732a6e75ba994550fa5d04daedf762ce6
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Heikki-Krogerus/USB-Power-Delivery-character-device-interface/20211026-224629
        git checkout 9eaf262732a6e75ba994550fa5d04daedf762ce6
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/usb/typec/ucsi/pd-dev.c:26:55: sparse: sparse: incorrect type in argument 4 (different base types) @@     expected unsigned int [usertype] *pdos @@     got restricted __le32 * @@
   drivers/usb/typec/ucsi/pd-dev.c:26:55: sparse:     expected unsigned int [usertype] *pdos
   drivers/usb/typec/ucsi/pd-dev.c:26:55: sparse:     got restricted __le32 *
>> drivers/usb/typec/ucsi/pd-dev.c:34:33: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le32 @@     got unsigned int [usertype] request_data_obj @@
   drivers/usb/typec/ucsi/pd-dev.c:34:33: sparse:     expected restricted __le32
   drivers/usb/typec/ucsi/pd-dev.c:34:33: sparse:     got unsigned int [usertype] request_data_obj
   drivers/usb/typec/ucsi/pd-dev.c:37:55: sparse: sparse: incorrect type in argument 4 (different base types) @@     expected unsigned int [usertype] *pdos @@     got restricted __le32 * @@
   drivers/usb/typec/ucsi/pd-dev.c:37:55: sparse:     expected unsigned int [usertype] *pdos
   drivers/usb/typec/ucsi/pd-dev.c:37:55: sparse:     got restricted __le32 *
   drivers/usb/typec/ucsi/pd-dev.c:66:49: sparse: sparse: incorrect type in argument 4 (different base types) @@     expected unsigned int [usertype] *pdos @@     got restricted __le32 * @@
   drivers/usb/typec/ucsi/pd-dev.c:66:49: sparse:     expected unsigned int [usertype] *pdos
   drivers/usb/typec/ucsi/pd-dev.c:66:49: sparse:     got restricted __le32 *
   drivers/usb/typec/ucsi/pd-dev.c:73:49: sparse: sparse: incorrect type in argument 4 (different base types) @@     expected unsigned int [usertype] *pdos @@     got restricted __le32 * @@
   drivers/usb/typec/ucsi/pd-dev.c:73:49: sparse:     expected unsigned int [usertype] *pdos
   drivers/usb/typec/ucsi/pd-dev.c:73:49: sparse:     got restricted __le32 *

vim +26 drivers/usb/typec/ucsi/pd-dev.c

    12	
    13	static int ucsi_pd_get_objects(const struct pd_dev *dev, struct pd_message *msg)
    14	{
    15		struct ucsi_connector *con = pd_dev_to_connector(dev);
    16		int partner = dev == &con->pd_partner_dev;
    17		int ret = -ENOTTY;
    18	
    19		mutex_lock(&con->lock);
    20	
    21		if (le16_to_cpu(msg->header) & PD_HEADER_EXT_HDR)
    22			goto err;
    23	
    24		switch (pd_header_type_le(msg->header)) {
    25		case PD_DATA_SOURCE_CAP:
  > 26			ret = ucsi_read_pdos(con, partner, 1, msg->payload);
    27			if (ret < 0)
    28				goto err;
    29	
    30			msg->header = PD_HEADER_LE(PD_DATA_SOURCE_CAP, 0, 0, 0, 0, ret);
    31			break;
    32		case PD_DATA_REQUEST:
    33			msg->header = PD_HEADER_LE(PD_DATA_REQUEST, 0, 0, 0, 0, 1);
  > 34			msg->payload[0] = con->status.request_data_obj;
    35			break;
    36		case PD_DATA_SINK_CAP:
    37			ret = ucsi_read_pdos(con, partner, 0, msg->payload);
    38			if (ret < 0)
    39				goto err;
    40	
    41			msg->header = PD_HEADER_LE(PD_DATA_SINK_CAP, 0, 0, 0, 0, ret);
    42			break;
    43		default:
    44			goto err;
    45		}
    46	
    47		ret = 0;
    48	err:
    49		mutex_unlock(&con->lock);
    50	
    51		return ret;
    52	}
    53	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 42115 bytes --]