All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Kamal Heib <kheib@redhat.com>
Cc: Alok Prasad <palok@marvell.com>,
	michal.kalderon@marvell.com, ariel.elior@marvell.com,
	linux-rdma@vger.kernel.org, smalin@marvell.com,
	aelior@marvell.com, alok.prasad7@gmail.com,
	Michal Kalderon <mkalderon@marvell.com>,
	dledford@redhat.com
Subject: Re: [v2,for-rc] RDMA/qedr: qedr crash while running rdma-tool
Date: Wed, 27 Oct 2021 14:00:59 -0300	[thread overview]
Message-ID: <20211027170059.GA644717@nvidia.com> (raw)
In-Reply-To: <1871141c-2af4-5959-4c1a-1a7c9df73598@redhat.com>

On Sun, Oct 24, 2021 at 01:46:03PM +0300, Kamal Heib wrote:

> > diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c
> > index dcb3653db72d..85baa4f730df 100644
> > +++ b/drivers/infiniband/hw/qedr/verbs.c
> > @@ -2744,15 +2744,20 @@ int qedr_query_qp(struct ib_qp *ibqp,
> >   	int rc = 0;
> >   	memset(&params, 0, sizeof(params));
> > +	memset(qp_attr, 0, sizeof(*qp_attr));
> > +	memset(qp_init_attr, 0, sizeof(*qp_init_attr));
> > -	rc = dev->ops->rdma_query_qp(dev->rdma_ctx, qp->qed_qp, &params);
> > +	if (qp->qed_qp)
> 
> I suggest to use "if (qp->qp_type != IB_QPT_GSI)" to match the handling of
> GSI QPs in the QEDR driver.

Alok? Time is closing to get this in before the merge window.

Jason

  reply	other threads:[~2021-10-27 17:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-23 16:45 [v2,for-rc] RDMA/qedr: qedr crash while running rdma-tool Alok Prasad
2021-10-24 10:46 ` Kamal Heib
2021-10-27 17:00   ` Jason Gunthorpe [this message]
2021-10-27 18:45     ` [EXT] " Alok Prasad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211027170059.GA644717@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=aelior@marvell.com \
    --cc=alok.prasad7@gmail.com \
    --cc=ariel.elior@marvell.com \
    --cc=dledford@redhat.com \
    --cc=kheib@redhat.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=michal.kalderon@marvell.com \
    --cc=mkalderon@marvell.com \
    --cc=palok@marvell.com \
    --cc=smalin@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.