From: Calvin Wan <calvinwan@google.com>
To: git@vger.kernel.org
Cc: Calvin Wan <calvinwan@google.com>
Subject: [RFC PATCH 0/1] protocol-v2.txt: align delim-pkt spec with usage
Date: Wed, 27 Oct 2021 19:35:00 +0000 [thread overview]
Message-ID: <20211027193501.556540-1-calvinwan@google.com> (raw)
In the grammar for a command the "delim-pkt" is optional, and a command could be followed by a "flush-pkt". On the other hand, JGit code is assuming that there is ALWAYS a DELIM package after command. I.e. messages valid following the grammar would fail in JGit. This is not causing troubles because all commands (ls-refs and fetch) have command-args. This problem arose when adding parsing for the "capability-list" So, bug here is align protocol grammar and code expectations. Given that a. most commands have args, and b. having delim-pkt between sections simplifies parsing, delim-pkt should be mandatory.
Calvin Wan (1):
Documentation/technical/protocol-v2.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
base-commit: 0785eb769886ae81e346df10e88bc49ffc0ac64e
--
2.33.0.664.g0785eb7698
next reply other threads:[~2021-10-27 19:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 19:35 Calvin Wan [this message]
2021-10-27 19:35 ` [RFC PATCH 1/1] protocol-v2.txt: align delim-pkt spec with usage Calvin Wan
2021-10-27 21:44 ` Junio C Hamano
2021-11-11 22:00 ` [PATCH v2] " Calvin Wan
2021-11-11 22:09 ` Nasser Grainawi
2021-11-11 22:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211027193501.556540-1-calvinwan@google.com \
--to=calvinwan@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.