From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 28 Oct 2021 01:50:36 -0400 From: "Michael S. Tsirkin" Subject: Re: [virtio-dev] RE: [PATCH v2] Add device reset timeout field Message-ID: <20211028014301-mutt-send-email-mst@kernel.org> References: <2984c445-a7fd-97c4-34aa-3a40778a0fcd@redhat.com> <20211027040559-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline To: Parav Pandit Cc: Jason Wang , Cornelia Huck , "virtio-dev@lists.oasis-open.org" , Max Gurtovoy , Shahaf Shuler , Oren Duer List-ID: On Thu, Oct 28, 2021 at 04:01:52AM +0000, Parav Pandit wrote: > > how it looks like, whether there is a timeout is > > a separate question. > > > E.g. a read counter sounds > > more generic, if device is stuck it can just stop > > incrementing it. > This is not scalable solution for hundreds of devices and it breaks the layering too. > A virtio layer itself is not in up_state to perform counter update. > A non virtio layer is expected to implement this counter. This is not right. Donnu what does the above mean. My point is simple: there's little difference between device being stuck during firmware boot and device being stuck right after boot. > But this timer is not useful for publishing device readiness. Having device readiness register is enough to indicate that. > For health monitoring such counting register is useful. But its out of scope to address this problem. > So will skip this. > > I will explore the device readiness register and update the proposal. > Thanks.