Re: [RFC v16 2/9] iommu: Introduce iommu_get_nesting

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4742 bytes --]

Hi Eric,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on joro-iommu/next]
[also build test ERROR on v5.15-rc7 next-20211027]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Eric-Auger/SMMUv3-Nested-Stage-Setup-IOMMU-part/20211027-184900
base:   https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: ia64-defconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/bd101c49e9c42dc3299df01f6aabc15433f147a8
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Eric-Auger/SMMUv3-Nested-Stage-Setup-IOMMU-part/20211027-184900
        git checkout bd101c49e9c42dc3299df01f6aabc15433f147a8
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/bitops.h:7,
                    from include/linux/bitmap.h:8,
                    from drivers/iommu/intel/iommu.c:17:
   drivers/iommu/intel/iommu.c: In function 'intel_iommu_get_nesting':
>> drivers/iommu/intel/iommu.c:5610:48: error: 'flags' undeclared (first use in this function)
    5610 |         spin_lock_irqsave(&device_domain_lock, flags);
         |                                                ^~~~~
   include/linux/typecheck.h:11:16: note: in definition of macro 'typecheck'
      11 |         typeof(x) __dummy2; \
         |                ^
   include/linux/spinlock.h:393:9: note: in expansion of macro 'raw_spin_lock_irqsave'
     393 |         raw_spin_lock_irqsave(spinlock_check(lock), flags);     \
         |         ^~~~~~~~~~~~~~~~~~~~~
   drivers/iommu/intel/iommu.c:5610:9: note: in expansion of macro 'spin_lock_irqsave'
    5610 |         spin_lock_irqsave(&device_domain_lock, flags);
         |         ^~~~~~~~~~~~~~~~~
   drivers/iommu/intel/iommu.c:5610:48: note: each undeclared identifier is reported only once for each function it appears in
    5610 |         spin_lock_irqsave(&device_domain_lock, flags);
         |                                                ^~~~~
   include/linux/typecheck.h:11:16: note: in definition of macro 'typecheck'
      11 |         typeof(x) __dummy2; \
         |                ^
   include/linux/spinlock.h:393:9: note: in expansion of macro 'raw_spin_lock_irqsave'
     393 |         raw_spin_lock_irqsave(spinlock_check(lock), flags);     \
         |         ^~~~~~~~~~~~~~~~~~~~~
   drivers/iommu/intel/iommu.c:5610:9: note: in expansion of macro 'spin_lock_irqsave'
    5610 |         spin_lock_irqsave(&device_domain_lock, flags);
         |         ^~~~~~~~~~~~~~~~~
   include/linux/typecheck.h:12:25: warning: comparison of distinct pointer types lacks a cast
      12 |         (void)(&__dummy == &__dummy2); \
         |                         ^~
   include/linux/spinlock.h:255:17: note: in expansion of macro 'typecheck'
     255 |                 typecheck(unsigned long, flags);        \
         |                 ^~~~~~~~~
   include/linux/spinlock.h:393:9: note: in expansion of macro 'raw_spin_lock_irqsave'
     393 |         raw_spin_lock_irqsave(spinlock_check(lock), flags);     \
         |         ^~~~~~~~~~~~~~~~~~~~~
   drivers/iommu/intel/iommu.c:5610:9: note: in expansion of macro 'spin_lock_irqsave'
    5610 |         spin_lock_irqsave(&device_domain_lock, flags);
         |         ^~~~~~~~~~~~~~~~~


vim +/flags +5610 drivers/iommu/intel/iommu.c

  5604	
  5605	static bool intel_iommu_get_nesting(struct iommu_domain *domain)
  5606	{
  5607		struct dmar_domain *dmar_domain = to_dmar_domain(domain);
  5608		bool nesting;
  5609	
> 5610		spin_lock_irqsave(&device_domain_lock, flags);
  5611		nesting =  dmar_domain->flags & DOMAIN_FLAG_NESTING_MODE &&
  5612			   !(dmar_domain->flags & DOMAIN_FLAG_USE_FIRST_LEVEL);
  5613		spin_unlock_irqrestore(&device_domain_lock, flags);
  5614		return nesting;
  5615	}
  5616	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 19957 bytes --]