From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CF52C433FE for ; Thu, 28 Oct 2021 09:24:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E658560E78 for ; Thu, 28 Oct 2021 09:24:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230077AbhJ1J0v (ORCPT ); Thu, 28 Oct 2021 05:26:51 -0400 Received: from elvis.franken.de ([193.175.24.41]:45139 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229626AbhJ1J0v (ORCPT ); Thu, 28 Oct 2021 05:26:51 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1mg1dv-0002j1-00; Thu, 28 Oct 2021 11:24:15 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id ED26FC2770; Thu, 28 Oct 2021 11:23:18 +0200 (CEST) Date: Thu, 28 Oct 2021 11:23:18 +0200 From: Thomas Bogendoerfer To: Sergio Paracuellos Cc: Yanteng Si , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Yanteng Si , Stephen Rothwell , Lorenzo Pieralisi , Rob Herring , kw@linux.com, Bjorn Helgaas , Matthias Brugger , Philipp Zabel , linux-pci , linux-arm-kernel@lists.infradead.org, "moderated list:ARM/Mediatek SoC support" , "open list:MIPS" , chenhuacai@kernel.org, sterlingteng@gmail.com, Linux Next Mailing List Subject: Re: [PATCH v2 2/3] MIPS: cm/cpc: export some missing symbols to be able to use them from driver code Message-ID: <20211028092318.GA6574@alpha.franken.de> References: <112fea0c8c1b65a762ac98412216239160721263.1635390750.git.siyanteng@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Thu, Oct 28, 2021 at 06:11:18AM +0200, Sergio Paracuellos wrote: > On Thu, Oct 28, 2021 at 6:05 AM Yanteng Si wrote: > > > > Since commit 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver") > > the MT7621 PCIe host controller driver is built as a module but modpost complains once these > > drivers become modules. > > > > ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > > > Let's just export them. > > > > Signed-off-by: Yanteng Si > > --- > > arch/mips/kernel/mips-cm.c | 5 +++++ > > arch/mips/kernel/mips-cpc.c | 1 + > > 2 files changed, 6 insertions(+) > > > > Reviewed-by: Sergio Paracuellos could we instead make the pcie-mt761 driver non modular ? Exporting all MIPS specific stuff for just making an essential driver modular doesn't IMHO make much sense. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AB3BC433EF for ; Thu, 28 Oct 2021 09:24:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0F0760E78 for ; Thu, 28 Oct 2021 09:24:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C0F0760E78 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4TOuXgcGyXqA2p5SCC0tp7OmraI1bcHgoCwbSF0DkSA=; b=T9V6x7wtxzqLPP 1IoZYgjc08f6ryFqi7U1GC1P3OCuTQTm55NLgKq68ZdoD7465DAIO/eBN4DAqcFmOE6hY75xsBWOr OAw1K+LS+8/2T8xa9cLjoIe6e2stbvT8zGjhwqkIPw2bN79Gi3xkH+sn1pDFdKxg8Ub/Fbk9nYA50 LMrZlt49A/SaagIjrPHoNpxu02/3rgLa+IX6+ASHKvNgZ898ymMt7OXkuo1pQoXo8YxniHya4/7vq APnVlOkUDKkDYSjyDiH/0l+iz5hrQR639359OqpD4cnzzZqKFmW5U734l8qoK9zVPaUrv7BmrpEei P8aemy3Nn/FJX54aoXIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mg1e6-007NUe-Cc; Thu, 28 Oct 2021 09:24:26 +0000 Received: from elvis.franken.de ([193.175.24.41]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mg1e2-007NTR-R7; Thu, 28 Oct 2021 09:24:24 +0000 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1mg1dv-0002j1-00; Thu, 28 Oct 2021 11:24:15 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id ED26FC2770; Thu, 28 Oct 2021 11:23:18 +0200 (CEST) Date: Thu, 28 Oct 2021 11:23:18 +0200 From: Thomas Bogendoerfer To: Sergio Paracuellos Cc: Yanteng Si , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Yanteng Si , Stephen Rothwell , Lorenzo Pieralisi , Rob Herring , kw@linux.com, Bjorn Helgaas , Matthias Brugger , Philipp Zabel , linux-pci , linux-arm-kernel@lists.infradead.org, "moderated list:ARM/Mediatek SoC support" , "open list:MIPS" , chenhuacai@kernel.org, sterlingteng@gmail.com, Linux Next Mailing List Subject: Re: [PATCH v2 2/3] MIPS: cm/cpc: export some missing symbols to be able to use them from driver code Message-ID: <20211028092318.GA6574@alpha.franken.de> References: <112fea0c8c1b65a762ac98412216239160721263.1635390750.git.siyanteng@loongson.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211028_022423_234738_010244F4 X-CRM114-Status: GOOD ( 15.66 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Oct 28, 2021 at 06:11:18AM +0200, Sergio Paracuellos wrote: > On Thu, Oct 28, 2021 at 6:05 AM Yanteng Si wrote: > > > > Since commit 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver") > > the MT7621 PCIe host controller driver is built as a module but modpost complains once these > > drivers become modules. > > > > ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > > > Let's just export them. > > > > Signed-off-by: Yanteng Si > > --- > > arch/mips/kernel/mips-cm.c | 5 +++++ > > arch/mips/kernel/mips-cpc.c | 1 + > > 2 files changed, 6 insertions(+) > > > > Reviewed-by: Sergio Paracuellos could we instead make the pcie-mt761 driver non modular ? Exporting all MIPS specific stuff for just making an essential driver modular doesn't IMHO make much sense. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 867FDC433F5 for ; Thu, 28 Oct 2021 09:25:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DF7D60E78 for ; Thu, 28 Oct 2021 09:25:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4DF7D60E78 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8F3B0Lndi6Dv3X9fMUezQara57cKvngvXtk9OB/WJUo=; b=AyXAcyhtJuXMxZ AsYkqOwHZy/Wb91WiSqh7sjpb4mG9E9KFD4kldiSIiC/tToaMJd3eIm+y/UFMYJMCQeBrkujI6be1 knK1yx3PTMDm4a2eYY6FYKuJbv91RUmg5UU99hl8++b2JvRU2ORP/0yrcK6HdENpt40NbQ22NGZDg FxVUFMXTho5FZ6YkhvocIfGEQKTzKx58DuZu1hsFwNWk9RHQYQRErL5zSS+zuN/faq/AiaMMxovLa NjfJSEgi4quoBTPGhYzxlGur3RWQUKNBPjrfwfQuSqJhaZs1Ph/fny602YWBC1JuT+otpkeMfUoKQ UTRP0j95RRmQKUlegqNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mg1e8-007NUp-BF; Thu, 28 Oct 2021 09:24:28 +0000 Received: from elvis.franken.de ([193.175.24.41]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mg1e2-007NTR-R7; Thu, 28 Oct 2021 09:24:24 +0000 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1mg1dv-0002j1-00; Thu, 28 Oct 2021 11:24:15 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id ED26FC2770; Thu, 28 Oct 2021 11:23:18 +0200 (CEST) Date: Thu, 28 Oct 2021 11:23:18 +0200 From: Thomas Bogendoerfer To: Sergio Paracuellos Cc: Yanteng Si , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Yanteng Si , Stephen Rothwell , Lorenzo Pieralisi , Rob Herring , kw@linux.com, Bjorn Helgaas , Matthias Brugger , Philipp Zabel , linux-pci , linux-arm-kernel@lists.infradead.org, "moderated list:ARM/Mediatek SoC support" , "open list:MIPS" , chenhuacai@kernel.org, sterlingteng@gmail.com, Linux Next Mailing List Subject: Re: [PATCH v2 2/3] MIPS: cm/cpc: export some missing symbols to be able to use them from driver code Message-ID: <20211028092318.GA6574@alpha.franken.de> References: <112fea0c8c1b65a762ac98412216239160721263.1635390750.git.siyanteng@loongson.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211028_022423_234738_010244F4 X-CRM114-Status: GOOD ( 15.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 28, 2021 at 06:11:18AM +0200, Sergio Paracuellos wrote: > On Thu, Oct 28, 2021 at 6:05 AM Yanteng Si wrote: > > > > Since commit 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver") > > the MT7621 PCIe host controller driver is built as a module but modpost complains once these > > drivers become modules. > > > > ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > > > Let's just export them. > > > > Signed-off-by: Yanteng Si > > --- > > arch/mips/kernel/mips-cm.c | 5 +++++ > > arch/mips/kernel/mips-cpc.c | 1 + > > 2 files changed, 6 insertions(+) > > > > Reviewed-by: Sergio Paracuellos could we instead make the pcie-mt761 driver non modular ? Exporting all MIPS specific stuff for just making an essential driver modular doesn't IMHO make much sense. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel