From: Eric Wong <e@80x24.org>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] allow disabling fsync everywhere
Date: Thu, 28 Oct 2021 18:28:24 +0000 [thread overview]
Message-ID: <20211028182824.GA1307@dcvr> (raw)
In-Reply-To: <YXq1g4Zwfq8gJEoC@coredump.intra.peff.net>
Jeff King <peff@peff.net> wrote:
> On Thu, Oct 28, 2021 at 12:21:02AM +0000, Eric Wong wrote:
>
> > "core.fsync" and the "GIT_FSYNC" environment variable now exist
> > for disabling fsync() even on packfiles and other critical data.
Fwiw, I'm questioning the need for core.fsync. GIT_FSYNC alone
may be sufficient.
> > This will also be useful for 3rd-party tools which create
> > throwaway git repositories of temporary data.
>
> Do you mostly just care about the tests, or is the third-party tool
> support important to you? I ask because most of us switched to running
> the tests with --root=/some/tmpfs long ago to achieve the same speedup.
Third-party tools and OSes which don't have a tmpfs mounted by
default (I don't think most *BSDs have tmpfs enabled by
default).
I try to use libeatmydata everywhere I can; but that's not
always installed.
I'm also strongly considering making GIT_FSYNC=0 the default for
our own test suite since it's less setup for newbies.
next prev parent reply other threads:[~2021-10-28 18:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 0:21 [PATCH] allow disabling fsync everywhere Eric Wong
2021-10-28 1:21 ` Eric Sunshine
2021-10-28 14:36 ` Jeff King
2021-10-28 18:28 ` Eric Wong [this message]
2021-10-28 19:29 ` Junio C Hamano
2021-10-29 0:15 ` [PATCH] tests: disable " Eric Wong
2021-10-29 5:18 ` Junio C Hamano
2021-10-29 7:56 ` Eric Wong
2021-10-29 18:12 ` Junio C Hamano
2021-10-29 7:33 ` Junio C Hamano
2021-10-29 7:48 ` Eric Wong
2021-10-29 17:22 ` Junio C Hamano
2021-10-29 20:34 ` Jeff King
2021-10-29 20:42 ` Junio C Hamano
2021-10-28 21:40 ` [PATCH] allow disabling " brian m. carlson
2021-10-29 11:20 ` Ævar Arnfjörð Bjarmason
2021-10-30 10:39 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211028182824.GA1307@dcvr \
--to=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.