From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgHvG-009b6H-F8 for linux-um@lists.infradead.org; Fri, 29 Oct 2021 02:47:15 +0000 From: Jakub Kicinski Subject: [PATCH net-next 2/3] net: um: use eth_hw_addr_set() Date: Thu, 28 Oct 2021 19:47:06 -0700 Message-Id: <20211029024707.316066-3-kuba@kernel.org> In-Reply-To: <20211029024707.316066-1-kuba@kernel.org> References: <20211029024707.316066-1-kuba@kernel.org> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: davem@davemloft.net Cc: netdev@vger.kernel.org, Jakub Kicinski , jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes.berg@intel.com, linux-um@lists.infradead.org Commit 406f42fa0d3c ("net-next: When a bond have a massive amount of VLANs...") introduced a rbtree for faster Ethernet address look up. To maintain netdev->dev_addr in this tree we need to make all the writes to it go through appropriate helpers. Signed-off-by: Jakub Kicinski --- CC: jdike@addtoit.com CC: richard@nod.at CC: anton.ivanov@cambridgegreys.com CC: johannes.berg@intel.com CC: linux-um@lists.infradead.org --- arch/um/drivers/net_kern.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/um/drivers/net_kern.c b/arch/um/drivers/net_kern.c index 2fc0b038ff8a..59331384c2d3 100644 --- a/arch/um/drivers/net_kern.c +++ b/arch/um/drivers/net_kern.c @@ -276,7 +276,7 @@ static const struct ethtool_ops uml_net_ethtool_ops = { void uml_net_setup_etheraddr(struct net_device *dev, char *str) { - unsigned char *addr = dev->dev_addr; + u8 addr[ETH_ALEN]; char *end; int i; @@ -316,6 +316,7 @@ void uml_net_setup_etheraddr(struct net_device *dev, char *str) addr[0] | 0x02, addr[1], addr[2], addr[3], addr[4], addr[5]); } + eth_hw_addr_set(dev, addr); return; random: -- 2.31.1 _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6214EC433FE for ; Fri, 29 Oct 2021 02:47:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44E5E61166 for ; Fri, 29 Oct 2021 02:47:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231596AbhJ2Ctm (ORCPT ); Thu, 28 Oct 2021 22:49:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:42926 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231584AbhJ2Ctl (ORCPT ); Thu, 28 Oct 2021 22:49:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2617861175; Fri, 29 Oct 2021 02:47:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635475633; bh=tiMVZ2XyRVbORniU+vtW0g1IFv6IL3znQKoUPUMCTIw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jvF0DzL8BaGh+RxlEhqAinVDifdP1rnwBubvubniCLq+jD1TakXUu9rMSxXO/1OrA 9Y5WpWNjj8v9sXrc89QUVnn7u6nSSFObb+0ZVK/ZzuchYLrUFwm8A2I4Gvy6WLOUq8 QKsjg67iqydQ+ZT3wV2sT9uzhfOl3P7lexKsQVih4xC6W23jGPk9q+ZuWSdkSfrFNv RpKmsv11rmuG2Zw5qc4H5BANlxr4OwEvB4hZHj78dP5vLntyk+AxUCMpiQQczxIQGf mk/WV6U2J3anA4108im43wXDD53hfchDLJDFbJqZtLRRrutCWxeWTub06SQmhoU5M0 5PukDNbv+MDHA== From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, Jakub Kicinski , jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes.berg@intel.com, linux-um@lists.infradead.org Subject: [PATCH net-next 2/3] net: um: use eth_hw_addr_set() Date: Thu, 28 Oct 2021 19:47:06 -0700 Message-Id: <20211029024707.316066-3-kuba@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211029024707.316066-1-kuba@kernel.org> References: <20211029024707.316066-1-kuba@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Commit 406f42fa0d3c ("net-next: When a bond have a massive amount of VLANs...") introduced a rbtree for faster Ethernet address look up. To maintain netdev->dev_addr in this tree we need to make all the writes to it go through appropriate helpers. Signed-off-by: Jakub Kicinski --- CC: jdike@addtoit.com CC: richard@nod.at CC: anton.ivanov@cambridgegreys.com CC: johannes.berg@intel.com CC: linux-um@lists.infradead.org --- arch/um/drivers/net_kern.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/um/drivers/net_kern.c b/arch/um/drivers/net_kern.c index 2fc0b038ff8a..59331384c2d3 100644 --- a/arch/um/drivers/net_kern.c +++ b/arch/um/drivers/net_kern.c @@ -276,7 +276,7 @@ static const struct ethtool_ops uml_net_ethtool_ops = { void uml_net_setup_etheraddr(struct net_device *dev, char *str) { - unsigned char *addr = dev->dev_addr; + u8 addr[ETH_ALEN]; char *end; int i; @@ -316,6 +316,7 @@ void uml_net_setup_etheraddr(struct net_device *dev, char *str) addr[0] | 0x02, addr[1], addr[2], addr[3], addr[4], addr[5]); } + eth_hw_addr_set(dev, addr); return; random: -- 2.31.1