Re: [PATCH RFC] ALSA: control: Use xarray for faster lookups

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2570 bytes --]

Hi Takashi,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on tiwai-sound/for-next]
[also build test WARNING on v5.15-rc7 next-20211028]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Takashi-Iwai/ALSA-control-Use-xarray-for-faster-lookups/20211028-210215
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: ia64-defconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/d9e50e9647a202433a7b1c261b0edb0021f16004
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Takashi-Iwai/ALSA-control-Use-xarray-for-faster-lookups/20211028-210215
        git checkout d9e50e9647a202433a7b1c261b0edb0021f16004
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   sound/core/control.c: In function 'add_hash_entries':
>> sound/core/control.c:404:16: warning: variable 'err' set but not used [-Wunused-but-set-variable]
     404 |         int i, err;
         |                ^~~


vim +/err +404 sound/core/control.c

   398	
   399	/* add hash entries to numid and ctl xarray tables */
   400	static void add_hash_entries(struct snd_card *card,
   401				     struct snd_kcontrol *kcontrol)
   402	{
   403		struct snd_ctl_elem_id id = kcontrol->id;
 > 404		int i, err;
   405	
   406		xa_store_range(&card->ctl_numids, kcontrol->id.numid,
   407			       kcontrol->id.numid + kcontrol->count - 1,
   408			       kcontrol, GFP_KERNEL);
   409	
   410		for (i = 0; i < kcontrol->count; i++) {
   411			id.index = kcontrol->id.index + i;
   412			err = xa_insert(&card->ctl_hash, get_ctl_id_hash(&id),
   413					kcontrol, GFP_KERNEL);
   414			/* ignore errors - it's a best effort */
   415		}
   416	}
   417	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 19985 bytes --]