All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH V8 5/9] tracing/osnoise: Support a list of trace_array *tr
Date: Sun, 31 Oct 2021 00:02:00 +0800	[thread overview]
Message-ID: <202110310010.kbLQGxcu-lkp@intel.com> (raw)
In-Reply-To: <351f62aa9f163d64fb429523a372ab1a021b7ff4.1635533292.git.bristot@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 3362 bytes --]

Hi Daniel,

I love your patch! Yet something to improve:

[auto build test ERROR on linux/master]
[also build test ERROR on linus/master v5.15-rc7 next-20211029]
[cannot apply to tip/perf/core rostedt-trace/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Daniel-Bristot-de-Oliveira/tracing-osnoise-Support-multiple-instances-for-RTLA/20211030-033201
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2f111a6fd5b5297b4e92f53798ca086f7c7d33a4
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1f3d628d440af696e2e1ef2315903d001e8bed62
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Daniel-Bristot-de-Oliveira/tracing-osnoise-Support-multiple-instances-for-RTLA/20211030-033201
        git checkout 1f3d628d440af696e2e1ef2315903d001e8bed62
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> kernel/trace/trace_osnoise.c:1208:6: error: no previous prototype for 'notify_new_max_latency' [-Werror=missing-prototypes]
    1208 | void notify_new_max_latency(u64 latency)
         |      ^~~~~~~~~~~~~~~~~~~~~~
   In file included from include/linux/perf_event.h:25,
                    from include/linux/hw_breakpoint.h:5,
                    from kernel/trace/trace.h:15,
                    from kernel/trace/trace_osnoise.c:27:
   arch/arc/include/asm/perf_event.h:126:27: error: 'arc_pmu_cache_map' defined but not used [-Werror=unused-const-variable=]
     126 | static const unsigned int arc_pmu_cache_map[C(MAX)][C(OP_MAX)][C(RESULT_MAX)] = {
         |                           ^~~~~~~~~~~~~~~~~
   arch/arc/include/asm/perf_event.h:91:27: error: 'arc_pmu_ev_hw_map' defined but not used [-Werror=unused-const-variable=]
      91 | static const char * const arc_pmu_ev_hw_map[] = {
         |                           ^~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors


vim +/notify_new_max_latency +1208 kernel/trace/trace_osnoise.c

  1204	
  1205	/*
  1206	 * notify_new_max_latency - Notify a new max latency via fsnotify interface.
  1207	 */
> 1208	void notify_new_max_latency(u64 latency)
  1209	{
  1210		struct osnoise_instance *inst;
  1211		struct trace_array *tr;
  1212	
  1213		rcu_read_lock();
  1214		list_for_each_entry_rcu(inst, &osnoise_instances, list) {
  1215			tr = inst->tr;
  1216			if (tr->max_latency < latency) {
  1217				tr->max_latency = latency;
  1218				latency_fsnotify(tr);
  1219			}
  1220		}
  1221		rcu_read_unlock();
  1222	}
  1223	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 69486 bytes --]

  reply	other threads:[~2021-10-30 16:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-29 19:00 [PATCH V8 0/9] tracing/osnoise: Support multiple instances (for RTLA) Daniel Bristot de Oliveira
2021-10-29 19:00 ` [PATCH V8 1/9] tracing/osnoise: Do not follow tracing_cpumask Daniel Bristot de Oliveira
2021-10-29 19:00 ` [PATCH V8 2/9] tracing/osnoise: Improve comments about barrier need for NMI callbacks Daniel Bristot de Oliveira
2021-10-29 19:00 ` [PATCH V8 3/9] tracing/osnoise: Split workload start from the tracer start Daniel Bristot de Oliveira
2021-10-29 19:00 ` [PATCH V8 4/9] tracing/osnoise: Use start/stop_per_cpu_kthreads() on osnoise_cpus_write() Daniel Bristot de Oliveira
2021-10-29 19:00 ` [PATCH V8 5/9] tracing/osnoise: Support a list of trace_array *tr Daniel Bristot de Oliveira
2021-10-30 16:02   ` kernel test robot [this message]
2021-10-29 19:00 ` [PATCH V8 6/9] tracing/osnoise: Remove TIMERLAT ifdefs from inside functions Daniel Bristot de Oliveira
2021-10-29 19:00 ` [PATCH V8 7/9] tracing/osnoise: Allow multiple instances of the same tracer Daniel Bristot de Oliveira
2021-10-29 19:00 ` [PATCH V8 8/9] tracing/osnoise: Remove STACKTRACE ifdefs from inside functions Daniel Bristot de Oliveira
2021-10-29 19:00 ` [PATCH V8 9/9] tracing/osnoise: Remove PREEMPT_RT " Daniel Bristot de Oliveira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202110310010.kbLQGxcu-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.