Re: [RFC PATCH 3/4] drivers/net/virtio_net: Added basic RSS support.

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4008 bytes --]

Hi Andrew,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on mst-vhost/linux-next]
[also build test ERROR on net-next/master net/master linus/master v5.15-rc7 next-20211029]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Andrew-Melnychenko/Added-RSS-support/20211031-130048
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8bcc65dfaae7855d3748ce0a1b03466a8048540f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Andrew-Melnychenko/Added-RSS-support/20211031-130048
        git checkout 8bcc65dfaae7855d3748ce0a1b03466a8048540f
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nios2 SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

Note: the linux-review/Andrew-Melnychenko/Added-RSS-support/20211031-130048 HEAD 385fe5b07bf0ded4667d57d48eacf27e3d4e3733 builds fine.
      It only hurts bisectability.

All errors (new ones prefixed by >>):

   drivers/net/virtio_net.c: In function 'virtnet_init_default_rss':
>> drivers/net/virtio_net.c:2260:49: error: 'struct virtnet_info' has no member named 'rss_hash_types_supported'
    2260 |         vi->ctrl->rss.table_info.hash_types = vi->rss_hash_types_supported;
         |                                                 ^~
>> drivers/net/virtio_net.c:2261:11: error: 'struct virtnet_info' has no member named 'rss_hash_types_saved'
    2261 |         vi->rss_hash_types_saved = vi->rss_hash_types_supported;
         |           ^~
   drivers/net/virtio_net.c:2261:38: error: 'struct virtnet_info' has no member named 'rss_hash_types_supported'
    2261 |         vi->rss_hash_types_saved = vi->rss_hash_types_supported;
         |                                      ^~
   drivers/net/virtio_net.c: In function 'virtnet_probe':
   drivers/net/virtio_net.c:3369:19: error: 'struct virtnet_info' has no member named 'rss_hash_types_supported'
    3369 |                 vi->rss_hash_types_supported =
         |                   ^~
   drivers/net/virtio_net.c:3371:19: error: 'struct virtnet_info' has no member named 'rss_hash_types_supported'
    3371 |                 vi->rss_hash_types_supported &=
         |                   ^~


vim +2260 drivers/net/virtio_net.c

  2254	
  2255	static void virtnet_init_default_rss(struct virtnet_info *vi)
  2256	{
  2257		u32 indir_val = 0;
  2258		int i = 0;
  2259	
> 2260		vi->ctrl->rss.table_info.hash_types = vi->rss_hash_types_supported;
> 2261		vi->rss_hash_types_saved = vi->rss_hash_types_supported;
  2262		vi->ctrl->rss.table_info.indirection_table_mask = vi->rss_indir_table_size - 1;
  2263		vi->ctrl->rss.table_info.unclassified_queue = 0;
  2264	
  2265		for (; i < vi->rss_indir_table_size; ++i) {
  2266			indir_val = ethtool_rxfh_indir_default(i, vi->max_queue_pairs);
  2267			vi->ctrl->rss.indirection_table[i] = indir_val;
  2268		}
  2269	
  2270		vi->ctrl->rss.key_info.max_tx_vq = vi->curr_queue_pairs;
  2271		vi->ctrl->rss.key_info.hash_key_length = vi->rss_key_size;
  2272	
  2273		netdev_rss_key_fill(vi->ctrl->rss.key, vi->rss_key_size);
  2274	}
  2275	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 61048 bytes --]