From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0901DC433F5 for ; Mon, 1 Nov 2021 17:15:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DECCD60273 for ; Mon, 1 Nov 2021 17:15:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231666AbhKARSJ (ORCPT ); Mon, 1 Nov 2021 13:18:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:41846 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230362AbhKARSI (ORCPT ); Mon, 1 Nov 2021 13:18:08 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5B0F8600EF; Mon, 1 Nov 2021 17:15:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635786934; bh=iW0jX+JGZ1kR+9PxaNe1RitHU/yRsHCkwQ7VbmILO44=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=VOkq2PU7rLowutLIOQFodk4Q+F6I/uzSv+9hYg3lw0wpElWuPhMRqc/f+3XNguhSX eZKJbpO2hKkFivM92Bl7MVjunz581t4evk94bKGLue1VFBtbKpds3WMxp/F4GPOSjs yTL+zA1szTnk2MGzakowrYZs08daPmCgIQRz+nHdwWaP0VRXu5EuhhxW4peTHZrqcG 6XoirIHtn/P+Zat+8U9mn/FBHG3AcePoRZY8D+GCFWQnGIakdyPU9A4xp6xkUAwrV5 L+p9vvBVbD/BoEY3h6fmXolC1Ct3f4erPD+Z1OHR+tL1F8xOeKre2XDe+CDciA9JBE hi0rP+EAUP50w== Date: Mon, 1 Nov 2021 12:15:33 -0500 From: Bjorn Helgaas To: kernel test robot , kbuild-all-owner@lists.01.org Cc: Xuesong Chen , kbuild-all@lists.01.org, linux-pci@vger.kernel.org, Konstantin Ryabitsev Subject: Re: [PATCH v4 3/4] ACPI: APEI: Reserve the MCFG address for quirk ECAM implementation Message-ID: <20211101171533.GA527894@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202110280656.2MEz43OU-lkp@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org [+cc linux-pci, Konstantin, since you're thinking about this area, too] The 0-day bot seems to remove mailing lists from the recipient list, which means reports like the one below don't become part of the public email thread and don't get connected to the patch in patchwork. I think this is a problem. For example here are Xuesong's original patch, the patch in patchwork, and the 0-day bot report: https://lore.kernel.org/all/20211027081312.53682-1-xuesong.chen@linux.alibaba.com/ https://patchwork.kernel.org/project/linux-pci/patch/20211027081312.53682-1-xuesong.chen@linux.alibaba.com/ https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/QISVC5TJIHTEMAPX7T7YXOZEDS5CBURY/ Neither the lore link nor the patchwork have any indication that the 0-day bot found a problem. It looks like the 0-day bot sent the report to all the individual recipients from the original patch, but it ADDED these recipients: llvm@lists.linux.dev kbuild-all@lists.01.org and REMOVED these: linux-pci@vger.kernel.org linux-acpi@vger.kernel.org linux-arm-kernel@lists.infradead.org linux-kernel@vger.kernel.org Gmail filed Xuesong's original patch and the 0-day report as spam. That's a problem on my end, but the bigger problem is that I work from the patchwork queue, which has no indication of the problem. I'm sure you have a reason for removing the mailing lists. Should we revisit that? Should I be approaching this a different way? If a *person* responds to a patch on the list, I expect a reply-all so the response becomes part of the thread. Why should the 0-day bot be different? I added linux-pci to cc, but since the 0-day report didn't go to the list, I don't think this message will be threaded correctly on lore. It should be part of https://lore.kernel.org/all/20211027081035.53370-1-xuesong.chen@linux.alibaba.com/ On Thu, Oct 28, 2021 at 06:46:16AM +0800, kernel test robot wrote: > Hi Xuesong, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on helgaas-pci/next] > [also build test WARNING on rafael-pm/linux-next tip/x86/core arm64/for-next/core v5.15-rc7 next-20211027] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Xuesong-Chen/PCI-MCFG-Consolidate-the-separate-PCI-MCFG-table-entry-list/20211027-171229 > base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next > config: x86_64-randconfig-s022-20211027 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce: > # apt-get install sparse > # sparse version: v0.6.4-dirty > # https://github.com/0day-ci/linux/commit/8fce66d9da6f8e55c5cf0dda4a13dba6bd51492d > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Xuesong-Chen/PCI-MCFG-Consolidate-the-separate-PCI-MCFG-table-entry-list/20211027-171229 > git checkout 8fce66d9da6f8e55c5cf0dda4a13dba6bd51492d > # save the attached .config to linux build tree > make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/acpi/apei/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > > sparse warnings: (new ones prefixed by >>) > >> drivers/acpi/apei/apei-base.c:453:5: sparse: sparse: symbol 'remove_quirk_mcfg_res' was not declared. Should it be static? > drivers/acpi/apei/apei-base.c:804:12: sparse: sparse: symbol 'arch_apei_enable_cmcff' was not declared. Should it be static? > drivers/acpi/apei/apei-base.c:811:13: sparse: sparse: symbol 'arch_apei_report_mem_error' was not declared. Should it be static? > > Please review and possibly fold the followup patch. > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2845252276861121590==" MIME-Version: 1.0 From: Bjorn Helgaas To: kbuild-all@lists.01.org Subject: Re: [PATCH v4 3/4] ACPI: APEI: Reserve the MCFG address for quirk ECAM implementation Date: Mon, 01 Nov 2021 12:15:33 -0500 Message-ID: <20211101171533.GA527894@bhelgaas> In-Reply-To: <202110280656.2MEz43OU-lkp@intel.com> List-Id: --===============2845252276861121590== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [+cc linux-pci, Konstantin, since you're thinking about this area, too] The 0-day bot seems to remove mailing lists from the recipient list, which means reports like the one below don't become part of the public email thread and don't get connected to the patch in patchwork. I think this is a problem. For example here are Xuesong's original patch, the patch in patchwork, and the 0-day bot report: https://lore.kernel.org/all/20211027081312.53682-1-xuesong.chen(a)linux.a= libaba.com/ https://patchwork.kernel.org/project/linux-pci/patch/20211027081312.53682= -1-xuesong.chen(a)linux.alibaba.com/ https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org/thread/QIS= VC5TJIHTEMAPX7T7YXOZEDS5CBURY/ Neither the lore link nor the patchwork have any indication that the 0-day bot found a problem. It looks like the 0-day bot sent the report to all the individual recipients from the original patch, but it ADDED these recipients: llvm(a)lists.linux.dev kbuild-all(a)lists.01.org and REMOVED these: linux-pci(a)vger.kernel.org linux-acpi(a)vger.kernel.org linux-arm-kernel(a)lists.infradead.org linux-kernel(a)vger.kernel.org Gmail filed Xuesong's original patch and the 0-day report as spam. That's a problem on my end, but the bigger problem is that I work from the patchwork queue, which has no indication of the problem. I'm sure you have a reason for removing the mailing lists. Should we revisit that? Should I be approaching this a different way? If a *person* responds to a patch on the list, I expect a reply-all so the response becomes part of the thread. Why should the 0-day bot be different? I added linux-pci to cc, but since the 0-day report didn't go to the list, I don't think this message will be threaded correctly on lore. It should be part of https://lore.kernel.org/all/20211027081035.53370-1-xuesong.chen(a)linux.ali= baba.com/ On Thu, Oct 28, 2021 at 06:46:16AM +0800, kernel test robot wrote: > Hi Xuesong, > = > Thank you for the patch! Perhaps something to improve: > = > [auto build test WARNING on helgaas-pci/next] > [also build test WARNING on rafael-pm/linux-next tip/x86/core arm64/for-n= ext/core v5.15-rc7 next-20211027] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > = > url: https://github.com/0day-ci/linux/commits/Xuesong-Chen/PCI-MCFG-Co= nsolidate-the-separate-PCI-MCFG-table-entry-list/20211027-171229 > base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git n= ext > config: x86_64-randconfig-s022-20211027 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce: > # apt-get install sparse > # sparse version: v0.6.4-dirty > # https://github.com/0day-ci/linux/commit/8fce66d9da6f8e55c5cf0dd= a4a13dba6bd51492d > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Xuesong-Chen/PCI-MCFG-Consolidat= e-the-separate-PCI-MCFG-table-entry-list/20211027-171229 > git checkout 8fce66d9da6f8e55c5cf0dda4a13dba6bd51492d > # save the attached .config to linux build tree > make W=3D1 C=3D1 CF=3D'-fdiagnostic-prefix -D__CHECK_ENDIAN__' O= =3Dbuild_dir ARCH=3Dx86_64 SHELL=3D/bin/bash drivers/acpi/apei/ > = > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > = > = > sparse warnings: (new ones prefixed by >>) > >> drivers/acpi/apei/apei-base.c:453:5: sparse: sparse: symbol 'remove_qu= irk_mcfg_res' was not declared. Should it be static? > drivers/acpi/apei/apei-base.c:804:12: sparse: sparse: symbol 'arch_ape= i_enable_cmcff' was not declared. Should it be static? > drivers/acpi/apei/apei-base.c:811:13: sparse: sparse: symbol 'arch_ape= i_report_mem_error' was not declared. Should it be static? > = > Please review and possibly fold the followup patch. > = > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============2845252276861121590==--