From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3B46C433F5 for ; Mon, 1 Nov 2021 18:21:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7F8D60F24 for ; Mon, 1 Nov 2021 18:21:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229610AbhKASYY (ORCPT ); Mon, 1 Nov 2021 14:24:24 -0400 Received: from mail-bn8nam11on2067.outbound.protection.outlook.com ([40.107.236.67]:65248 "EHLO NAM11-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229528AbhKASYW (ORCPT ); Mon, 1 Nov 2021 14:24:22 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FK35FHxRpulz8PCPtC8ljkEeRfgyFkl2wGV1ZjbsTw3nrAeVY25B6abMm1YsG9h8TgBNCrVUo0/pza0+oteRMqp6Rm0WUcoIAfQS1/C0uQh0A1zmNW/8n22KoBuU9rj88nl1QKsZfVStORJ55j5PZUN1PJiUIyekfiGVRU31ty8B76tf7Gi0fZ27x0wN1AblUvrJNdvQ/bEO9ydFOZjWNE25l0MaKWeiPZTvtSCqTYG+XR0y80tBAh50ES/o5CSuK7rZS9OOUwVaP+YLlaUcVOR+wUmVS6lOlEd3XPfCIbSHfdfzk7cvPg/7ADbknRkGm2rf+n3U+SaqyH+0l40PuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kNu7/3hRlc6Ufgn9D3PHykFgnyKTWnRC17mkwWP7n/o=; b=gcgYy4GB/yd5VsbISYmTJ3M8YicncJ3MC2RGMIcxd/5xg8LnP2jxLGT+HnfqlpZjuyr/KYGJs25SXy6L4PNv7gyNl3QhXm40SJl9UFVAn3zi/yhwAIBdGheMjHQHN5UmdS3UjXLr/gCYlnuDD7f5SpZYs34VpjPEUq52kYQYSFt6x1oJlsgQCu0Lb4L6XY8uYOHn/9wPG7Wq0H1+cNYW+pO3zd7eyYqBvr8YoZbTlMDYIn3RE782FY/IweXT3LLDWuFeXtyI7GlCjPMlAZUHFibPsLGqmOa7iugVw7jCNl9tK6hriSOr6pZ+L0jt+77tEpwOIsOYSmOdpOYNeH8wiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kNu7/3hRlc6Ufgn9D3PHykFgnyKTWnRC17mkwWP7n/o=; b=B3MraNbuxmnll4xE8g/RiD+V7ENrpP4/tK9bJt3/hsVGQH7HxRP51q8uS/omqbjaZEBfOPmAhuP+R0vSKqJoMODHUBxSjqYD0td1w53r/mIDf1xTIgAsDfbXCG4ud2ei20qE/906pin/11QhHUjlZss3iylQNUahPX0A3z4XrvfanKsMF77Q3UQ2viNKgLgSLvcByj7q/LKJLE2RB+TVQKkqux6JhKbCNzQUfGS3yLj2mE3tGgxdMO5+KAyjkwSXDRFDxini2ChxudGeUiySp7xgBfNaQvVpZNXD+aG2LwpfR9YB0bS7fbzTBRY/tgjn+z4cY9PgE7ylX2zl6fPwpg== Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22) by BL1PR12MB5378.namprd12.prod.outlook.com (2603:10b6:208:31d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Mon, 1 Nov 2021 18:03:15 +0000 Received: from BL0PR12MB5506.namprd12.prod.outlook.com ([fe80::e8af:232:915e:2f95]) by BL0PR12MB5506.namprd12.prod.outlook.com ([fe80::e8af:232:915e:2f95%8]) with mapi id 15.20.4649.019; Mon, 1 Nov 2021 18:03:15 +0000 Date: Mon, 1 Nov 2021 15:03:14 -0300 From: Jason Gunthorpe To: Pali =?utf-8?B?Um9ow6Fy?= Cc: Russell King , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Thomas Bogendoerfer , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: Marvell: Update PCIe fixup Message-ID: <20211101180314.GE2744544@nvidia.com> References: <20211101150405.14618-1-pali@kernel.org> <20211101162711.GA2744544@nvidia.com> <20211101175649.q743eg65jpjtk7sd@pali> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211101175649.q743eg65jpjtk7sd@pali> X-ClientProxiedBy: BL1PR13CA0153.namprd13.prod.outlook.com (2603:10b6:208:2bd::8) To BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22) MIME-Version: 1.0 Received: from mlx.ziepe.ca (142.162.113.129) by BL1PR13CA0153.namprd13.prod.outlook.com (2603:10b6:208:2bd::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.4 via Frontend Transport; Mon, 1 Nov 2021 18:03:15 +0000 Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1mhbeM-004q7N-N3; Mon, 01 Nov 2021 15:03:14 -0300 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 072cbb6c-8dc1-48c6-2989-08d99d61e0b5 X-MS-TrafficTypeDiagnostic: BL1PR12MB5378: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 71wBBFhenfpZBToqmc456nfQwJbxJXwOXUqnSYuupNSO4h/bPMhs/b91F1rDb5gWiuGrdNJLBt9WGQm0qy5eaJCG6AQXiMkOcvLrN/5H4NioclOtEfIUquArOOKQgGoO/cotPWGDUAjEtZlB7tbs6Jo64DAKd2lSBHSXEN0wFjAHfevFm03U+eGN5GDGpidgOmwQ6tiCAqtlXEdQPoYgosJD0ErIED5EaSnGQXMB1nOhqHwdWlTEFLIVIkNOxLIVnazR/NBOZ0v3AKPsmL7Fisig+prT8hm9pUwGjVGP/bEu/XNWCbvATNjsYLcu3mIGCWKAeC2ayUhrOL+yAS43s+MSyaOsb+JR6lFIyzW1q09UjRs7av+CcAIs6duKexZwA0l89gRq3IFM5dtI3hmuWxzEq65Cj41N8iAiUKIXwKYHgkJFXLoWP5b+sHWBPITRGmK1QMiaid2B948ZxQvb1xOTH4aosA5PdOYEaLkFfpwHoeS+EZlHMecbcjRFXUQatdWt8yZpWMieVQT6PLGucub8+vNvBf82Z4o7SdRoCO9C2nF2wqVOp8KMgcvH/6aA1XiQER5U4+bpxa2szsbkzrS69RXPTCB/cnzcdsGlUjg/oNFE6fzqAZsN55S9Y7gd6OsBje3RxQxBqoyFwJPBY4Ix7pIiCZ+637budWOTL/zwTfXtTFVWymbb9BtiwPVYYq8rN0vfKVEfYGXF/zcY58MkoS3XNLyuFmZlNiDIuu8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB5506.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66946007)(83380400001)(7416002)(66476007)(15650500001)(66556008)(966005)(9746002)(33656002)(186003)(8936002)(426003)(1076003)(54906003)(26005)(9786002)(38100700002)(2906002)(6916009)(86362001)(4326008)(316002)(36756003)(8676002)(5660300002)(66574015)(508600001)(2616005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUhHWTJkL3dCbGFGcTVENm5ZZ3ovcy8xdE16a2ppTlJNMTNUdlA4T1NDWHFz?= =?utf-8?B?RHIvZXBMQVZqZWxhUjcvVUF3WktSQjdVNE5XNXRYL2hRdER5MnpyTEIrdnJT?= =?utf-8?B?T0VFdG9ySFRzMCtESnVSWmFOTlo2WEpTaUxhQldFVlhOd1kyRnJzYjdmdWlF?= =?utf-8?B?bmhQNjNwa2MwZnFwcXV0TlpOcFlpOEpialVVT082TTM1cENiZ3dNU0F1cGZZ?= =?utf-8?B?aHhTUnhMd0hlaHdzb0pSMWFSRWNnV0lVK1Q3MFZ2NjU0clMrTUpBbVF4czJs?= =?utf-8?B?SER2WFFFSTVsNnBkWGgrUmpPS2ZMUnVTR1dmajRsS3BsWkhjTjBKbzFWUmln?= =?utf-8?B?Sm9EQk10R2w5Q3hRcjMzUDhicEtUc0dlWWdWSENvTnllL1BJRkhaL2lRRjNZ?= =?utf-8?B?TkI3TldUWWZkMWJMa3hSOVFOZzJhRmIyNUxyZFN2WUY4OEtlZXl1WGFoOFJU?= =?utf-8?B?OUdIVnV6WmM0cTJjVndKTHpIVUNtK0pxNHlDa2hVNHcyT0hTcHZMcVZwblpa?= =?utf-8?B?eGpFdkRyQWwyR2VkcU0wejlOMHlGckxnV2pXR3MwTjlKWWV5dG85cUtnZU8r?= =?utf-8?B?RjdHd0d5VERJVDd6U29zYlE2WUJqQUpEZHhyRXVMUEpac3pVRWFkQWthZlZI?= =?utf-8?B?NHRFTWlBNXdsRnc5cWdWK2pScjBoQ2ozSGlNeFBISmlnSmJJWHZRdGwwbG15?= =?utf-8?B?N0FhK2tQOHk1Q3Qra2dVc2l0cXhVWnE1UUFoQS85ckR2eXNJalMxN01VZHBB?= =?utf-8?B?Z3JvejdkRlUzczJ6VW44enhoSVBkUHNUUXJpV1dGSHUyNXo5SXJhUE82cXNi?= =?utf-8?B?Ky9PVUoxNlJSRm9DVWRsbjRuUi96a2QxMUdMV1JiOWNZMXdhSFl3NnI1WEpu?= =?utf-8?B?U2tiZTlOdXo5T0Z0SUl4V2pwUG9tNDBva2dWRlB6SHFkR0srNU5VenFGMk0z?= =?utf-8?B?ZzBiVFYyTGdid2xGU3NXdFV0UkxGa2R4K1Q3VHIvNGlSVTREMzB6d0JSaHQ4?= =?utf-8?B?c0tzbjB5cFZqYW5ZbUYxajY0OHoyaDhoZmZKMzQ3amxXOHUrUmpUQXk3azZk?= =?utf-8?B?cnROYjZueDQ3NUIrdWNSVVBOOVNZeHlRTXZkOFBqdXc0MEp0dE9oTStVVVdy?= =?utf-8?B?WkRzZTN1OENsNlpjQXhhVGN5bU9sdWhiZDJBOE5PUk43MnNtdk1xR2pPWWJC?= =?utf-8?B?U0dGUUtrRGliVHJCTlRqNG1KbldjSy8wb1BndDlEa3dGalZWakRrVkUyMU5n?= =?utf-8?B?R2xHYjhBWm45REFNQmpVZStMSG9WWTdiTmJyajdZZ0pqa0YxQlJLTFRDdmlD?= =?utf-8?B?aTVhQnhFMXdXQld3R1UzcWdLZWZ0aDZ0RG42M1hMVkRVY09lRm9GRnJ1bURG?= =?utf-8?B?dVpjTXRwQWFoTzQ1UXMrSFdVZHZmMnRmN2NzcXh5OGZhaUxCeDJTT1UrMzk5?= =?utf-8?B?aERhajNheWIvdjlKaVFNRDdLVWFYU2c5dkpUbVVITE1lT1ZMTHFjZFVrenNR?= =?utf-8?B?R1UrYzdQWjg4Q3R4Z3VYOVVBU3FXdm1taTFUd0hTOWJCN1V4QTdpOGNwaGw1?= =?utf-8?B?c1lIYUNyM2pnWjZxVTB4SEhPam1rTXJ4YVdZYkVlOC9lVHRnNHlJOXd3NVJH?= =?utf-8?B?WEFVaWFpQk9jQ2VLSHlYaFhmVmFHZXR2Q0t6eVYvdTVEUFR0eUxYMGpLUU5I?= =?utf-8?B?UVIyYVRiTC9KR1JndUdQWTF2eEJ4c2Q4Q2dqSllSVXF6WTFoVnB5a0hsWml4?= =?utf-8?B?UzRJK05jTEFSWXdXeGcxRE1TUFRlZDd3aHJqejcvVjNsZWE5MDZpTGFyWFpq?= =?utf-8?B?T09aMGlZYWRNSStkUnVYTEpRL0tHUGEzdWVnMnU3SVBpMmVWRmhRTUdQWFg1?= =?utf-8?B?L1o4L3F6Wm54Wlp1QmJ2YzF3YmxOMWQwR09sR25uOC9NSUV4SHpVR08zTFZ0?= =?utf-8?B?TmhiNDloa0QxWkx6RFdJQmRNOS9Ub0dwb1pJcWFLLzgvS1VXNzNNdlV3WGt1?= =?utf-8?B?Q29ySlViT1hzT2ZzK3Iya3BoQkxHWFUyaTZUVTJJV0hIdlRVd2duK0FpcUow?= =?utf-8?B?Wll5UEh0S1ZOa3p6QjhwbHpibXNuQ002YXZ4Qm9UVWVnanVsc0NtSlI4RnRr?= =?utf-8?Q?Z+0g=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 072cbb6c-8dc1-48c6-2989-08d99d61e0b5 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2021 18:03:15.8208 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cls5k4KgIYefZrULGpZb/ZdxslNcGF9iuEuctzgqVnAttqi/Rl02STUr+5szP1rj X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5378 Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Mon, Nov 01, 2021 at 06:56:49PM +0100, Pali Rohár wrote: > On Monday 01 November 2021 13:27:11 Jason Gunthorpe wrote: > > On Mon, Nov 01, 2021 at 04:04:05PM +0100, Pali Rohár wrote: > > > - The code relies on rc_pci_fixup being called, which only happens > > > when CONFIG_PCI_QUIRKS is enabled, so add that to Kconfig. Omitting > > > this causes a booting failure with a non-obvious cause. > > > - Update rc_pci_fixup to set the class properly, copying the > > > more modern style from other places > > > - Correct the rc_pci_fixup comment > > > > > > This patch just re-applies commit 1dc831bf53fd ("ARM: Kirkwood: Update > > > PCI-E fixup") for all other Marvell platforms which use same buggy PCIe > > > controller. > > > > I wonder if that code is even relevant any more since we started using > > CONFIG_PCI_MVEBU > > > > ? > > It is (still) relevant for platforms which do not use CONFIG_PCI_MVEBU > yet. I think you should explain this in the commit message > > Really, these broken controllers should not be used "raw" but always > > via their special host bridge driver that fixes all the config space > > problems. > > I agree. > > Long-term goal should be to convert these platforms to use pci-mvebu.c > driver. And until it happens simple fixes like in commit 1dc831bf53fd is > needed for all affected Marvell platforms. IIRC all these platforms were obsolete before I wrote the above commit, so I'm not sure why this has suddenly cropped up? If you want to use a new kernel on this really old HW then update to use the right PCI driver? > Some details how these Marvell PCIe controllers are broken is in email: > https://lore.kernel.org/linux-pci/20211003120944.3lmwxylnhlp2kfj7@pali/ Yes, everything about this controller is broken. It does not function properly without its driver. The solution to these bugs is to use the driver, which was specifically made to deal with them. That said, I can't recall if this driver needs some fixing to work with pre-kirkwood systems.. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57D2FC433EF for ; Mon, 1 Nov 2021 18:04:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 157D760EDF for ; Mon, 1 Nov 2021 18:04:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 157D760EDF Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q/uLITsrO+a6w/c/ZkfsvTK3l2eU1WTjDgR6Dm65d2Y=; b=R/aMpt2mkHx1gT vRUlgESex+2NtSmxP17sTPSQ84aPPTiFCnP4Peh8kDxJEv1aK+uxtf15IIXzpkku/l5OnF+b3TgNJ 2Si70kcnw0E93Zhca4czikD93MxOJCJUSCA/Z3vuyvyhCDiPbtJYJjzIvL/4PQSFyMy4EFghTikYo /KHIKUnJZ2vjQR6c72qUmLctvAoGr6CV5oXL/rkyv9tY8PPioX59Kqs9Jtjz/QqfMDRAkJDMbVyex 2fXeS5gJvpxzy932SsD5q6hzU/hN4TJjJZ5hfRKMnjcgsVRke341MRsKF33FDPFi8qsVY1EmFVM7Q wXqGOknLQjytj18sxQWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhbeU-00Gz1n-TC; Mon, 01 Nov 2021 18:03:23 +0000 Received: from mail-mw2nam12on2047.outbound.protection.outlook.com ([40.107.244.47] helo=NAM12-MW2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhbeR-00Gz16-1b for linux-arm-kernel@lists.infradead.org; Mon, 01 Nov 2021 18:03:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FK35FHxRpulz8PCPtC8ljkEeRfgyFkl2wGV1ZjbsTw3nrAeVY25B6abMm1YsG9h8TgBNCrVUo0/pza0+oteRMqp6Rm0WUcoIAfQS1/C0uQh0A1zmNW/8n22KoBuU9rj88nl1QKsZfVStORJ55j5PZUN1PJiUIyekfiGVRU31ty8B76tf7Gi0fZ27x0wN1AblUvrJNdvQ/bEO9ydFOZjWNE25l0MaKWeiPZTvtSCqTYG+XR0y80tBAh50ES/o5CSuK7rZS9OOUwVaP+YLlaUcVOR+wUmVS6lOlEd3XPfCIbSHfdfzk7cvPg/7ADbknRkGm2rf+n3U+SaqyH+0l40PuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kNu7/3hRlc6Ufgn9D3PHykFgnyKTWnRC17mkwWP7n/o=; b=gcgYy4GB/yd5VsbISYmTJ3M8YicncJ3MC2RGMIcxd/5xg8LnP2jxLGT+HnfqlpZjuyr/KYGJs25SXy6L4PNv7gyNl3QhXm40SJl9UFVAn3zi/yhwAIBdGheMjHQHN5UmdS3UjXLr/gCYlnuDD7f5SpZYs34VpjPEUq52kYQYSFt6x1oJlsgQCu0Lb4L6XY8uYOHn/9wPG7Wq0H1+cNYW+pO3zd7eyYqBvr8YoZbTlMDYIn3RE782FY/IweXT3LLDWuFeXtyI7GlCjPMlAZUHFibPsLGqmOa7iugVw7jCNl9tK6hriSOr6pZ+L0jt+77tEpwOIsOYSmOdpOYNeH8wiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kNu7/3hRlc6Ufgn9D3PHykFgnyKTWnRC17mkwWP7n/o=; b=B3MraNbuxmnll4xE8g/RiD+V7ENrpP4/tK9bJt3/hsVGQH7HxRP51q8uS/omqbjaZEBfOPmAhuP+R0vSKqJoMODHUBxSjqYD0td1w53r/mIDf1xTIgAsDfbXCG4ud2ei20qE/906pin/11QhHUjlZss3iylQNUahPX0A3z4XrvfanKsMF77Q3UQ2viNKgLgSLvcByj7q/LKJLE2RB+TVQKkqux6JhKbCNzQUfGS3yLj2mE3tGgxdMO5+KAyjkwSXDRFDxini2ChxudGeUiySp7xgBfNaQvVpZNXD+aG2LwpfR9YB0bS7fbzTBRY/tgjn+z4cY9PgE7ylX2zl6fPwpg== Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22) by BL1PR12MB5378.namprd12.prod.outlook.com (2603:10b6:208:31d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Mon, 1 Nov 2021 18:03:15 +0000 Received: from BL0PR12MB5506.namprd12.prod.outlook.com ([fe80::e8af:232:915e:2f95]) by BL0PR12MB5506.namprd12.prod.outlook.com ([fe80::e8af:232:915e:2f95%8]) with mapi id 15.20.4649.019; Mon, 1 Nov 2021 18:03:15 +0000 Date: Mon, 1 Nov 2021 15:03:14 -0300 From: Jason Gunthorpe To: Pali =?utf-8?B?Um9ow6Fy?= Cc: Russell King , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Thomas Bogendoerfer , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: Marvell: Update PCIe fixup Message-ID: <20211101180314.GE2744544@nvidia.com> References: <20211101150405.14618-1-pali@kernel.org> <20211101162711.GA2744544@nvidia.com> <20211101175649.q743eg65jpjtk7sd@pali> Content-Disposition: inline In-Reply-To: <20211101175649.q743eg65jpjtk7sd@pali> X-ClientProxiedBy: BL1PR13CA0153.namprd13.prod.outlook.com (2603:10b6:208:2bd::8) To BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22) MIME-Version: 1.0 Received: from mlx.ziepe.ca (142.162.113.129) by BL1PR13CA0153.namprd13.prod.outlook.com (2603:10b6:208:2bd::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.4 via Frontend Transport; Mon, 1 Nov 2021 18:03:15 +0000 Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1mhbeM-004q7N-N3; Mon, 01 Nov 2021 15:03:14 -0300 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 072cbb6c-8dc1-48c6-2989-08d99d61e0b5 X-MS-TrafficTypeDiagnostic: BL1PR12MB5378: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 71wBBFhenfpZBToqmc456nfQwJbxJXwOXUqnSYuupNSO4h/bPMhs/b91F1rDb5gWiuGrdNJLBt9WGQm0qy5eaJCG6AQXiMkOcvLrN/5H4NioclOtEfIUquArOOKQgGoO/cotPWGDUAjEtZlB7tbs6Jo64DAKd2lSBHSXEN0wFjAHfevFm03U+eGN5GDGpidgOmwQ6tiCAqtlXEdQPoYgosJD0ErIED5EaSnGQXMB1nOhqHwdWlTEFLIVIkNOxLIVnazR/NBOZ0v3AKPsmL7Fisig+prT8hm9pUwGjVGP/bEu/XNWCbvATNjsYLcu3mIGCWKAeC2ayUhrOL+yAS43s+MSyaOsb+JR6lFIyzW1q09UjRs7av+CcAIs6duKexZwA0l89gRq3IFM5dtI3hmuWxzEq65Cj41N8iAiUKIXwKYHgkJFXLoWP5b+sHWBPITRGmK1QMiaid2B948ZxQvb1xOTH4aosA5PdOYEaLkFfpwHoeS+EZlHMecbcjRFXUQatdWt8yZpWMieVQT6PLGucub8+vNvBf82Z4o7SdRoCO9C2nF2wqVOp8KMgcvH/6aA1XiQER5U4+bpxa2szsbkzrS69RXPTCB/cnzcdsGlUjg/oNFE6fzqAZsN55S9Y7gd6OsBje3RxQxBqoyFwJPBY4Ix7pIiCZ+637budWOTL/zwTfXtTFVWymbb9BtiwPVYYq8rN0vfKVEfYGXF/zcY58MkoS3XNLyuFmZlNiDIuu8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR12MB5506.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66946007)(83380400001)(7416002)(66476007)(15650500001)(66556008)(966005)(9746002)(33656002)(186003)(8936002)(426003)(1076003)(54906003)(26005)(9786002)(38100700002)(2906002)(6916009)(86362001)(4326008)(316002)(36756003)(8676002)(5660300002)(66574015)(508600001)(2616005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUhHWTJkL3dCbGFGcTVENm5ZZ3ovcy8xdE16a2ppTlJNMTNUdlA4T1NDWHFz?= =?utf-8?B?RHIvZXBMQVZqZWxhUjcvVUF3WktSQjdVNE5XNXRYL2hRdER5MnpyTEIrdnJT?= =?utf-8?B?T0VFdG9ySFRzMCtESnVSWmFOTlo2WEpTaUxhQldFVlhOd1kyRnJzYjdmdWlF?= =?utf-8?B?bmhQNjNwa2MwZnFwcXV0TlpOcFlpOEpialVVT082TTM1cENiZ3dNU0F1cGZZ?= =?utf-8?B?aHhTUnhMd0hlaHdzb0pSMWFSRWNnV0lVK1Q3MFZ2NjU0clMrTUpBbVF4czJs?= =?utf-8?B?SER2WFFFSTVsNnBkWGgrUmpPS2ZMUnVTR1dmajRsS3BsWkhjTjBKbzFWUmln?= =?utf-8?B?Sm9EQk10R2w5Q3hRcjMzUDhicEtUc0dlWWdWSENvTnllL1BJRkhaL2lRRjNZ?= =?utf-8?B?TkI3TldUWWZkMWJMa3hSOVFOZzJhRmIyNUxyZFN2WUY4OEtlZXl1WGFoOFJU?= =?utf-8?B?OUdIVnV6WmM0cTJjVndKTHpIVUNtK0pxNHlDa2hVNHcyT0hTcHZMcVZwblpa?= =?utf-8?B?eGpFdkRyQWwyR2VkcU0wejlOMHlGckxnV2pXR3MwTjlKWWV5dG85cUtnZU8r?= =?utf-8?B?RjdHd0d5VERJVDd6U29zYlE2WUJqQUpEZHhyRXVMUEpac3pVRWFkQWthZlZI?= =?utf-8?B?NHRFTWlBNXdsRnc5cWdWK2pScjBoQ2ozSGlNeFBISmlnSmJJWHZRdGwwbG15?= =?utf-8?B?N0FhK2tQOHk1Q3Qra2dVc2l0cXhVWnE1UUFoQS85ckR2eXNJalMxN01VZHBB?= =?utf-8?B?Z3JvejdkRlUzczJ6VW44enhoSVBkUHNUUXJpV1dGSHUyNXo5SXJhUE82cXNi?= =?utf-8?B?Ky9PVUoxNlJSRm9DVWRsbjRuUi96a2QxMUdMV1JiOWNZMXdhSFl3NnI1WEpu?= =?utf-8?B?U2tiZTlOdXo5T0Z0SUl4V2pwUG9tNDBva2dWRlB6SHFkR0srNU5VenFGMk0z?= =?utf-8?B?ZzBiVFYyTGdid2xGU3NXdFV0UkxGa2R4K1Q3VHIvNGlSVTREMzB6d0JSaHQ4?= =?utf-8?B?c0tzbjB5cFZqYW5ZbUYxajY0OHoyaDhoZmZKMzQ3amxXOHUrUmpUQXk3azZk?= =?utf-8?B?cnROYjZueDQ3NUIrdWNSVVBOOVNZeHlRTXZkOFBqdXc0MEp0dE9oTStVVVdy?= =?utf-8?B?WkRzZTN1OENsNlpjQXhhVGN5bU9sdWhiZDJBOE5PUk43MnNtdk1xR2pPWWJC?= =?utf-8?B?U0dGUUtrRGliVHJCTlRqNG1KbldjSy8wb1BndDlEa3dGalZWakRrVkUyMU5n?= =?utf-8?B?R2xHYjhBWm45REFNQmpVZStMSG9WWTdiTmJyajdZZ0pqa0YxQlJLTFRDdmlD?= =?utf-8?B?aTVhQnhFMXdXQld3R1UzcWdLZWZ0aDZ0RG42M1hMVkRVY09lRm9GRnJ1bURG?= =?utf-8?B?dVpjTXRwQWFoTzQ1UXMrSFdVZHZmMnRmN2NzcXh5OGZhaUxCeDJTT1UrMzk5?= =?utf-8?B?aERhajNheWIvdjlKaVFNRDdLVWFYU2c5dkpUbVVITE1lT1ZMTHFjZFVrenNR?= =?utf-8?B?R1UrYzdQWjg4Q3R4Z3VYOVVBU3FXdm1taTFUd0hTOWJCN1V4QTdpOGNwaGw1?= =?utf-8?B?c1lIYUNyM2pnWjZxVTB4SEhPam1rTXJ4YVdZYkVlOC9lVHRnNHlJOXd3NVJH?= =?utf-8?B?WEFVaWFpQk9jQ2VLSHlYaFhmVmFHZXR2Q0t6eVYvdTVEUFR0eUxYMGpLUU5I?= =?utf-8?B?UVIyYVRiTC9KR1JndUdQWTF2eEJ4c2Q4Q2dqSllSVXF6WTFoVnB5a0hsWml4?= =?utf-8?B?UzRJK05jTEFSWXdXeGcxRE1TUFRlZDd3aHJqejcvVjNsZWE5MDZpTGFyWFpq?= =?utf-8?B?T09aMGlZYWRNSStkUnVYTEpRL0tHUGEzdWVnMnU3SVBpMmVWRmhRTUdQWFg1?= =?utf-8?B?L1o4L3F6Wm54Wlp1QmJ2YzF3YmxOMWQwR09sR25uOC9NSUV4SHpVR08zTFZ0?= =?utf-8?B?TmhiNDloa0QxWkx6RFdJQmRNOS9Ub0dwb1pJcWFLLzgvS1VXNzNNdlV3WGt1?= =?utf-8?B?Q29ySlViT1hzT2ZzK3Iya3BoQkxHWFUyaTZUVTJJV0hIdlRVd2duK0FpcUow?= =?utf-8?B?Wll5UEh0S1ZOa3p6QjhwbHpibXNuQ002YXZ4Qm9UVWVnanVsc0NtSlI4RnRr?= =?utf-8?Q?Z+0g=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 072cbb6c-8dc1-48c6-2989-08d99d61e0b5 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2021 18:03:15.8208 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cls5k4KgIYefZrULGpZb/ZdxslNcGF9iuEuctzgqVnAttqi/Rl02STUr+5szP1rj X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5378 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211101_110319_120234_378A19B6 X-CRM114-Status: GOOD ( 25.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBOb3YgMDEsIDIwMjEgYXQgMDY6NTY6NDlQTSArMDEwMCwgUGFsaSBSb2jDoXIgd3Jv dGU6Cj4gT24gTW9uZGF5IDAxIE5vdmVtYmVyIDIwMjEgMTM6Mjc6MTEgSmFzb24gR3VudGhvcnBl IHdyb3RlOgo+ID4gT24gTW9uLCBOb3YgMDEsIDIwMjEgYXQgMDQ6MDQ6MDVQTSArMDEwMCwgUGFs aSBSb2jDoXIgd3JvdGU6Cj4gPiA+IC0gVGhlIGNvZGUgcmVsaWVzIG9uIHJjX3BjaV9maXh1cCBi ZWluZyBjYWxsZWQsIHdoaWNoIG9ubHkgaGFwcGVucwo+ID4gPiAgIHdoZW4gQ09ORklHX1BDSV9R VUlSS1MgaXMgZW5hYmxlZCwgc28gYWRkIHRoYXQgdG8gS2NvbmZpZy4gT21pdHRpbmcKPiA+ID4g ICB0aGlzIGNhdXNlcyBhIGJvb3RpbmcgZmFpbHVyZSB3aXRoIGEgbm9uLW9idmlvdXMgY2F1c2Uu Cj4gPiA+IC0gVXBkYXRlIHJjX3BjaV9maXh1cCB0byBzZXQgdGhlIGNsYXNzIHByb3Blcmx5LCBj b3B5aW5nIHRoZQo+ID4gPiAgIG1vcmUgbW9kZXJuIHN0eWxlIGZyb20gb3RoZXIgcGxhY2VzCj4g PiA+IC0gQ29ycmVjdCB0aGUgcmNfcGNpX2ZpeHVwIGNvbW1lbnQKPiA+ID4gCj4gPiA+IFRoaXMg cGF0Y2gganVzdCByZS1hcHBsaWVzIGNvbW1pdCAxZGM4MzFiZjUzZmQgKCJBUk06IEtpcmt3b29k OiBVcGRhdGUKPiA+ID4gUENJLUUgZml4dXAiKSBmb3IgYWxsIG90aGVyIE1hcnZlbGwgcGxhdGZv cm1zIHdoaWNoIHVzZSBzYW1lIGJ1Z2d5IFBDSWUKPiA+ID4gY29udHJvbGxlci4KPiA+IAo+ID4g SSB3b25kZXIgaWYgdGhhdCBjb2RlIGlzIGV2ZW4gcmVsZXZhbnQgYW55IG1vcmUgc2luY2Ugd2Ug c3RhcnRlZCB1c2luZwo+ID4gQ09ORklHX1BDSV9NVkVCVQo+ID4gCj4gPiA/Cj4gCj4gSXQgaXMg KHN0aWxsKSByZWxldmFudCBmb3IgcGxhdGZvcm1zIHdoaWNoIGRvIG5vdCB1c2UgQ09ORklHX1BD SV9NVkVCVQo+IHlldC4KCkkgdGhpbmsgeW91IHNob3VsZCBleHBsYWluIHRoaXMgaW4gdGhlIGNv bW1pdCBtZXNzYWdlCgo+ID4gUmVhbGx5LCB0aGVzZSBicm9rZW4gY29udHJvbGxlcnMgc2hvdWxk IG5vdCBiZSB1c2VkICJyYXciIGJ1dCBhbHdheXMKPiA+IHZpYSB0aGVpciBzcGVjaWFsIGhvc3Qg YnJpZGdlIGRyaXZlciB0aGF0IGZpeGVzIGFsbCB0aGUgY29uZmlnIHNwYWNlCj4gPiBwcm9ibGVt cy4KPiAKPiBJIGFncmVlLgo+IAo+IExvbmctdGVybSBnb2FsIHNob3VsZCBiZSB0byBjb252ZXJ0 IHRoZXNlIHBsYXRmb3JtcyB0byB1c2UgcGNpLW12ZWJ1LmMKPiBkcml2ZXIuIEFuZCB1bnRpbCBp dCBoYXBwZW5zIHNpbXBsZSBmaXhlcyBsaWtlIGluIGNvbW1pdCAxZGM4MzFiZjUzZmQgaXMKPiBu ZWVkZWQgZm9yIGFsbCBhZmZlY3RlZCBNYXJ2ZWxsIHBsYXRmb3Jtcy4KCklJUkMgYWxsIHRoZXNl IHBsYXRmb3JtcyB3ZXJlIG9ic29sZXRlIGJlZm9yZSBJIHdyb3RlIHRoZSBhYm92ZQpjb21taXQs IHNvIEknbSBub3Qgc3VyZSB3aHkgdGhpcyBoYXMgc3VkZGVubHkgY3JvcHBlZCB1cD8KCklmIHlv dSB3YW50IHRvIHVzZSBhIG5ldyBrZXJuZWwgb24gdGhpcyByZWFsbHkgb2xkIEhXIHRoZW4gdXBk YXRlIHRvCnVzZSB0aGUgcmlnaHQgUENJIGRyaXZlcj8KCj4gU29tZSBkZXRhaWxzIGhvdyB0aGVz ZSBNYXJ2ZWxsIFBDSWUgY29udHJvbGxlcnMgYXJlIGJyb2tlbiBpcyBpbiBlbWFpbDoKPiBodHRw czovL2xvcmUua2VybmVsLm9yZy9saW51eC1wY2kvMjAyMTEwMDMxMjA5NDQuM2xtd3h5bG5obHAy a2ZqN0BwYWxpLwoKWWVzLCBldmVyeXRoaW5nIGFib3V0IHRoaXMgY29udHJvbGxlciBpcyBicm9r ZW4uIEl0IGRvZXMgbm90IGZ1bmN0aW9uCnByb3Blcmx5IHdpdGhvdXQgaXRzIGRyaXZlci4gVGhl IHNvbHV0aW9uIHRvIHRoZXNlIGJ1Z3MgaXMgdG8gdXNlIHRoZQpkcml2ZXIsIHdoaWNoIHdhcyBz cGVjaWZpY2FsbHkgbWFkZSB0byBkZWFsIHdpdGggdGhlbS4KClRoYXQgc2FpZCwgSSBjYW4ndCBy ZWNhbGwgaWYgdGhpcyBkcml2ZXIgbmVlZHMgc29tZSBmaXhpbmcgdG8gd29yawp3aXRoIHByZS1r aXJrd29vZCBzeXN0ZW1zLi4KCkphc29uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==