From: Dan Carpenter <dan.carpenter@oracle.com>
To: LABBE Corentin <clabbe@baylibre.com>
Cc: mchehab@kernel.org, hverkuil@xs4all.nl,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
mjpeg-users@lists.sourceforge.net
Subject: Re: [PATCH v2 04/10] staging: media: zoran: add debugfs
Date: Tue, 2 Nov 2021 20:40:28 +0300 [thread overview]
Message-ID: <20211102174027.GK2794@kadam> (raw)
In-Reply-To: <YWyB8kwsqAvHMuhb@Red>
On Sun, Oct 17, 2021 at 10:05:06PM +0200, LABBE Corentin wrote:
> Le Thu, Oct 14, 2021 at 10:37:52AM +0300, Dan Carpenter a écrit :
> > On Wed, Oct 13, 2021 at 06:58:06PM +0000, Corentin Labbe wrote:
> > > +config VIDEO_ZORAN_DEBUG
> > > + bool "Enable zoran debugfs"
> > > + depends on VIDEO_ZORAN
> > > + depends on DEBUG_FS
> > > + help
> > > + Say y to enable zoran debug file.
> > > + This will create /sys/kernel/debug/CARD_NAME/debug for displaying
> > > + stats and debug information.
> >
> > Why bother with a CONFIG? Just make it always on?
> >
>
> Hello
>
> I love to provides choice to user (and so avoid a dep on DEBUG_FS), even if I think I am the only one remaining user.
Sorry, for the delay, I was on vacation.
No, there is no depends on DEBUG_FS in the method that I am describing.
How that works is when DEBUG_FS is turned on then it's on for everything,
but when it's disabled it's disabled for everything. You do not need
the "depends on DEBUG_FS" and if you make this an option the it feels
like it should be a selects DEBUG_FS instead.
How this normally works is that when you have debugfs disabled, there
are dummy files in the debugfs .h files. I bet the compiler can tell
most of those are empty and removes them. So if you have DEBUG_FS then
it doesn't use that much more memory than when VIDEO_ZORAN_DEBUG is
disabled.
I don't know if I'm being clear at all #jetlag.
It should be easy to check. Just remove the "depends on DEBUG_FS" and
enable VIDEO_ZORAN_DEBUG. Disable DEBUG_FS. It should still build fine
because of the dummy functions. That's build 1. Then disable
VIDEO_ZORAN_DEBUG and that's build 2. See how much memory difference
there is between 1 and 2.
regards,
dan carpenter
next prev parent reply other threads:[~2021-11-02 17:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 18:58 [PATCH v2 00/10] staging: media: zoran: fusion in one module Corentin Labbe
2021-10-13 18:58 ` [PATCH v2 01/10] staging: media: zoran: move module parameter checks to zoran_probe Corentin Labbe
2021-10-13 18:58 ` [PATCH v2 02/10] staging: media: zoran: use module_pci_driver Corentin Labbe
2021-10-13 18:58 ` [PATCH v2 03/10] staging: media: zoran: rename debug module parameter Corentin Labbe
2021-10-13 18:58 ` [PATCH v2 04/10] staging: media: zoran: add debugfs Corentin Labbe
2021-10-14 7:37 ` Dan Carpenter
2021-10-17 20:05 ` LABBE Corentin
2021-11-02 17:40 ` Dan Carpenter [this message]
2021-11-02 21:29 ` LABBE Corentin
2021-10-14 11:18 ` kernel test robot
2021-10-14 11:18 ` kernel test robot
2021-10-13 18:58 ` [PATCH v2 05/10] staging: media: zoran: videocode: remove procfs Corentin Labbe
2021-10-13 18:58 ` [PATCH v2 06/10] staging: media: zoran: fusion all modules Corentin Labbe
2021-10-14 7:56 ` Dan Carpenter
2021-10-14 8:01 ` Dan Carpenter
2021-10-17 19:57 ` LABBE Corentin
2021-10-13 18:58 ` [PATCH v2 07/10] staging: media: zoran: remove vidmem Corentin Labbe
2021-10-13 18:58 ` [PATCH v2 08/10] staging: media: zoran: move videodev alloc Corentin Labbe
2021-10-13 18:58 ` [PATCH v2 09/10] staging: media: zoran: move config select on primary kconfig Corentin Labbe
2021-10-13 18:58 ` [PATCH v2 10/10] staging: media: zoran: introduce zoran_i2c_init Corentin Labbe
2021-10-18 9:55 ` [PATCH v2 00/10] staging: media: zoran: fusion in one module Hans Verkuil
2021-10-25 14:06 ` LABBE Corentin
2021-10-25 12:45 ` Hans Verkuil
2021-10-25 14:21 ` LABBE Corentin
2021-10-25 15:13 ` Hans Verkuil
2021-10-25 18:25 ` LABBE Corentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211102174027.GK2794@kadam \
--to=dan.carpenter@oracle.com \
--cc=clabbe@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mjpeg-users@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.