From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corey Minyard Date: Tue, 2 Nov 2021 20:52:27 -0500 Subject: [PATCH -next v2 5/6] dt-bindings: ipmi: aspeed,kcs-bmc: add 'clocks' as a required property In-Reply-To: <1635902437.654631.3880388.nullmailer@robh.at.kernel.org> References: <20211102203717.96794-1-jae.hyun.yoo@intel.com> <20211102203717.96794-6-jae.hyun.yoo@intel.com> <1635902437.654631.3880388.nullmailer@robh.at.kernel.org> Message-ID: <20211103015227.GO4667@minyard.net> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Nov 02, 2021 at 08:20:37PM -0500, Rob Herring wrote: > On Tue, 02 Nov 2021 13:37:16 -0700, jae.hyun.yoo at intel.com wrote: > > From: Jae Hyun Yoo > > > > Add 'clocks' as a required property. > > > > Signed-off-by: Jae Hyun Yoo > > --- > > v1 -> v2: > > Changes sinve v1: > > - Added 'clocks' property into kcs-bmc bindings using > > 'aspeed,ast2400-kcs-bmc.yaml' because it's not merged into > > 'aspeed-lpc.yaml' yet. The bindings merging could be done using a > > separate patch later. > > > > .../devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1549943 > >From the code, I think this change will break all these platforms, as the initialization of kcs will fail without the clock property. I'm going to pull this out until it gets sorted out. Also, could you rebase on the latest kernel when submitting next time? There was a minor thing I had to fix up. -corey > > kcs at 114: 'clocks' is a required property > arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml > arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dt.yaml > arch/arm/boot/dts/aspeed-bmc-inspur-nf5280m6.dt.yaml > > kcs at 24: 'clocks' is a required property > arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml > > kcs at 28: 'clocks' is a required property > arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml > arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dt.yaml > arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dt.yaml > > kcs at 2c: 'clocks' is a required property > arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml > arch/arm/boot/dts/aspeed-bmc-asrock-e3c246d4i.dt.yaml > arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dt.yaml > arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dt.yaml > arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dt.yaml > arch/arm/boot/dts/aspeed-bmc-inspur-nf5280m6.dt.yaml > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3323C433F5 for ; Wed, 3 Nov 2021 01:53:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBD3C60EDF for ; Wed, 3 Nov 2021 01:53:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BBD3C60EDF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gBOkTOl7QN3hm0F00f9fa5jAnCCO1Hnlm0CA10pT7eQ=; b=KNIsWDf8RZq1ad yJfK432vpYzpyJ1FpbbHC9BfUf+0uYPjA3Fv7pAq9AS9hObiuaCn7oQ6+c2E29tYCS5T9C7fWFdlH 4kPBlETTidVR1MU5qIO9OD5MZBJcSYRx/4werxS9zc/EpK0QiJFMHsG30MtBGiDEeWtd+IJ8sQg7K 0fsHCr3b7bWJQBifZH9YPMV5k6alz5hm5WtbvdJV0enrga9lkUF4fDW6yZeOZNHM8J1c3MDzrV14s CmrBDZeoWCf1JbYjK1StwaJAN42Xr4Xy7YKxJXjeLwaa/4DbxISTapuuQZauGfJfz2/V6p59A/0Mv vzKVC4YTMzlXUCLyneVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mi5S7-003ofe-JJ; Wed, 03 Nov 2021 01:52:35 +0000 Received: from mail-qv1-xf2c.google.com ([2607:f8b0:4864:20::f2c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mi5S3-003oed-Lb for linux-arm-kernel@lists.infradead.org; Wed, 03 Nov 2021 01:52:33 +0000 Received: by mail-qv1-xf2c.google.com with SMTP id b17so1111153qvl.9 for ; Tue, 02 Nov 2021 18:52:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:in-reply-to; bh=W2HU4w7GnhKTte65isyHpt7yAXFNwuaPGGZjXYZzIto=; b=n0H27rJwgjdtjio7lxmzwV+ku2ClAqJg7OCr/K1KcAj+6e/BCrGJwbWJu43YR3BQI2 3ZPoZhGZ7jA/GKubBzn5kbMELmhasgtMfCf/7JXMgtEJdAtaxoA8zt6sspI1czgw3Vzy 3kgcg6ERstIMCbGylbyonfNK+UUj5e5yx/dgWyf2InCX1hJJ+RXqCJimBw2hiIDUcxDb GDf/MUV7rQThVUC6nfMGGUJX0Q+VZk7gdMeW3ELI8aqpJsN/y9ashfXGqWm84zuqmCLe IqvyrIO9boJcz+t603XxmJWkl38M9civl35afuasHfx7b3IDkqWv/AyysASTfbAwMxuU +1iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition:in-reply-to; bh=W2HU4w7GnhKTte65isyHpt7yAXFNwuaPGGZjXYZzIto=; b=XHQ9sVYVkd+SFhyamB36ruYi3v+FqTB0BESlcmPIbMiWZguTY2r27IW7ZI7v0PnKjI iCyduFbJSBE0SeAtdekbIK8em0GPMgExyZgSq4+Z28LR5nK65W2nNTDm2sxvAUMX7KLX b3v9NqMeT9lkyS84J41uPtZouqB4Jo7sE2HsuhtRGEzNFx8vRW9S6IbkiLKvOXDRM9Nx HwzyfHkNSfhVTYb/WgY/5XbM5CTnJcEk0ideL+KPSxQzMURo26dOmSYO9kFbv0n2cJtU W1Mp4OEDZS5BlyIh8/k6RMcvAiXEZIlUdeQormaroy1rMJwvWlCTZ9/kk9QuLuKjHvE1 Fn4g== X-Gm-Message-State: AOAM530hEMIMWkRODzlboX7JVsMytlYfBOwMdyhhQtg/DI2/W2+0NLqy mZncnaHBrVbiq3RwEzON9g== X-Google-Smtp-Source: ABdhPJxAZb3DCF8bmbLHwMF6GRKQh7wEROD8SIINO6DSBkTwPrzFSqU3DONEfQuaeO92GHCycangsA== X-Received: by 2002:ac8:5745:: with SMTP id 5mr18639476qtx.37.1635904350437; Tue, 02 Nov 2021 18:52:30 -0700 (PDT) Received: from serve.minyard.net ([47.184.156.158]) by smtp.gmail.com with ESMTPSA id o10sm596759qtx.43.2021.11.02.18.52.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 18:52:30 -0700 (PDT) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:b4e0:932d:f90c:fafb]) by serve.minyard.net (Postfix) with ESMTPSA id 009481800B9; Wed, 3 Nov 2021 01:52:28 +0000 (UTC) Date: Tue, 2 Nov 2021 20:52:27 -0500 From: Corey Minyard To: Rob Herring Cc: jae.hyun.yoo@intel.com, Joel Stanley , Andrew Jeffery , openipmi-developer@lists.sourceforge.net, linux-aspeed@lists.ozlabs.org, Haiyue Wang , Jae Hyun Yoo , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Cedric Le Goater , ChiaWei Wang , Rob Herring Subject: Re: [PATCH -next v2 5/6] dt-bindings: ipmi: aspeed,kcs-bmc: add 'clocks' as a required property Message-ID: <20211103015227.GO4667@minyard.net> References: <20211102203717.96794-1-jae.hyun.yoo@intel.com> <20211102203717.96794-6-jae.hyun.yoo@intel.com> <1635902437.654631.3880388.nullmailer@robh.at.kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1635902437.654631.3880388.nullmailer@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211102_185231_745852_5C178D3E X-CRM114-Status: GOOD ( 23.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 02, 2021 at 08:20:37PM -0500, Rob Herring wrote: > On Tue, 02 Nov 2021 13:37:16 -0700, jae.hyun.yoo@intel.com wrote: > > From: Jae Hyun Yoo > > > > Add 'clocks' as a required property. > > > > Signed-off-by: Jae Hyun Yoo > > --- > > v1 -> v2: > > Changes sinve v1: > > - Added 'clocks' property into kcs-bmc bindings using > > 'aspeed,ast2400-kcs-bmc.yaml' because it's not merged into > > 'aspeed-lpc.yaml' yet. The bindings merging could be done using a > > separate patch later. > > > > .../devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1549943 > >From the code, I think this change will break all these platforms, as the initialization of kcs will fail without the clock property. I'm going to pull this out until it gets sorted out. Also, could you rebase on the latest kernel when submitting next time? There was a minor thing I had to fix up. -corey > > kcs@114: 'clocks' is a required property > arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml > arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dt.yaml > arch/arm/boot/dts/aspeed-bmc-inspur-nf5280m6.dt.yaml > > kcs@24: 'clocks' is a required property > arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml > > kcs@28: 'clocks' is a required property > arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml > arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dt.yaml > arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dt.yaml > > kcs@2c: 'clocks' is a required property > arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml > arch/arm/boot/dts/aspeed-bmc-asrock-e3c246d4i.dt.yaml > arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dt.yaml > arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dt.yaml > arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dt.yaml > arch/arm/boot/dts/aspeed-bmc-inspur-nf5280m6.dt.yaml > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A19F8C433F5 for ; Wed, 3 Nov 2021 01:52:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86D4861051 for ; Wed, 3 Nov 2021 01:52:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230400AbhKCBzH (ORCPT ); Tue, 2 Nov 2021 21:55:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230185AbhKCBzH (ORCPT ); Tue, 2 Nov 2021 21:55:07 -0400 Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AA5BC061714 for ; Tue, 2 Nov 2021 18:52:31 -0700 (PDT) Received: by mail-qv1-xf2c.google.com with SMTP id s9so1095257qvk.12 for ; Tue, 02 Nov 2021 18:52:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:in-reply-to; bh=W2HU4w7GnhKTte65isyHpt7yAXFNwuaPGGZjXYZzIto=; b=n0H27rJwgjdtjio7lxmzwV+ku2ClAqJg7OCr/K1KcAj+6e/BCrGJwbWJu43YR3BQI2 3ZPoZhGZ7jA/GKubBzn5kbMELmhasgtMfCf/7JXMgtEJdAtaxoA8zt6sspI1czgw3Vzy 3kgcg6ERstIMCbGylbyonfNK+UUj5e5yx/dgWyf2InCX1hJJ+RXqCJimBw2hiIDUcxDb GDf/MUV7rQThVUC6nfMGGUJX0Q+VZk7gdMeW3ELI8aqpJsN/y9ashfXGqWm84zuqmCLe IqvyrIO9boJcz+t603XxmJWkl38M9civl35afuasHfx7b3IDkqWv/AyysASTfbAwMxuU +1iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition:in-reply-to; bh=W2HU4w7GnhKTte65isyHpt7yAXFNwuaPGGZjXYZzIto=; b=iT7/tLZmiu+Thvm1bWLIwXrcR7WlE3KH0iAY2Evn2c+g0zDUnq4B9TW8AqtIkghpVn nRWSLMfmf1trhcKcZ2Ddu9qJOblJ7/dvcZtAW1Z2T+EEUpTRLPKUjdAfILme33nh8OTd hPDi9z1jgQVZ4bb0SZzheArb/1O5171JQ7Rcv08TvyJEPNglUcaEpUqsd3YnCU6eNGKG uqvszZp5Y+toaXS1EBnvY/5+7Y/Bui40GTSIOXJ5IGIg0/CxqrPpJp9u2qqkXyXP8gFz M+wpbdy5canMBNq/xJJXvEER2I82pxYEwDgnaqlDqFdgNJMNWZ6jpoNXy6ZsHkFkWfWl q5vA== X-Gm-Message-State: AOAM532Rp1ksL8Q0aEfvJpDNIgHxf9TtB0n5eWpyXF6YxET0wVuPARdP jJbq3iTkSrxSV4cz2OcEHw== X-Google-Smtp-Source: ABdhPJxAZb3DCF8bmbLHwMF6GRKQh7wEROD8SIINO6DSBkTwPrzFSqU3DONEfQuaeO92GHCycangsA== X-Received: by 2002:ac8:5745:: with SMTP id 5mr18639476qtx.37.1635904350437; Tue, 02 Nov 2021 18:52:30 -0700 (PDT) Received: from serve.minyard.net ([47.184.156.158]) by smtp.gmail.com with ESMTPSA id o10sm596759qtx.43.2021.11.02.18.52.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 18:52:30 -0700 (PDT) Sender: Corey Minyard Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:b4e0:932d:f90c:fafb]) by serve.minyard.net (Postfix) with ESMTPSA id 009481800B9; Wed, 3 Nov 2021 01:52:28 +0000 (UTC) Date: Tue, 2 Nov 2021 20:52:27 -0500 From: Corey Minyard To: Rob Herring Cc: jae.hyun.yoo@intel.com, Joel Stanley , Andrew Jeffery , openipmi-developer@lists.sourceforge.net, linux-aspeed@lists.ozlabs.org, Haiyue Wang , Jae Hyun Yoo , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Cedric Le Goater , ChiaWei Wang , Rob Herring Subject: Re: [PATCH -next v2 5/6] dt-bindings: ipmi: aspeed,kcs-bmc: add 'clocks' as a required property Message-ID: <20211103015227.GO4667@minyard.net> Reply-To: minyard@acm.org References: <20211102203717.96794-1-jae.hyun.yoo@intel.com> <20211102203717.96794-6-jae.hyun.yoo@intel.com> <1635902437.654631.3880388.nullmailer@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1635902437.654631.3880388.nullmailer@robh.at.kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Nov 02, 2021 at 08:20:37PM -0500, Rob Herring wrote: > On Tue, 02 Nov 2021 13:37:16 -0700, jae.hyun.yoo@intel.com wrote: > > From: Jae Hyun Yoo > > > > Add 'clocks' as a required property. > > > > Signed-off-by: Jae Hyun Yoo > > --- > > v1 -> v2: > > Changes sinve v1: > > - Added 'clocks' property into kcs-bmc bindings using > > 'aspeed,ast2400-kcs-bmc.yaml' because it's not merged into > > 'aspeed-lpc.yaml' yet. The bindings merging could be done using a > > separate patch later. > > > > .../devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1549943 > >From the code, I think this change will break all these platforms, as the initialization of kcs will fail without the clock property. I'm going to pull this out until it gets sorted out. Also, could you rebase on the latest kernel when submitting next time? There was a minor thing I had to fix up. -corey > > kcs@114: 'clocks' is a required property > arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml > arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dt.yaml > arch/arm/boot/dts/aspeed-bmc-inspur-nf5280m6.dt.yaml > > kcs@24: 'clocks' is a required property > arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml > > kcs@28: 'clocks' is a required property > arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml > arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dt.yaml > arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dt.yaml > > kcs@2c: 'clocks' is a required property > arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml > arch/arm/boot/dts/aspeed-bmc-asrock-e3c246d4i.dt.yaml > arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dt.yaml > arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dt.yaml > arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dt.yaml > arch/arm/boot/dts/aspeed-bmc-inspur-nf5280m6.dt.yaml >