From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kushal Kothari <kushalkothari285@gmail.com>
Cc: gregkh@linuxfoundation.org, kush19992810@gmail.com,
outreachy-kernel@googlegroups.com, fabioaiuto83@gmail.com,
ross.schm.dev@gmail.com, fmdefrancesco@gmail.com,
marcocesati@gmail.com, straube.linux@gmail.com,
philippesdixon@gmail.com, manuelpalenzuelamerino@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
mike.rapoport@gmail.com, kushalkotharitest@googlegroups.com
Subject: Re: [PATCH v4 3/4] staging: rtl8723bs: core: Remove unnecessary space after a cast
Date: Wed, 3 Nov 2021 15:04:48 +0300 [thread overview]
Message-ID: <20211103120448.GS2794@kadam> (raw)
In-Reply-To: <baa1703e0c202dfb90e215b63b535161bd3ccccb.1634967010.git.kushalkothari285@gmail.com>
This v4 patchset look good. Thanks!
On Sat, Oct 23, 2021 at 01:05:49PM +0530, Kushal Kothari wrote:
> @@ -2027,7 +2027,7 @@ void rtw_setstaKey_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pc
> {
>
> struct sta_priv *pstapriv = &padapter->stapriv;
> - struct set_stakey_rsp *psetstakey_rsp = (struct set_stakey_rsp *) (pcmd->rsp);
> + struct set_stakey_rsp *psetstakey_rsp = (struct set_stakey_rsp *)(pcmd->rsp);
^^^^^^^^^^^
An unrelated note, if you wanted to send more patches. These extra
parentheses could be removed.
> struct sta_info *psta = rtw_get_stainfo(pstapriv, psetstakey_rsp->addr);
>
> if (!psta)
> @@ -2042,7 +2042,7 @@ void rtw_setassocsta_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *
> struct sta_priv *pstapriv = &padapter->stapriv;
> struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
> struct set_assocsta_parm *passocsta_parm = (struct set_assocsta_parm *)(pcmd->parmbuf);
^^^^^^^^^^^^^^^
Same here.
> - struct set_assocsta_rsp *passocsta_rsp = (struct set_assocsta_rsp *) (pcmd->rsp);
> + struct set_assocsta_rsp *passocsta_rsp = (struct set_assocsta_rsp *)(pcmd->rsp);
^^^^^^^^^^^^
Here.
> struct sta_info *psta = rtw_get_stainfo(pstapriv, passocsta_parm->addr);
>
> if (!psta)
regards,
dan carpenter
next prev parent reply other threads:[~2021-11-03 12:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-23 7:35 [PATCH v4 0/4] staging: rtl8723bs: core: Cleanup patchset for style issues in rtw_cmd.c Kushal Kothari
2021-10-23 7:35 ` [PATCH v4 1/4] staging: rtl8723bs: core: Remove true and false comparison Kushal Kothari
2021-11-03 12:21 ` Dan Carpenter
2021-10-23 7:35 ` [PATCH v4 2/4] staging: rtl8723bs: core: Remove unnecessary parentheses Kushal Kothari
2021-10-23 7:35 ` [PATCH v4 3/4] staging: rtl8723bs: core: Remove unnecessary space after a cast Kushal Kothari
2021-11-03 12:04 ` Dan Carpenter [this message]
2021-10-23 7:35 ` [PATCH v4 4/4] staging: rtl8723bs: core: Remove unnecessary blank lines Kushal Kothari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211103120448.GS2794@kadam \
--to=dan.carpenter@oracle.com \
--cc=fabioaiuto83@gmail.com \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kush19992810@gmail.com \
--cc=kushalkothari285@gmail.com \
--cc=kushalkotharitest@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manuelpalenzuelamerino@gmail.com \
--cc=marcocesati@gmail.com \
--cc=mike.rapoport@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=philippesdixon@gmail.com \
--cc=ross.schm.dev@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.