From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9166BC433EF for ; Wed, 3 Nov 2021 17:49:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7AD94608FB for ; Wed, 3 Nov 2021 17:49:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230281AbhKCRvk (ORCPT ); Wed, 3 Nov 2021 13:51:40 -0400 Received: from verein.lst.de ([213.95.11.211]:60613 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229888AbhKCRvh (ORCPT ); Wed, 3 Nov 2021 13:51:37 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id BFD1168AA6; Wed, 3 Nov 2021 18:48:56 +0100 (CET) Date: Wed, 3 Nov 2021 18:48:56 +0100 From: Christoph Hellwig To: Luis Chamberlain Cc: axboe@kernel.dk, hch@lst.de, penguin-kernel@i-love.sakura.ne.jp, dan.j.williams@intel.com, vishal.l.verma@intel.com, dave.jiang@intel.com, ira.weiny@intel.com, richard@nod.at, miquel.raynal@bootlin.com, vigneshr@ti.com, efremov@linux.com, song@kernel.org, martin.petersen@oracle.com, hare@suse.de, jack@suse.cz, ming.lei@redhat.com, tj@kernel.org, linux-mtd@lists.infradead.org, linux-scsi@vger.kernel.org, linux-raid@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 12/13] block: fix __register_blkdev() probe add_disk() failures Message-ID: <20211103174856.GA7034@lst.de> References: <20211103174521.1426407-1-mcgrof@kernel.org> <20211103174521.1426407-13-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211103174521.1426407-13-mcgrof@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Sorry for being annoying, but I think this really should be three patches: the documentation fix and one each for the two floppy drivers. And the two floppy probe routines would probably benefit from using goto unwinding as well. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B761FC433FE for ; Wed, 3 Nov 2021 17:56:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F28060F90 for ; Wed, 3 Nov 2021 17:56:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5F28060F90 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6Dm3kkFHTYlCcHu92n3jiDsn2m8xAAlh6VvcGoo2rDM=; b=fl3RkYNEuMmXsZ wlp1QCXLAcuVVYibDCzHzo3fe0VXfVfYX26jaENWSnA+DTef3sFD/9VxS6hQvBVerIyVlPGLI0Ug8 vjWw01SLBmRa1Hh+LsP8n4fk3YkuffHji/4u6+Scap//e4oY7EHNFkEEcVtWN0C3XPQvkWMbYjzUq jcca9C1C2Pftd0SzPdjEhDo8/nrxUd3HzktnnTp7nOSAGInvPPVL3CBLC++jxroCgWWye7XhoMW6+ F2rFDAUeExleEIQITkwUsVcg5eBsu2VyJdKY1YPokuNPCNLViBGBcYaWPK9aBr6u7c5SsAJykiWWr HWzJ6j5Q5RuVJkfH7F4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1miKUR-0063BX-M2; Wed, 03 Nov 2021 17:56:00 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1miKNh-0060nd-Cn for linux-mtd@lists.infradead.org; Wed, 03 Nov 2021 17:49:02 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id BFD1168AA6; Wed, 3 Nov 2021 18:48:56 +0100 (CET) Date: Wed, 3 Nov 2021 18:48:56 +0100 From: Christoph Hellwig To: Luis Chamberlain Cc: axboe@kernel.dk, hch@lst.de, penguin-kernel@i-love.sakura.ne.jp, dan.j.williams@intel.com, vishal.l.verma@intel.com, dave.jiang@intel.com, ira.weiny@intel.com, richard@nod.at, miquel.raynal@bootlin.com, vigneshr@ti.com, efremov@linux.com, song@kernel.org, martin.petersen@oracle.com, hare@suse.de, jack@suse.cz, ming.lei@redhat.com, tj@kernel.org, linux-mtd@lists.infradead.org, linux-scsi@vger.kernel.org, linux-raid@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 12/13] block: fix __register_blkdev() probe add_disk() failures Message-ID: <20211103174856.GA7034@lst.de> References: <20211103174521.1426407-1-mcgrof@kernel.org> <20211103174521.1426407-13-mcgrof@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211103174521.1426407-13-mcgrof@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211103_104901_639697_10049153 X-CRM114-Status: UNSURE ( 8.79 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Sorry for being annoying, but I think this really should be three patches: the documentation fix and one each for the two floppy drivers. And the two floppy probe routines would probably benefit from using goto unwinding as well. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/