From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Adam Duskett <aduskett@gmail.com>
Cc: "Mirza Krak" <mirza.krak@northern.tech>,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Angelo Compagnucci" <angelo.compagnucci@gmail.com>,
"Yann E. MORIN" <yann.morin.1998@free.fr>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/mender-grubenv: fix grub module checks
Date: Wed, 3 Nov 2021 22:19:50 +0100 [thread overview]
Message-ID: <20211103221950.373e93c7@windsurf> (raw)
In-Reply-To: <20211103195520.147558-4-aduskett@gmail.com>
Hello Adam,
On Wed, 3 Nov 2021 12:55:19 -0700
Adam Duskett <aduskett@gmail.com> wrote:
> +ifeq ($(BR2_TARGET_GRUB2_X86_64_EFI),y)
Are you sure this is correct? Indeed I believe
BR2_TARGET_GRUB2_BUILTIN_MODULES_EFI is also used for the
BR2_TARGET_GRUB2_I386_EFI, BR2_TARGET_GRUB2_ARM_EFI and
BR2_TARGET_GRUB2_ARM64_EFI cases, isn't it ?
> +MENDER_GRUBENV_MODULES_MISSING = \
> + $(filter-out $(call qstrip,$(BR2_TARGET_GRUB2_BUILTIN_MODULES_EFI)),\
> + $(MENDER_GRUBENV_MANDATORY_MODULES))
> +else
> MENDER_GRUBENV_MODULES_MISSING = \
> $(filter-out $(call qstrip,$(BR2_TARGET_GRUB2_BUILTIN_MODULES)),\
Also BR2_TARGET_GRUB2_BUILTIN_MODULES no longer exists, it's
BR2_TARGET_GRUB2_BUILTIN_MODULES_PC.
I'm really sorry we overlooked this when doing the changes on grub2 :-/
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-11-03 21:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 19:55 [Buildroot] [PATCH] package/mender: bump to version 3.1.0 Adam Duskett
2021-11-03 19:55 ` [Buildroot] [PATCH] package/mender: install io.mender.UpdateManager.conf dbus file Adam Duskett
2021-11-03 21:17 ` Thomas Petazzoni
2021-11-03 19:55 ` [Buildroot] [PATCH] package/mender-artifact: bump to version 3.6.1 Adam Duskett
2021-11-03 21:17 ` Thomas Petazzoni
2021-11-03 19:55 ` [Buildroot] [PATCH] package/mender-grubenv: fix grub module checks Adam Duskett
2021-11-03 21:19 ` Thomas Petazzoni [this message]
2021-11-03 19:55 ` [Buildroot] [PATCH] package/mender_grubenv: bump to version 1a7db967495bbe8be53b7a69dcb42822f39d9a74 Adam Duskett
2021-11-03 21:20 ` Thomas Petazzoni
2021-11-03 21:17 ` [Buildroot] [PATCH] package/mender: bump to version 3.1.0 Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211103221950.373e93c7@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=aduskett@gmail.com \
--cc=angelo.compagnucci@gmail.com \
--cc=buildroot@buildroot.org \
--cc=kory.maincent@bootlin.com \
--cc=mirza.krak@northern.tech \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.