All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Romain Naour <romain.naour@gmail.com>
Cc: Antoine Tenart <atenart@kernel.org>,
	Adam Duskett <aduskett@gmail.com>,
	"buildroot@buildroot.org" <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] package/refpolicy: enable refpolicy's xdg module when systemd is enabled
Date: Wed, 3 Nov 2021 23:04:26 +0100	[thread overview]
Message-ID: <20211103230426.3b8726c0@windsurf> (raw)
In-Reply-To: <b08f0641-06ec-c4ce-6960-2df5898cf6c2@gmail.com>

Hello,

On Wed, 3 Nov 2021 22:06:43 +0100
Romain Naour <romain.naour@gmail.com> wrote:

> > I just tested by adding xdg to SYSTEMD_SELINUX_MODULES which does
> > indeed fix the issue.  
> 
> ok but it's not clear to me if we need to add xdg to SYSTEMD_SELINUX_MODULES or
> REFPOLICY_MODULES.

Clearly to SYSTEMD_SELINUX_MODULES. The idea of REFPOLICY_MODULES is to list:

 (1) Mandatory refpolicy modules

 (2) refpolicy modules needed by other Buildroot packages, i.e.
     $(PACKAGES_SELINUX_MODULES)

 (3) refpolicy modules explicitly enabled by the user through the
     BR2_REFPOLICY_EXTRA_MODULES option

 (4) additional SELinux policy modules provided directly within a
     package directory, in package/<foo>/selinux/

In our case, it's the systemd refpolicy module that needs xdg, so
systemd.mk should be patched:

-SYSTEMD_SELINUX_MODULES = systemd udev
+SYSTEMD_SELINUX_MODULES = systemd udev xdg

Could you send an updated patch ?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2021-11-03 22:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-31 22:42 [Buildroot] [PATCH] package/refpolicy: enable refpolicy's xdg module when systemd is enabled Romain Naour
2021-11-01  6:10 ` ratbert90
2021-11-01  9:23   ` Romain Naour
2021-11-02 17:26     ` Adam Duskett
2021-11-03 21:06       ` Romain Naour
2021-11-03 22:04         ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211103230426.3b8726c0@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=aduskett@gmail.com \
    --cc=atenart@kernel.org \
    --cc=buildroot@buildroot.org \
    --cc=romain.naour@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.