All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>,
	Asaf Kahlon <asafka7@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/collectd: add missing C++ comment for mysql
Date: Wed, 3 Nov 2021 23:38:12 +0100	[thread overview]
Message-ID: <20211103233812.5fbbb1f7@windsurf> (raw)
In-Reply-To: <20211030215307.2155221-1-fontaine.fabrice@gmail.com>

Hello Fabrice,

On Sat, 30 Oct 2021 23:53:07 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Add missing C++ comment for mysql and while at it drops depends on
> MMU and threads which are always true
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/collectd/Config.in | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/collectd/Config.in b/package/collectd/Config.in
> index d44d4e4913..6873e6d5ab 100644
> --- a/package/collectd/Config.in
> +++ b/package/collectd/Config.in
> @@ -377,13 +377,14 @@ config BR2_PACKAGE_COLLECTD_MODBUS
>  config BR2_PACKAGE_COLLECTD_MYSQL
>  	bool "mysql"
>  	depends on BR2_INSTALL_LIBSTDCPP # mysql
> -	depends on BR2_USE_MMU # mysql
> -	depends on BR2_TOOLCHAIN_HAS_THREADS # mysql

Regarding the removal of these, there is a school of thought that says
it's better to duplicate them, so that when the dependencies of mysql
change, it's a bit more obvious what to do.

>  	select BR2_PACKAGE_MYSQL
>  	help
>  	  Connects to a MySQL database and issues a "show status"
>  	  command.
>  
> +comment "mysql needs a toolchain w/ C++"
> +	depends on !BR2_INSTALL_LIBSTDCPP

That being said, what does this means for this comment? Should we talk
only about the C++ dependency, or also about the threads dependency ?

Arnout, Yann, Peter?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2021-11-03 22:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-30 21:53 [Buildroot] [PATCH 1/1] package/collectd: add missing C++ comment for mysql Fabrice Fontaine
2021-11-03 22:38 ` Thomas Petazzoni [this message]
2021-12-28 21:09 ` Thomas Petazzoni
2022-01-25 18:10   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211103233812.5fbbb1f7@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=asafka7@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.