* [Buildroot] [PATCH v2, 1/1] package/python-cryptography: add host-python-six dependency
@ 2021-10-26 16:32 Fabrice Fontaine
2021-11-04 5:05 ` James Hilliard
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2021-10-26 16:32 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine, Thomas Petazzoni, Asaf Kahlon
Fix the wrong assumption that six is not a dependency with python3 made
in commit 95a63a34ac9204c4fe069154783bd97ed48c3ae2 to avoid the
following build failure with ca-certificates:
Traceback (most recent call last):
File "/home/buildroot/autobuild/instance-2/output-1/build/ca-certificates-20211016/mozilla/certdata2pem.py", line 31, in <module>
from cryptography import x509
File "/home/buildroot/autobuild/instance-2/output-1/host/lib/python3.9/site-packages/cryptography/x509/__init__.py", line 7, in <module>
from cryptography.x509 import certificate_transparency
File "/home/buildroot/autobuild/instance-2/output-1/host/lib/python3.9/site-packages/cryptography/x509/certificate_transparency.py", line 10, in <module>
import six
ModuleNotFoundError: No module named 'six'
Fixes:
- http://autobuild.buildroot.org/results/2b6872eec31362bf3edf88c69b67d681b2f016aa
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2 (after review of Arnout Vandecappelle):
- Use host-python-six instead of host-python3-six
package/python-cryptography/python-cryptography.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/python-cryptography/python-cryptography.mk b/package/python-cryptography/python-cryptography.mk
index e21b9db042..acc21c1227 100644
--- a/package/python-cryptography/python-cryptography.mk
+++ b/package/python-cryptography/python-cryptography.mk
@@ -14,7 +14,7 @@ PYTHON_CRYPTOGRAPHY_CPE_ID_VENDOR = cryptography_project
PYTHON_CRYPTOGRAPHY_CPE_ID_PRODUCT = cryptography
PYTHON_CRYPTOGRAPHY_DEPENDENCIES = host-python-cffi openssl
HOST_PYTHON_CRYPTOGRAPHY_NEEDS_HOST_PYTHON = python3
-HOST_PYTHON_CRYPTOGRAPHY_DEPENDENCIES = host-python3-cffi host-openssl
+HOST_PYTHON_CRYPTOGRAPHY_DEPENDENCIES = host-python3-cffi host-python-six host-openssl
$(eval $(python-package))
$(eval $(host-python-package))
--
2.33.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Buildroot] [PATCH v2, 1/1] package/python-cryptography: add host-python-six dependency
2021-10-26 16:32 [Buildroot] [PATCH v2, 1/1] package/python-cryptography: add host-python-six dependency Fabrice Fontaine
@ 2021-11-04 5:05 ` James Hilliard
2021-11-04 18:00 ` Peter Seiderer
2021-11-04 20:17 ` Thomas Petazzoni
2 siblings, 0 replies; 5+ messages in thread
From: James Hilliard @ 2021-11-04 5:05 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Asaf Kahlon, Thomas Petazzoni, buildroot
On Tue, Oct 26, 2021 at 10:34 AM Fabrice Fontaine
<fontaine.fabrice@gmail.com> wrote:
>
> Fix the wrong assumption that six is not a dependency with python3 made
> in commit 95a63a34ac9204c4fe069154783bd97ed48c3ae2 to avoid the
> following build failure with ca-certificates:
>
> Traceback (most recent call last):
> File "/home/buildroot/autobuild/instance-2/output-1/build/ca-certificates-20211016/mozilla/certdata2pem.py", line 31, in <module>
> from cryptography import x509
> File "/home/buildroot/autobuild/instance-2/output-1/host/lib/python3.9/site-packages/cryptography/x509/__init__.py", line 7, in <module>
> from cryptography.x509 import certificate_transparency
> File "/home/buildroot/autobuild/instance-2/output-1/host/lib/python3.9/site-packages/cryptography/x509/certificate_transparency.py", line 10, in <module>
> import six
> ModuleNotFoundError: No module named 'six'
>
> Fixes:
> - http://autobuild.buildroot.org/results/2b6872eec31362bf3edf88c69b67d681b2f016aa
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Reviewed-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> Changes v1 -> v2 (after review of Arnout Vandecappelle):
> - Use host-python-six instead of host-python3-six
>
> package/python-cryptography/python-cryptography.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/python-cryptography/python-cryptography.mk b/package/python-cryptography/python-cryptography.mk
> index e21b9db042..acc21c1227 100644
> --- a/package/python-cryptography/python-cryptography.mk
> +++ b/package/python-cryptography/python-cryptography.mk
> @@ -14,7 +14,7 @@ PYTHON_CRYPTOGRAPHY_CPE_ID_VENDOR = cryptography_project
> PYTHON_CRYPTOGRAPHY_CPE_ID_PRODUCT = cryptography
> PYTHON_CRYPTOGRAPHY_DEPENDENCIES = host-python-cffi openssl
> HOST_PYTHON_CRYPTOGRAPHY_NEEDS_HOST_PYTHON = python3
> -HOST_PYTHON_CRYPTOGRAPHY_DEPENDENCIES = host-python3-cffi host-openssl
> +HOST_PYTHON_CRYPTOGRAPHY_DEPENDENCIES = host-python3-cffi host-python-six host-openssl
>
> $(eval $(python-package))
> $(eval $(host-python-package))
> --
> 2.33.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v2, 1/1] package/python-cryptography: add host-python-six dependency
2021-10-26 16:32 [Buildroot] [PATCH v2, 1/1] package/python-cryptography: add host-python-six dependency Fabrice Fontaine
2021-11-04 5:05 ` James Hilliard
@ 2021-11-04 18:00 ` Peter Seiderer
2021-11-04 20:17 ` Thomas Petazzoni
2 siblings, 0 replies; 5+ messages in thread
From: Peter Seiderer @ 2021-11-04 18:00 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Asaf Kahlon, Thomas Petazzoni, buildroot
Hello Fabrice,
On Tue, 26 Oct 2021 18:32:22 +0200, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Fix the wrong assumption that six is not a dependency with python3 made
> in commit 95a63a34ac9204c4fe069154783bd97ed48c3ae2 to avoid the
> following build failure with ca-certificates:
>
> Traceback (most recent call last):
> File "/home/buildroot/autobuild/instance-2/output-1/build/ca-certificates-20211016/mozilla/certdata2pem.py", line 31, in <module>
> from cryptography import x509
> File "/home/buildroot/autobuild/instance-2/output-1/host/lib/python3.9/site-packages/cryptography/x509/__init__.py", line 7, in <module>
> from cryptography.x509 import certificate_transparency
> File "/home/buildroot/autobuild/instance-2/output-1/host/lib/python3.9/site-packages/cryptography/x509/certificate_transparency.py", line 10, in <module>
> import six
> ModuleNotFoundError: No module named 'six'
>
> Fixes:
> - http://autobuild.buildroot.org/results/2b6872eec31362bf3edf88c69b67d681b2f016aa
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Arnout Vandecappelle):
> - Use host-python-six instead of host-python3-six
>
> package/python-cryptography/python-cryptography.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/python-cryptography/python-cryptography.mk b/package/python-cryptography/python-cryptography.mk
> index e21b9db042..acc21c1227 100644
> --- a/package/python-cryptography/python-cryptography.mk
> +++ b/package/python-cryptography/python-cryptography.mk
> @@ -14,7 +14,7 @@ PYTHON_CRYPTOGRAPHY_CPE_ID_VENDOR = cryptography_project
> PYTHON_CRYPTOGRAPHY_CPE_ID_PRODUCT = cryptography
> PYTHON_CRYPTOGRAPHY_DEPENDENCIES = host-python-cffi openssl
> HOST_PYTHON_CRYPTOGRAPHY_NEEDS_HOST_PYTHON = python3
> -HOST_PYTHON_CRYPTOGRAPHY_DEPENDENCIES = host-python3-cffi host-openssl
> +HOST_PYTHON_CRYPTOGRAPHY_DEPENDENCIES = host-python3-cffi host-python-six host-openssl
>
> $(eval $(python-package))
> $(eval $(host-python-package))
Tested-by: Peter Seiderer <ps.report@gmx.net>
Regards,
Peter
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v2, 1/1] package/python-cryptography: add host-python-six dependency
2021-10-26 16:32 [Buildroot] [PATCH v2, 1/1] package/python-cryptography: add host-python-six dependency Fabrice Fontaine
2021-11-04 5:05 ` James Hilliard
2021-11-04 18:00 ` Peter Seiderer
@ 2021-11-04 20:17 ` Thomas Petazzoni
2021-11-08 18:14 ` Arnout Vandecappelle
2 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2021-11-04 20:17 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Asaf Kahlon, buildroot
On Tue, 26 Oct 2021 18:32:22 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Arnout Vandecappelle):
> - Use host-python-six instead of host-python3-six
I *think* this was incorrect from Arnout. Indeed,
host-python-cryptography is a dependency of ca-certificates, and it is
perfectly possible to have this with a Python 2.x enabled for the
target (which would mean host-python-six installs for Python 2.x on the
host).
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v2, 1/1] package/python-cryptography: add host-python-six dependency
2021-11-04 20:17 ` Thomas Petazzoni
@ 2021-11-08 18:14 ` Arnout Vandecappelle
0 siblings, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle @ 2021-11-08 18:14 UTC (permalink / raw)
To: Thomas Petazzoni, Fabrice Fontaine; +Cc: Asaf Kahlon, buildroot
On 04/11/2021 21:17, Thomas Petazzoni wrote:
> On Tue, 26 Oct 2021 18:32:22 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>> ---
>> Changes v1 -> v2 (after review of Arnout Vandecappelle):
>> - Use host-python-six instead of host-python3-six
>
> I *think* this was incorrect from Arnout. Indeed,
> host-python-cryptography is a dependency of ca-certificates, and it is
> perfectly possible to have this with a Python 2.x enabled for the
> target (which would mean host-python-six installs for Python 2.x on the
> host).
commit 0c7e30b43a5e98abfc8db521a6415b5a5c1c267f
Author: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Date: Sat Jul 10 23:55:32 2021
package/python-idna: bump to version 3.2
- Python 2 is not supported since version 3.0 so update all reverse
dependencies and remove python-coherence
Since python-cryptography has a (runtime) dependency on python-idna, I had
assumed that host-python-cryptography would have the same dependency, and
therefore be python3-only as well. This seems to be a mistake, however. I guess
ca-certificates only uses host-python-cryptography to a very limited extent that
doesn't actually trigger all those runtime dependencies.
Anyway, we need to get f**g rid of python2!
Regards,
Arnout
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-11-08 18:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-26 16:32 [Buildroot] [PATCH v2, 1/1] package/python-cryptography: add host-python-six dependency Fabrice Fontaine
2021-11-04 5:05 ` James Hilliard
2021-11-04 18:00 ` Peter Seiderer
2021-11-04 20:17 ` Thomas Petazzoni
2021-11-08 18:14 ` Arnout Vandecappelle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.