All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Cc: Raul Cabello <raul.cabello@suse.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [RFC 2/2] Config.in: move toolchain menu before build options
Date: Thu, 4 Nov 2021 21:46:36 +0100	[thread overview]
Message-ID: <20211104204636.GB2400@scaer> (raw)
In-Reply-To: <20211006204133.465875-2-arnout@mind.be>

Arnout, All,

On 2021-10-06 22:41 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> Many of the build options depend on the toolchain configuration. In
> addition, it's pretty logical that you select first target architecture,
> then the toolchain, and only then things like debug and pic/pie.
> Therefore, move the "Toolchain" menu before the "Build options" menu
> instead of after.

I think a much better solution would be to move the toolchain-related
build options to the "Toolchain" menu, and keep in the "Build options"
menu focused on the actual generic build "infra" (arg, I can't find a
proper word...). Parallel jobs, download tools, patch directories et al.
really are related to the build infrastructure, while static, -Os et al.
are more about the toolchain "configuration".

Regards,
Yann E. MORIN.

> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
>  Config.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Config.in b/Config.in
> index 8ed11c994d..efdf397c01 100644
> --- a/Config.in
> +++ b/Config.in
> @@ -87,6 +87,8 @@ config BR2_NEEDS_HOST_GCC_PLUGIN_SUPPORT
>  
>  source "arch/Config.in"
>  
> +source "toolchain/Config.in"
> +
>  menu "Build options"
>  
>  menu "Commands"
> @@ -908,8 +910,6 @@ comment "Fortify Source needs a glibc toolchain and optimization"
>  	depends on (!BR2_TOOLCHAIN_USES_GLIBC || BR2_OPTIMIZE_0)
>  endmenu
>  
> -source "toolchain/Config.in"
> -
>  source "system/Config.in"
>  
>  source "linux/Config.in"
> -- 
> 2.31.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2021-11-04 20:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06 20:41 [Buildroot] [RFC 1/2] toolchain: invert glibc <-> !static dependency Arnout Vandecappelle (Essensium/Mind)
2021-10-06 20:41 ` [Buildroot] [RFC 2/2] Config.in: move toolchain menu before build options Arnout Vandecappelle (Essensium/Mind)
2021-11-04 20:46   ` Yann E. MORIN [this message]
2021-11-08 18:17     ` Arnout Vandecappelle
2021-10-09 20:27 ` [Buildroot] [RFC 1/2] toolchain: invert glibc <-> !static dependency Thomas Petazzoni
2022-07-27  9:24 ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211104204636.GB2400@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=arnout@mind.be \
    --cc=buildroot@buildroot.org \
    --cc=raul.cabello@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.