All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/boinc: fix build with autoconf >= 2.70
Date: Thu, 4 Nov 2021 22:11:18 +0100	[thread overview]
Message-ID: <20211104221118.0f67acc3@windsurf> (raw)
In-Reply-To: <20211007164112.3490293-1-fontaine.fabrice@gmail.com>

Hello Fabrice,

On Thu,  7 Oct 2021 18:41:12 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fix the following build failure raised since bump of autoconf to version
> 2.71 in commit ecd54b65c1f998a7ccd91f7c523e4ff38c4781da and
> http://git.savannah.gnu.org/gitweb/?p=autoconf.git;a=commit;h=ec90049dfcf4538750e61d675d885157fa5ca7f8:
> 
> checking for /home/buildroot/autobuild/instance-0/output-1/host/bin/mips-linux-gnu-gcc options needed to detect all undeclared functions... cannot detect
> configure: error: in `/home/buildroot/autobuild/instance-0/output-1/build/boinc-7.16.18':
> configure: error: cannot make /home/buildroot/autobuild/instance-0/output-1/host/bin/mips-linux-gnu-gcc report undeclared builtins
> 
> This error raised because AC_CHECK_DECLS returns an error due to -mavx
> flag:
> 
> mips-linux-gnu-gcc: error: unrecognized command line option '-mavx'
> 
> To fix this build failure, hard code ac_cv_c_undeclared_builtin_options
> to 'none needed' as removing '-mavx' from CPPFLAGS will hinder the
> detection of xgetbv, xgetbv, __xgetbv, cpuid, _cpuid and __cpuid
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/4b468a5d3bfbff9638316ca930ef791867774aef
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Wow, this was messy, and took me a while to understand. I've even added
a comment in the .mk file itself to explain what's going on.

There is a bug open in upstream Boinc on Github to track this issue,
and they acknowledge that they shouldn't unconditionally pass -mavx,
which really is the root of the problem.

Anyway, in the mean time, I have applied your patch, with an additional
comment, as said above.

Thanks for the good investigation on this one!

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2021-11-04 21:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07 16:41 [Buildroot] [PATCH 1/1] package/boinc: fix build with autoconf >= 2.70 Fabrice Fontaine
2021-11-04 21:11 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211104221118.0f67acc3@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=bernd.kuhls@t-online.de \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.