From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA1E9C433EF for ; Mon, 8 Nov 2021 15:07:30 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFB1361053 for ; Mon, 8 Nov 2021 15:07:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EFB1361053 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5B19383841; Mon, 8 Nov 2021 16:07:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QomMVATa"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BB36783832; Mon, 8 Nov 2021 16:07:26 +0100 (CET) Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C62808364A for ; Mon, 8 Nov 2021 16:07:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=macroalpha82@gmail.com Received: by mail-ot1-x32c.google.com with SMTP id l7-20020a0568302b0700b0055ae988dcc8so22762528otv.12 for ; Mon, 08 Nov 2021 07:07:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZKhjdPSEDiCPsTxa3mfXfDakQXxLIpPJ50SGEEDU4tg=; b=QomMVATawFmNXqvpD5FUvBxey7RN49yBzrwb4Yl+3vuf40X4MyMvJb4hObhtwLxLP5 g+FF0TKlKs1lSgs/dTYFk4ULfH39MgVmB/Ccd5szrpWwYSc15LoomuVjCkNJ0214CtN0 g6R+M41j5kv/ZR1/9a9ydSGKnkkbPYQrK01uQRxzs31xh8pw5BSIm/yBIwip/QF2PBhu mxImZ/EYlpu9QmzMHe3REESRtNt0puS46OxDPTScK3KSTnAykZ7lRE/nqGmcZ+xkqr7w /tXuxOueREIDdKCc1XDmXThweiHHypVkuzX4raFLrHSgUQ7I+Jwxl0LTNp2JubCmMyPA mivw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZKhjdPSEDiCPsTxa3mfXfDakQXxLIpPJ50SGEEDU4tg=; b=1J25jKS08TOIpWb8H4eaaQc5GZhtHy7oltVU022xGCZpbnwLQ73Qtv1a0KRUIsU0X+ SEki9N7qe8WAmYI9hes7d3/XboijGDNdijBSB4ipPHpv0qQsJlYwxoazl6cdMGL1eSVW 1Kirpr/n0QrRY27ax4ebPtejy9pzJiPD5qaPVRhI+32of03QR5jS4k6VVsLx33Xqfdz9 IiYy+yGPcUQ2A00HZfmQYtEKOMhNFINagcFtWUwuf8uMy2+nzChze5UbEQlZoER6H1lY MvHHT8WQVfV66Y5Gp5dusg+NLTXmq2l3M9Phzb5dFW/l2eiy8/GpXqoCza+6l7UJPeLk xL6Q== X-Gm-Message-State: AOAM53070p7GqV9DbSPCEXyWcUMsYlrJvIPzxXWLZ1IkPBBtk23GJKQZ +V2aJrrP9qsbsE9xD4ccgO0ixsmmZTE= X-Google-Smtp-Source: ABdhPJwHIjpKL7OR+9eJBDJFi1RDX7tRlUkTfBZrVa0TQ6jjwCLTwyJ9wtFda6gOhWCs7uY0MLuy0g== X-Received: by 2002:a05:6830:3113:: with SMTP id b19mr299193ots.383.1636384042030; Mon, 08 Nov 2021 07:07:22 -0800 (PST) Received: from wintermute.localdomain (cpe-76-183-134-35.tx.res.rr.com. [76.183.134.35]) by smtp.gmail.com with ESMTPSA id 9sm1784354oij.16.2021.11.08.07.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Nov 2021 07:07:21 -0800 (PST) From: Chris Morgan To: u-boot@lists.denx.de Cc: sjg@chromium.org, eugen.hristev@microchip.com, Chris Morgan Subject: [PATCH] w1: w1-gpio: Loosen timings to improve cold boot reliability Date: Mon, 8 Nov 2021 09:07:16 -0600 Message-Id: <20211108150716.59-1-macroalpha82@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean From: Chris Morgan On my NTC CHIP whenever I do a cold boot any attached DIPs cannot be found. Rebooting on the other hand appears to fix the issue. I found that if I modified the timing slightly (but still within spec) the w1 identification on cold boot became far more reliable. Signed-off-by: Chris Morgan --- drivers/w1/w1-gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/w1-gpio.c b/drivers/w1/w1-gpio.c index 9346f810ce..5565de2a92 100644 --- a/drivers/w1/w1-gpio.c +++ b/drivers/w1/w1-gpio.c @@ -22,8 +22,8 @@ #define W1_TIMING_E 9 #define W1_TIMING_F 55 #define W1_TIMING_G 0 -#define W1_TIMING_H 480 -#define W1_TIMING_I 70 +#define W1_TIMING_H 600 +#define W1_TIMING_I 100 #define W1_TIMING_J 410 struct w1_gpio_pdata { -- 2.30.2