From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E062C433EF for ; Tue, 9 Nov 2021 01:02:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 150666137F for ; Tue, 9 Nov 2021 01:02:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237438AbhKIBFj (ORCPT ); Mon, 8 Nov 2021 20:05:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:33032 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238076AbhKIBET (ORCPT ); Mon, 8 Nov 2021 20:04:19 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 40A4A614C8; Tue, 9 Nov 2021 01:01:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636419679; bh=QJctPq2mvvXd9D5+REVvKRYsNwuWRooixOau3OZ0qMo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X/NbspBqFwh5wCL5w9MvpgM8u+7Ifzm5C/OdMcbAms68WxV0fGlDyOq3fqBRzxjFZ 1wQeyWKvkWbqBY71DcQGXc9gQggUPWB8XmgjY9DLduQw2qv/BU0U7V8jisiQ3hBg/6 RFAXvYRQr1HmcjS0HEusgXMpkkO6Qz2V3S0Br/PEFCpN8SppgCdByXQpoC53dj66M/ gWZbMiuP+XJQTixFK0dVLY/w7sLV32pU5goDr1r2AdGHP+0N+WOTSVYaFpXmHOeW4u dj4mC4C1BDAlDNEmCJm2RJJlG5Z9OA3kNxhGSPvko8Sr8/UznDUonqk5sjMn9dLa5N Ni3hk4Y0EaIUw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tuo Li , TOTE Robot , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , a.hajda@samsung.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 046/146] media: s5p-mfc: fix possible null-pointer dereference in s5p_mfc_probe() Date: Mon, 8 Nov 2021 12:43:13 -0500 Message-Id: <20211108174453.1187052-46-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211108174453.1187052-1-sashal@kernel.org> References: <20211108174453.1187052-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Tuo Li [ Upstream commit 8515965e5e33f4feb56134348c95953f3eadfb26 ] The variable pdev is assigned to dev->plat_dev, and dev->plat_dev is checked in: if (!dev->plat_dev) This indicates both dev->plat_dev and pdev can be NULL. If so, the function dev_err() is called to print error information. dev_err(&pdev->dev, "No platform data specified\n"); However, &pdev->dev is an illegal address, and it is dereferenced in dev_err(). To fix this possible null-pointer dereference, replace dev_err() with mfc_err(). Reported-by: TOTE Robot Signed-off-by: Tuo Li Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index eba2b9f040df0..c763c0a03140c 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c @@ -1283,7 +1283,7 @@ static int s5p_mfc_probe(struct platform_device *pdev) spin_lock_init(&dev->condlock); dev->plat_dev = pdev; if (!dev->plat_dev) { - dev_err(&pdev->dev, "No platform data specified\n"); + mfc_err("No platform data specified\n"); return -ENODEV; } -- 2.33.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1105C433F5 for ; Tue, 9 Nov 2021 01:10:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71660611C4 for ; Tue, 9 Nov 2021 01:10:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 71660611C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Mb85Sk4Pxjt66X2pIrbwMSvQo49G9XixFhaULxL8ZxU=; b=G29b4/gSeR4Re5 qxaB0NZRRG7Iew111Wzc9rsdPorsOUkscBMpWSdPj7mbtTMNNFDUJsTcwN8grva0S9yXc1Qew0F+R vq1es/XHz0b9iB54r4otufB1vuowyRXf2qWEbdQzOQVUlNT8Yq++d4iesWfJ9PEPHhpSz0qgI84q6 MfSJqx2HozKVWiXs5QDC8XNU49lLH/rpyc2Ta+lkmTTwwwwJXYi9bXGSzEHU8/cBFKnHmWLTwMmaS N2jNTd3qV9WwLZRPdRlT4mdXFISCqRrvB2OFMNH7ipsD4VdhSmxTEbhRBrq4K2IK5Undb3DstOjou 4R2F3NPbANCQ4DX0CU4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkFcu-000E1J-TO; Tue, 09 Nov 2021 01:08:43 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkFVo-000Aw6-Ar for linux-arm-kernel@lists.infradead.org; Tue, 09 Nov 2021 01:01:22 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 40A4A614C8; Tue, 9 Nov 2021 01:01:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636419679; bh=QJctPq2mvvXd9D5+REVvKRYsNwuWRooixOau3OZ0qMo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X/NbspBqFwh5wCL5w9MvpgM8u+7Ifzm5C/OdMcbAms68WxV0fGlDyOq3fqBRzxjFZ 1wQeyWKvkWbqBY71DcQGXc9gQggUPWB8XmgjY9DLduQw2qv/BU0U7V8jisiQ3hBg/6 RFAXvYRQr1HmcjS0HEusgXMpkkO6Qz2V3S0Br/PEFCpN8SppgCdByXQpoC53dj66M/ gWZbMiuP+XJQTixFK0dVLY/w7sLV32pU5goDr1r2AdGHP+0N+WOTSVYaFpXmHOeW4u dj4mC4C1BDAlDNEmCJm2RJJlG5Z9OA3kNxhGSPvko8Sr8/UznDUonqk5sjMn9dLa5N Ni3hk4Y0EaIUw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tuo Li , TOTE Robot , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , a.hajda@samsung.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 046/146] media: s5p-mfc: fix possible null-pointer dereference in s5p_mfc_probe() Date: Mon, 8 Nov 2021 12:43:13 -0500 Message-Id: <20211108174453.1187052-46-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211108174453.1187052-1-sashal@kernel.org> References: <20211108174453.1187052-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211108_170120_422532_1A29AABF X-CRM114-Status: GOOD ( 12.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Tuo Li [ Upstream commit 8515965e5e33f4feb56134348c95953f3eadfb26 ] The variable pdev is assigned to dev->plat_dev, and dev->plat_dev is checked in: if (!dev->plat_dev) This indicates both dev->plat_dev and pdev can be NULL. If so, the function dev_err() is called to print error information. dev_err(&pdev->dev, "No platform data specified\n"); However, &pdev->dev is an illegal address, and it is dereferenced in dev_err(). To fix this possible null-pointer dereference, replace dev_err() with mfc_err(). Reported-by: TOTE Robot Signed-off-by: Tuo Li Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index eba2b9f040df0..c763c0a03140c 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c @@ -1283,7 +1283,7 @@ static int s5p_mfc_probe(struct platform_device *pdev) spin_lock_init(&dev->condlock); dev->plat_dev = pdev; if (!dev->plat_dev) { - dev_err(&pdev->dev, "No platform data specified\n"); + mfc_err("No platform data specified\n"); return -ENODEV; } -- 2.33.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel