From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EA86C433F5 for ; Tue, 9 Nov 2021 01:12:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF51861A0C for ; Tue, 9 Nov 2021 01:12:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CF51861A0C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=61duHV0F4R4weZ5yLJXKxf+lVVoBMxlbhlLLpJuOh6Q=; b=e7B038lZZBFfTC yLaAN3u3nGD24L1oqT7tDolL1eczPqywxJrLKH8i4NoBFfJhAA7+WY6lcoCElJcYX6MlknNy7bu0W XCeND2bBR16B4ON0k2AEfcy0LLQBa0XwNAxO9klY5Z/xEY0u5HJFbQ/4pYHBEHVa0LgveZQOZJbTA RraCbWp0OIeug4NKdebzTzHjVJQ+mHSTwOaocZsioDXaDaHL5pn8VGuLVLGHrgRKmzTbb97COEYhD 5YyKPy/2Qr5MZFvgxXL6xDk3BgxfjqByiBbbU3l9CKyOuXRSsltkTLW5AosE1m2e/4S2Zhzko2SIB 3Q2UZHqknqmsrBWoESPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkFeh-000EjR-96; Tue, 09 Nov 2021 01:10:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkFVp-000AxP-Px for linux-arm-kernel@lists.infradead.org; Tue, 09 Nov 2021 01:01:23 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C00E76124D; Tue, 9 Nov 2021 01:01:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636419680; bh=hCBZVbn5ACGsSoRa85leu+ceg8jHthpi32UI/d/3jZQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YGAsnJ6u4iJpYmHjC+w183slSvA5hHn+5izqp/tn0uKWmtM2p65fZ8Q1hEsRn1WxE Ea66bXMNyERAIbtJHdFSMkPK473ouz2okzv7nopkIWNZxh2s1Kp0a7O2R2sYIoFKKy gtARW/9nTOMiejW4tNFe1ICHiA0PHVXLFH3+f/k97beG+UGEvGQ4IPmJc4EMc/29du m7sLFZoy7fz2RQb/etuqss4FygOmJ3oO+cLzFeCokVT1uSYijBPKDwhREWqLtJ2Qkv rb3EEW3kqYTnqDZ5RSpQKH4ez4RWommwtPWVzVsKp5m/s8p9QvWUPVWg0EEEy5H3xO xegv9QfmEa30Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nadezda Lutovinova , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , a.hajda@samsung.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 047/146] media: s5p-mfc: Add checking to s5p_mfc_probe(). Date: Mon, 8 Nov 2021 12:43:14 -0500 Message-Id: <20211108174453.1187052-47-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211108174453.1187052-1-sashal@kernel.org> References: <20211108174453.1187052-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211108_170121_875356_3D6F4FF1 X-CRM114-Status: GOOD ( 10.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Nadezda Lutovinova [ Upstream commit cdfaf4752e6915a4b455ad4400133e540e4dc965 ] If of_device_get_match_data() return NULL, then null pointer dereference occurs in s5p_mfc_init_pm(). The patch adds checking if dev->variant is NULL. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Nadezda Lutovinova Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index c763c0a03140c..f336a95432732 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c @@ -1288,6 +1288,10 @@ static int s5p_mfc_probe(struct platform_device *pdev) } dev->variant = of_device_get_match_data(&pdev->dev); + if (!dev->variant) { + dev_err(&pdev->dev, "Failed to get device MFC hardware variant information\n"); + return -ENOENT; + } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); dev->regs_base = devm_ioremap_resource(&pdev->dev, res); -- 2.33.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50C02C433F5 for ; Tue, 9 Nov 2021 01:02:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3830A619E5 for ; Tue, 9 Nov 2021 01:02:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237937AbhKIBFi (ORCPT ); Mon, 8 Nov 2021 20:05:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:60044 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241769AbhKIBET (ORCPT ); Mon, 8 Nov 2021 20:04:19 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id C00E76124D; Tue, 9 Nov 2021 01:01:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636419680; bh=hCBZVbn5ACGsSoRa85leu+ceg8jHthpi32UI/d/3jZQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YGAsnJ6u4iJpYmHjC+w183slSvA5hHn+5izqp/tn0uKWmtM2p65fZ8Q1hEsRn1WxE Ea66bXMNyERAIbtJHdFSMkPK473ouz2okzv7nopkIWNZxh2s1Kp0a7O2R2sYIoFKKy gtARW/9nTOMiejW4tNFe1ICHiA0PHVXLFH3+f/k97beG+UGEvGQ4IPmJc4EMc/29du m7sLFZoy7fz2RQb/etuqss4FygOmJ3oO+cLzFeCokVT1uSYijBPKDwhREWqLtJ2Qkv rb3EEW3kqYTnqDZ5RSpQKH4ez4RWommwtPWVzVsKp5m/s8p9QvWUPVWg0EEEy5H3xO xegv9QfmEa30Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nadezda Lutovinova , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , a.hajda@samsung.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 047/146] media: s5p-mfc: Add checking to s5p_mfc_probe(). Date: Mon, 8 Nov 2021 12:43:14 -0500 Message-Id: <20211108174453.1187052-47-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211108174453.1187052-1-sashal@kernel.org> References: <20211108174453.1187052-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Nadezda Lutovinova [ Upstream commit cdfaf4752e6915a4b455ad4400133e540e4dc965 ] If of_device_get_match_data() return NULL, then null pointer dereference occurs in s5p_mfc_init_pm(). The patch adds checking if dev->variant is NULL. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Nadezda Lutovinova Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index c763c0a03140c..f336a95432732 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c @@ -1288,6 +1288,10 @@ static int s5p_mfc_probe(struct platform_device *pdev) } dev->variant = of_device_get_match_data(&pdev->dev); + if (!dev->variant) { + dev_err(&pdev->dev, "Failed to get device MFC hardware variant information\n"); + return -ENOENT; + } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); dev->regs_base = devm_ioremap_resource(&pdev->dev, res); -- 2.33.0