From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61FBAC433EF for ; Tue, 9 Nov 2021 01:34:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 309C7610A3 for ; Tue, 9 Nov 2021 01:34:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 309C7610A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=045OoYgi1zjI/WpI2b2y6l1ZYNbBgptWuc3C5dWxAwA=; b=A21Q61N79lCqxV MOJqsd4NADLWGd3AN2d7c1Yg04utlk/Yv1Q33/AT8roiUE6ZdSocYoa9wbsVrU9aTYZKYBZdGan/7 tDxz/4MHIbE/oet+k5vnWS9yaVBostMBjAxRbHvtmXPLVHyL4TX0cWTXgISfaIrnMNwmN8bPdg0tL WpNd/cwGRk81tOq5Z7qmrfFFdgy39IKdGxKgAwh8AAk5FZS+iucpf5MOJDzfoKzrkUU0XjA130IQu tNSdpgyiURTz2efJcXzQopwrZ9NYW/jLVfyZwBz5LUBPpPoXiB5D+vIvo91h+/CRgAuCg40c8q2ra vHfQG66pDSKGMhU6ic5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkG01-000Mok-N7; Tue, 09 Nov 2021 01:32:34 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkFbY-000Dbx-UD for linux-arm-kernel@lists.infradead.org; Tue, 09 Nov 2021 01:07:18 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 56A1061208; Tue, 9 Nov 2021 01:07:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636420036; bh=6XFShESb3tEItH9n1KKX1n5lw0IPgTsGv3LTtpiuBB0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aTjwk5SDavz8iYy93kBF09TUrsOgwjmMp8GLzCGMHqqY582Pa+YEOaqmnky1yPugk cgo3xr7GUtJmCjmv9B4mT64OCuyfzv+04FaJbtxT0Y0r7IKeirGGbhgbjU6B6rVNCP dWj+1EFc8HQBFjYVtrd48bi6GHRzWejXIKyoJXI0NYI17WMwWxCaD0Ok8GpMWBZYix rB6v9CE+UpKCVZcm59ugYsIMUSLqMMLIsvAzdJYqkTSzuQaONGpfEIUD/Uc+ZP28/a nxEsBulJ0gFrVGorS+sj6YH330AKG0l3DMTBOOVL1lGiiNHjg4W9y7mxRcWi3OqQk9 AS4Vmtp0nch5A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tuo Li , TOTE Robot , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , a.hajda@samsung.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 15/39] media: s5p-mfc: fix possible null-pointer dereference in s5p_mfc_probe() Date: Mon, 8 Nov 2021 20:06:25 -0500 Message-Id: <20211109010649.1191041-15-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211109010649.1191041-1-sashal@kernel.org> References: <20211109010649.1191041-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211108_170717_050411_46EF5FF1 X-CRM114-Status: GOOD ( 12.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Tuo Li [ Upstream commit 8515965e5e33f4feb56134348c95953f3eadfb26 ] The variable pdev is assigned to dev->plat_dev, and dev->plat_dev is checked in: if (!dev->plat_dev) This indicates both dev->plat_dev and pdev can be NULL. If so, the function dev_err() is called to print error information. dev_err(&pdev->dev, "No platform data specified\n"); However, &pdev->dev is an illegal address, and it is dereferenced in dev_err(). To fix this possible null-pointer dereference, replace dev_err() with mfc_err(). Reported-by: TOTE Robot Signed-off-by: Tuo Li Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index 9942932ecbf9c..63d46fae9b289 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c @@ -1280,7 +1280,7 @@ static int s5p_mfc_probe(struct platform_device *pdev) spin_lock_init(&dev->condlock); dev->plat_dev = pdev; if (!dev->plat_dev) { - dev_err(&pdev->dev, "No platform data specified\n"); + mfc_err("No platform data specified\n"); return -ENODEV; } -- 2.33.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A56DCC433FE for ; Tue, 9 Nov 2021 01:23:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92605610A3 for ; Tue, 9 Nov 2021 01:23:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243023AbhKIB0f (ORCPT ); Mon, 8 Nov 2021 20:26:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:46240 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242521AbhKIBRf (ORCPT ); Mon, 8 Nov 2021 20:17:35 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 56A1061208; Tue, 9 Nov 2021 01:07:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636420036; bh=6XFShESb3tEItH9n1KKX1n5lw0IPgTsGv3LTtpiuBB0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aTjwk5SDavz8iYy93kBF09TUrsOgwjmMp8GLzCGMHqqY582Pa+YEOaqmnky1yPugk cgo3xr7GUtJmCjmv9B4mT64OCuyfzv+04FaJbtxT0Y0r7IKeirGGbhgbjU6B6rVNCP dWj+1EFc8HQBFjYVtrd48bi6GHRzWejXIKyoJXI0NYI17WMwWxCaD0Ok8GpMWBZYix rB6v9CE+UpKCVZcm59ugYsIMUSLqMMLIsvAzdJYqkTSzuQaONGpfEIUD/Uc+ZP28/a nxEsBulJ0gFrVGorS+sj6YH330AKG0l3DMTBOOVL1lGiiNHjg4W9y7mxRcWi3OqQk9 AS4Vmtp0nch5A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tuo Li , TOTE Robot , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , a.hajda@samsung.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 15/39] media: s5p-mfc: fix possible null-pointer dereference in s5p_mfc_probe() Date: Mon, 8 Nov 2021 20:06:25 -0500 Message-Id: <20211109010649.1191041-15-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211109010649.1191041-1-sashal@kernel.org> References: <20211109010649.1191041-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Tuo Li [ Upstream commit 8515965e5e33f4feb56134348c95953f3eadfb26 ] The variable pdev is assigned to dev->plat_dev, and dev->plat_dev is checked in: if (!dev->plat_dev) This indicates both dev->plat_dev and pdev can be NULL. If so, the function dev_err() is called to print error information. dev_err(&pdev->dev, "No platform data specified\n"); However, &pdev->dev is an illegal address, and it is dereferenced in dev_err(). To fix this possible null-pointer dereference, replace dev_err() with mfc_err(). Reported-by: TOTE Robot Signed-off-by: Tuo Li Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index 9942932ecbf9c..63d46fae9b289 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c @@ -1280,7 +1280,7 @@ static int s5p_mfc_probe(struct platform_device *pdev) spin_lock_init(&dev->condlock); dev->plat_dev = pdev; if (!dev->plat_dev) { - dev_err(&pdev->dev, "No platform data specified\n"); + mfc_err("No platform data specified\n"); return -ENODEV; } -- 2.33.0