From: "Marek Behún" <kabel@kernel.org>
To: Roman Bacik <roman.bacik@broadcom.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Pali Rohar <pali@kernel.org>,
Bharat Gooty <bharat.gooty@broadcom.com>,
Joe Hershberger <joe.hershberger@ni.com>,
Ramon Fried <rfried.dev@gmail.com>
Subject: Re: [PATCH v10 1/2] net: brcm: netXtreme driver
Date: Tue, 9 Nov 2021 03:55:09 +0100 [thread overview]
Message-ID: <20211109035509.527c3de7@thinkpad> (raw)
In-Reply-To: <CAGQAs7zvpovcN2AFuaP7qzbK8NJyGfLpeG_-fsxbbX+ot8Wr3w@mail.gmail.com>
On Mon, 8 Nov 2021 18:20:43 -0800
Roman Bacik <roman.bacik@broadcom.com> wrote:
> On Mon, Nov 8, 2021 at 5:12 PM Marek Behún <kabel@kernel.org> wrote:
> >
> > On Mon, 8 Nov 2021 16:48:33 -0800
> > Roman Bacik <roman.bacik@broadcom.com> wrote:
> >
> > > To be honest changing status codes coming from FW does not seem right. But
> > > we will try to make the requested changes.
> >
> > I looked at kernel's implementation of this driver and these hwrm
> > functions and they don't return STATUS_*.
> >
> > Marek
>
> Marek,
>
> This is quite a different driver and it was written for uboot.
Hello Roman
The drivers clearly have a common ancestor, there are far too many
similarities. It clearly wasn't written from scratch for U-Boot.
> If the
> main objection is that Linux driver is different then maybe we should
> use v10 as is. Currently hwrm methods return HW status and bnxt
> methods return uboot error codes consistently.
I will leave this to U-Boot's network subsystem maintainers. As I said,
beggars cannot be choosers in U-Boot. As long as the driver does not
introduce vendor specific stuff to the user API (in U-Boot command
line), then I guess I'll have to be satisfied.
Marek
next prev parent reply other threads:[~2021-11-09 2:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 22:46 [PATCH v10 1/2] net: brcm: netXtreme driver Roman Bacik
2021-11-08 22:46 ` [PATCH v10 2/2] board: brcm-ns3: Load netXtreme firmware Roman Bacik
2021-12-02 6:27 ` Ramon Fried
2021-11-08 23:43 ` [PATCH v10 1/2] net: brcm: netXtreme driver Marek Behún
2021-11-09 0:48 ` Roman Bacik
2021-11-09 1:11 ` Marek Behún
2021-11-09 2:20 ` Roman Bacik
2021-11-09 2:55 ` Marek Behún [this message]
2021-11-09 8:37 ` Ramon Fried
2021-11-09 15:23 ` Roman Bacik
2021-12-02 6:26 ` Ramon Fried
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211109035509.527c3de7@thinkpad \
--to=kabel@kernel.org \
--cc=bharat.gooty@broadcom.com \
--cc=joe.hershberger@ni.com \
--cc=pali@kernel.org \
--cc=rfried.dev@gmail.com \
--cc=roman.bacik@broadcom.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.