From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Marek Behún" <kabel@kernel.org>
Cc: linux-phy@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
pali@kernel.org
Subject: Re: [PATCH phy 1/6] phy: marvell: phy-mvebu-a3700-comphy: Remove port from driver configuration
Date: Tue, 9 Nov 2021 10:55:40 +0100 [thread overview]
Message-ID: <20211109105540.5b02f4d2@xps13> (raw)
In-Reply-To: <20211028184242.22105-2-kabel@kernel.org>
Hi Marek,
kabel@kernel.org wrote on Thu, 28 Oct 2021 20:42:37 +0200:
> From: Pali Rohár <pali@kernel.org>
>
> Port number is encoded into argument for SMC call. It is zero for SATA,
> PCIe and also both USB 3.0 PHYs. It is non-zero only for Ethernet PHY
> (incorrectly called SGMII) on lane 0. Ethernet PHY on lane 1 also uses zero
> port number.
>
> So construct "port" bits for SMC call argument can be constructed directly
> from PHY type and lane number.
>
> Change driver code to always pass zero port number for non-ethernet PHYs
> and for ethernet PHYs determinate port number from lane number. This
> simplifies the driver.
>
> As port number from DT PHY configuration is not used anymore, remove whole
> driver code which parses it. This also simplifies the driver.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Signed-off-by: Marek Behún <kabel@kernel.org>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2021-11-09 9:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 18:42 [PATCH phy 0/6] Armada 3720 comphy native implementation Marek Behún
2021-10-28 18:42 ` [PATCH phy 1/6] phy: marvell: phy-mvebu-a3700-comphy: Remove port from driver configuration Marek Behún
2021-11-09 9:55 ` Miquel Raynal [this message]
2021-10-28 18:42 ` [PATCH phy 2/6] phy: marvell: phy-mvebu-a3700-comphy: Add native kernel implementation Marek Behún
2021-11-09 10:09 ` Miquel Raynal
2021-11-23 7:26 ` Vinod Koul
2021-11-25 10:58 ` Pali Rohár
2021-12-03 20:58 ` Marek Behún
2021-10-28 18:42 ` [PATCH phy 3/6] arm64: dts: marvell: armada-37xx: Add xtal clock to comphy node Marek Behún
2021-10-28 18:42 ` [PATCH phy 4/6] Revert "ata: ahci: mvebu: Make SATA PHY optional for Armada 3720" Marek Behún
2021-11-09 10:10 ` Miquel Raynal
2021-10-28 18:42 ` [PATCH phy 5/6] Revert "usb: host: xhci: mvebu: make USB 3.0 " Marek Behún
2021-11-09 10:10 ` Miquel Raynal
2021-10-28 18:42 ` [PATCH phy 6/6] Revert "PCI: aardvark: Fix initialization with old Marvell's Arm Trusted Firmware" Marek Behún
2021-11-09 10:10 ` Miquel Raynal
2021-11-10 19:45 ` [PATCH phy 0/6] Armada 3720 comphy native implementation Marek Behún
2021-11-11 14:25 ` Vinod Koul
2021-11-11 14:32 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211109105540.5b02f4d2@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=kabel@kernel.org \
--cc=kishon@ti.com \
--cc=linux-phy@lists.infradead.org \
--cc=pali@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.