From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-mips@linux-mips.org, clang-built-linux@googlegroups.com,
Nathan Chancellor <nathan@kernel.org>,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
zhaoxiao <zhaoxiao@uniontech.com>
Subject: Re: [PATCH] MIPS: VDSO: remove -nostdlib compiler flag
Date: Tue, 9 Nov 2021 16:30:40 +0100 [thread overview]
Message-ID: <20211109153040.GD12535@alpha.franken.de> (raw)
In-Reply-To: <20211107161938.323485-1-masahiroy@kernel.org>
On Mon, Nov 08, 2021 at 01:19:38AM +0900, Masahiro Yamada wrote:
> The -nostdlib option requests the compiler to not use the standard
> system startup files or libraries when linking. It is effective only
> when $(CC) is used as a linker driver.
>
> Since commit 2ff906994b6c ("MIPS: VDSO: Use $(LD) instead of $(CC) to
> link VDSO"), $(LD) is directly used, hence -nostdlib is unneeded.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> arch/mips/vdso/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile
> index 1b2ea34c3d3b..d65f55f67e19 100644
> --- a/arch/mips/vdso/Makefile
> +++ b/arch/mips/vdso/Makefile
> @@ -57,7 +57,7 @@ endif
>
> # VDSO linker flags.
> ldflags-y := -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \
> - $(filter -E%,$(KBUILD_CFLAGS)) -nostdlib -shared \
> + $(filter -E%,$(KBUILD_CFLAGS)) -shared \
> -G 0 --eh-frame-hdr --hash-style=sysv --build-id=sha1 -T
>
> CFLAGS_REMOVE_vdso.o = $(CC_FLAGS_FTRACE)
> --
> 2.30.2
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2021-11-09 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-07 16:19 [PATCH] MIPS: VDSO: remove -nostdlib compiler flag Masahiro Yamada
2021-11-09 15:30 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211109153040.GD12535@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mips@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=zhaoxiao@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.