From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
To: buildroot@buildroot.org
Cc: James Hilliard <james.hilliard1@gmail.com>,
Fabrice Fontaine <fontaine.fabrice@gmail.com>
Subject: [Buildroot] [PATCH 1/1] package/pipewire: fix NLS build
Date: Tue, 9 Nov 2021 18:13:51 +0100 [thread overview]
Message-ID: <20211109171351.456708-1-fontaine.fabrice@gmail.com> (raw)
Fix the following build failure raised since bump to version 0.3.39 in
commit d9796f2db9866060b916487784b046bb6b76f9b6 and
https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/ddfbd684e78e2b8b9ad40bedb4612ea0197d231a:
/home/giuliobenetti/autobuild/run/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/sh4-buildroot-linux-uclibc/9.3.0/../../../../sh4-buildroot-linux-uclibc/bin/ld: src/pipewire/libpipewire-0.3.so.0.339.0.p/pipewire.c.o: in function `i18n_ntext':
pipewire.c:(.text+0x3ec): undefined reference to `libintl_dngettext'
Indeed, since that time, pipewire uses the new meson intl dependency API
which has been added in version 0.59.0 with
https://github.com/mesonbuild/meson/commit/2c6ccfe4c40741ae1f15f073f7d7bc8c398a1648
This new intl dependency API is broken (which is not so surprising based
on my experience of meson). Don't even try to fix it as meson is not
very prone to merge our pull requests:
https://github.com/mesonbuild/meson/issues/6108
https://github.com/mesonbuild/meson/pull/6629
Fixes:
- http://autobuild.buildroot.org/results/435d59d40209cc1028cee8e2a71a69cd3769ab56
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/pipewire/pipewire.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/pipewire/pipewire.mk b/package/pipewire/pipewire.mk
index f376f3c276..4cd2e7fcf5 100644
--- a/package/pipewire/pipewire.mk
+++ b/package/pipewire/pipewire.mk
@@ -11,6 +11,7 @@ PIPEWIRE_LICENSE = MIT, LGPL-2.1+ (libspa-alsa), GPL-2.0 (libjackserver)
PIPEWIRE_LICENSE_FILES = COPYING LICENSE
PIPEWIRE_INSTALL_STAGING = YES
PIPEWIRE_DEPENDENCIES = host-pkgconf $(TARGET_NLS_DEPENDENCIES)
+PIPEWIRE_LDFLAGS = $(TARGET_NLS_LIBS)
PIPEWIRE_CONF_OPTS += \
-Ddocs=disabled \
--
2.33.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next reply other threads:[~2021-11-09 17:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 17:13 Fabrice Fontaine [this message]
2021-11-12 13:36 ` [Buildroot] [PATCH 1/1] package/pipewire: fix NLS build Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211109171351.456708-1-fontaine.fabrice@gmail.com \
--to=fontaine.fabrice@gmail.com \
--cc=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.