From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4F39C433EF for ; Wed, 10 Nov 2021 07:44:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4557D611F0 for ; Wed, 10 Nov 2021 07:44:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4557D611F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id ACABB6B006C; Wed, 10 Nov 2021 02:44:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A7A4C6B0071; Wed, 10 Nov 2021 02:44:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 969286B0072; Wed, 10 Nov 2021 02:44:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0165.hostedemail.com [216.40.44.165]) by kanga.kvack.org (Postfix) with ESMTP id 835366B006C for ; Wed, 10 Nov 2021 02:44:48 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3BEFB82499B9 for ; Wed, 10 Nov 2021 07:44:48 +0000 (UTC) X-FDA: 78792233856.28.F48EFD0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf12.hostedemail.com (Postfix) with ESMTP id C1F61100009D for ; Wed, 10 Nov 2021 07:44:47 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 2AAEA611ED; Wed, 10 Nov 2021 07:44:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636530286; bh=X97XRaIFoSbPhsaZ8G8JIdgC+nVfoxiFTaKJeg9rslw=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=GfBH2Ud/Sb7sLq7KhkM6T4ur32J7IoNbJnYAu2dPBR3E6pHlqGm19sYa5XRYQXo8f sANzoFXJ5K3tm8OHPpJtzZI7RqexKkC9BCnfN9Ej6nFsXOPp9qYPONN9TtfCP+R9d6 dxmTPDLVwAiLR4xE7V62c32GG4mmtC+x6j4ivgnUvfqVeWx+iPieR0OGxGRWUp4dVY Y8o0oPORdsL86DdW3QbiCuXBH0TtNtr+KGsVWHVSKFylBVIGxz5gquCjJJFBxNo4xu wnm0UOnPlRgOGDfo0HIJAFzcYqnTcZl3nY318T48WFXOIdrjDmAyxG/KqybjaNjhxz 8UghztFMdCbVw== From: SeongJae Park To: Muchun Song Cc: Yihao Han , SeongJae Park , Andrew Morton , Linux Memory Management List , LKML , kernel@vivo.com Subject: Re: [PATCH] mm/damon/vaddr: use swap() to make code cleaner Date: Wed, 10 Nov 2021 07:44:40 +0000 Message-Id: <20211110074440.13343-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C1F61100009D X-Stat-Signature: doraeqj5dqdj143ckx59a5dw5y34jfux Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="GfBH2Ud/"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=sj@kernel.org X-HE-Tag: 1636530287-423174 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 10 Nov 2021 12:15:57 +0800 Muchun Song wrote: > On Wed, Nov 10, 2021 at 11:32 AM Yihao Han wrote: > > > > Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid > > opencoding it. > > > > Signed-off-by: Yihao Han > > --- > > mm/damon/vaddr.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c > > index 35fe49080ee9..414d9fb9c827 100644 > > --- a/mm/damon/vaddr.c > > +++ b/mm/damon/vaddr.c > > @@ -100,11 +100,7 @@ static unsigned long sz_range(struct damon_addr_range *r) > > static void swap_ranges(struct damon_addr_range *r1, > > struct damon_addr_range *r2) > > { > > - struct damon_addr_range tmp; > > - > > - tmp = *r1; > > - *r1 = *r2; > > - *r2 = tmp; > > + swap(*r1, *r2); > > IMHO, I suggest removing swap_ranges() completely > since it's only a wrapper of swap() after your changes. > The caller can invoke swap() directly. I also agree to Muchun. Thanks, SJ > > Thanks. > > > } > > > > /* > > -- > > 2.17.1 > >