From: SeongJae Park <sj@kernel.org>
To: Xin Hao <xhao@linux.alibaba.com>
Cc: sjpark@amazon.de, akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V1 1/2] mm/damon: Unified access_check function naming rules
Date: Wed, 10 Nov 2021 12:59:59 +0000 [thread overview]
Message-ID: <20211110125959.18141-1-sj@kernel.org> (raw)
In-Reply-To: <556ab139a12296744d25f76b99f4e6b7ccfaf131.1636546262.git.xhao@linux.alibaba.com>
On Wed, 10 Nov 2021 20:13:13 +0800 Xin Hao <xhao@linux.alibaba.com> wrote:
> In damon/paddr.c file, two functions names start with underscore,
> static void __damon_pa_prepare_access_check(struct damon_ctx *ctx,
> struct damon_region *r)
> static void __damon_pa_prepare_access_check(struct damon_ctx *ctx,
> struct damon_region *r)
> In damon/vaddr.c file, there are also two functions with the same function,
> static void damon_va_prepare_access_check(struct damon_ctx *ctx,
> struct mm_struct *mm, struct damon_region *r)
> static void damon_va_check_access(struct damon_ctx *ctx,
> struct mm_struct *mm, struct damon_region *r)
>
> It makes sense to keep consistent, and it is not easy to be confused with
> the function that call them.
>
> Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
[...]
next prev parent reply other threads:[~2021-11-10 13:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 12:13 [PATCH V1 0/2] mm/damon: Do some small changes Xin Hao
2021-11-10 12:13 ` [PATCH V1 1/2] mm/damon: Unified access_check function naming rules Xin Hao
2021-11-10 12:59 ` SeongJae Park [this message]
2021-11-10 12:13 ` [PATCH V1 2/2] mm/damon: Add 'age' of region tracepoint support Xin Hao
2021-11-10 13:16 ` SeongJae Park
2021-11-11 2:04 ` Xin Hao
2021-11-11 8:20 ` SeongJae Park
2021-11-11 8:29 ` Xin Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211110125959.18141-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sjpark@amazon.de \
--cc=xhao@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.