Re: [INTERNAL PATCH 2/2] cxl/cxlmem: Change cxl_mem to a more descriptive name

[Jonathan Cameron <Jonathan.Cameron@Huawei.com>]

On Tue, 2 Nov 2021 13:29:01 -0700
<ira.weiny@intel.com> wrote:

> From: Ira Weiny <ira.weiny@intel.com>
> 
> The cxl_mem object actually represents the state of a CXL device within the
> driver.  This is data layered on top of the PCI or other device.  Even though
> the only device currently represented is a memory device, calling this cxl_mem
> is confusing because this is not solely a CXL memory device.  Furthermore,
> cxl_memdev does drive a CXL memory device.  So changing the name helps to
> distinguish these to structures.
> 
> Update the structure name, function names, and the kdocs to reflect the
> real uses of this structure.
> 
> Acked-by: Ben Widawsky <ben.widawsky@intel.com>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> 

...

>  struct cxl_memdev *
> -devm_cxl_add_memdev(struct cxl_mem *cxlm)
> +devm_cxl_add_memdev(struct cxl_dev_state *cxlds)
Just noticed on a read through (I'm trying to catch up with recent changes)

Combine the above 2 lines into one.  Could do it as a tidy up
patch if too late to fold into this patch.

Thanks,

Jonathan


>  {
>  	struct cxl_memdev *cxlmd;
>  	struct device *dev;
>  	struct cdev *cdev;