From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [193.142.43.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C237C2C81 for ; Wed, 10 Nov 2021 23:09:18 +0000 (UTC) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1mkwiP-0005DC-Hd; Thu, 11 Nov 2021 00:09:14 +0100 Date: Thu, 11 Nov 2021 00:09:13 +0100 From: Florian Westphal To: Mat Martineau Cc: Florian Westphal , mptcp@lists.linux.dev Subject: Re: [PATCH mptcp-next 1/3] mptcp: add TCP_INQ cmsg support Message-ID: <20211110230913.GI16363@breakpoint.cc> References: <20211108105711.16200-1-fw@strlen.de> <20211108105711.16200-2-fw@strlen.de> <20211110101732.GE16363@breakpoint.cc> <9ac5fe56-ff93-613f-13a-8017b938ceb6@linux.intel.com> Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Mat Martineau wrote: > > Still trying here, modified the test to show the inq value in case that > > helps debug. > > Well, that was quick: > > "tcp_inq=7ffffffe is larger than one mbyte" > > At least it's the expected INT_MAX - 1 value... I'll instrument the kernel > some more and try again. Great, thanks. I'll look at this tomorrow as well. I will keep this test case as-is, but will add an extra test with out-of-band channel that will inform receiver about exact number of sent bytes so we can check reported inq hint vs. the (known) unread data value.