From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8475EC433F5 for ; Thu, 11 Nov 2021 09:16:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 620F96124C for ; Thu, 11 Nov 2021 09:16:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231576AbhKKJTW (ORCPT ); Thu, 11 Nov 2021 04:19:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230300AbhKKJTV (ORCPT ); Thu, 11 Nov 2021 04:19:21 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78579C061767 for ; Thu, 11 Nov 2021 01:16:32 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ml6C5-00076p-3O; Thu, 11 Nov 2021 10:16:29 +0100 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1ml6C3-00079X-Dy; Thu, 11 Nov 2021 10:16:27 +0100 Date: Thu, 11 Nov 2021 10:16:27 +0100 From: Oleksij Rempel To: Michal =?utf-8?B?Vm9rw6HEjQ==?= Cc: Daniel Lezcano , linux-pm@vger.kernel.org, Petr Benes , Fabio Estevam , Sascha Hauer , Amit Kucheria , linux-kernel@vger.kernel.org, Andrzej Pietrasiewicz , NXP Linux Team , Pengutronix Kernel Team , David Jander , Zhang Rui , Shawn Guo , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] thermal: imx: implement runtime PM support Message-ID: <20211111091627.GG12195@pengutronix.de> References: <20211019130809.21281-1-o.rempel@pengutronix.de> <20211020050459.GE16320@pengutronix.de> <20211021172048.GE2298@pengutronix.de> <8692108c-1b46-3d3d-6911-300ac27c2980@ysoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8692108c-1b46-3d3d-6911-300ac27c2980@ysoft.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:11:37 up 266 days, 12:35, 140 users, load average: 0.23, 0.26, 0.30 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pm@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Wed, Nov 10, 2021 at 11:07:31AM +0100, Michal Vokáč wrote: > On 25. 10. 21 13:06, Petr Benes wrote: > > Hi Oleksij, > > > > On Thu, 21 Oct 2021 at 19:21, Oleksij Rempel wrote: > > > > > > Hi Petr, > > > > > > On Wed, Oct 20, 2021 at 05:53:03PM +0200, Petr Benes wrote: > > > > On Wed, 20 Oct 2021 at 07:05, Oleksij Rempel wrote: > > > > > > > > > > Hi Petr and Michal, > > > > > > > > > > I forgot to add you for v2 in CC. Please test/review this version. > > > > > > > > Hi Oleksij, > > > > > > > > It works good. with PM as well as without PM. The only minor issue I found is, > > > > that the first temperature reading (when the driver probes) fails. That is > > > > (val & soc_data->temp_valid_mask) == 0) holds true. How does > > > > pm_runtime_resume_and_get() behave in imx_thermal_probe()? > > > > Does it go through imx_thermal_runtime_resume() with usleep_range()? > > > > > > How exactly did you reproduce it? Even more or less understanding how > > > > I just placed my debug print into get_temp() > > > > if ((val & soc_data->temp_valid_mask) == 0) { > > dev_dbg(&tz->device, "temp measurement never finished\n"); > > printk("Wrong temperature reading!!!!!!\n"); > > return -EAGAIN; > > } > > > > > this can potentially happen, i never had this issue on my HW. Is it something > > > HW specific? > > > > IMHO it is just product of the following sequence: > > > > pm_runtime_set_active(&pdev->dev); > > pm_runtime_enable(data->dev); > > pm_runtime_resume_and_get(data->dev); > > thermal_zone_device_enable(data->tz); > > > > With assumption imx_thermal_runtime_resume() didn't run, > > hence the sensor didn't get enough time to come up. > > > > I didn't have time to spend it on and you have better knowledge of the > > area. If it is not that straightforward I can try to diagnose it better. > > > Hi Oleksij, > Did you manage to further debug and reproduce this problem? > Do you plan to send the v3? > > Regarding your question about the HW - this problem occured once we > upgraded the SoC on our SBC from i.MX6DL to i.MX6Q/QP. With the DualLite > we never had this problem but the Quad is getting hot quite fast. > We have pretty limited cooling options so the core is operated at its > upper temperature limits when fully loaded. Hi Michal, Sorry, I was busy and lost this topic from my radar. I was not able to reproduce it on my i.MX6Q and i.MX6QP died after other thermal voltage experiments. Please, if you able to reproduce it, try to investigate what is wrong, for example increasing wakeup time and/or and tracing sleap/wake/get sequences. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 697C3C433F5 for ; Thu, 11 Nov 2021 09:17:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31494610F8 for ; Thu, 11 Nov 2021 09:17:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 31494610F8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dVqDtncy57mkW5W0XS2197uu1yfOF7+FfVxAGmwnxPY=; b=d7iSNbXCpzUQ94 FF1YhvDjwzrbr17sMHHt8CYvAcrR2khHpjXgNsw7beMvxgHPuZ1+USQGIfOPQn71jJ4dNpS8aVrHP kRa01NFVKB/tny1zAtxIpVC67BvWAzpUipzXFyf0nsqpd0nNjsGoom+kg54YXPm1AFQMUKWP2Izzs /kLkqByrRGgXUS+Gl8YMfZgTixazxJ/bc3rIk3FzbDIe/Bj0OegIDkId5whssvBZ9ZV2zAnYJaC/D +IhY4ImHcC7kTey+U+CI+lHHbeAx+SRnD4qZIk+XIpsLMdwM7ajiwFXUKjAUYf1qd3G96OHtHqObg vfVjHrU+ze3TyXfrtXTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ml6CK-007ZjU-AG; Thu, 11 Nov 2021 09:16:44 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ml6CG-007Zj2-HG for linux-arm-kernel@lists.infradead.org; Thu, 11 Nov 2021 09:16:42 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ml6C5-00076p-3O; Thu, 11 Nov 2021 10:16:29 +0100 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1ml6C3-00079X-Dy; Thu, 11 Nov 2021 10:16:27 +0100 Date: Thu, 11 Nov 2021 10:16:27 +0100 From: Oleksij Rempel To: Michal =?utf-8?B?Vm9rw6HEjQ==?= Cc: Daniel Lezcano , linux-pm@vger.kernel.org, Petr Benes , Fabio Estevam , Sascha Hauer , Amit Kucheria , linux-kernel@vger.kernel.org, Andrzej Pietrasiewicz , NXP Linux Team , Pengutronix Kernel Team , David Jander , Zhang Rui , Shawn Guo , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] thermal: imx: implement runtime PM support Message-ID: <20211111091627.GG12195@pengutronix.de> References: <20211019130809.21281-1-o.rempel@pengutronix.de> <20211020050459.GE16320@pengutronix.de> <20211021172048.GE2298@pengutronix.de> <8692108c-1b46-3d3d-6911-300ac27c2980@ysoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8692108c-1b46-3d3d-6911-300ac27c2980@ysoft.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:11:37 up 266 days, 12:35, 140 users, load average: 0.23, 0.26, 0.30 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211111_011640_605785_DCA95685 X-CRM114-Status: GOOD ( 37.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBOb3YgMTAsIDIwMjEgYXQgMTE6MDc6MzFBTSArMDEwMCwgTWljaGFsIFZva8OhxI0g d3JvdGU6Cj4gT24gMjUuIDEwLiAyMSAxMzowNiwgUGV0ciBCZW5lcyB3cm90ZToKPiA+IEhpIE9s ZWtzaWosCj4gPiAKPiA+IE9uIFRodSwgMjEgT2N0IDIwMjEgYXQgMTk6MjEsIE9sZWtzaWogUmVt cGVsIDxvLnJlbXBlbEBwZW5ndXRyb25peC5kZT4gd3JvdGU6Cj4gPiA+IAo+ID4gPiBIaSBQZXRy LAo+ID4gPiAKPiA+ID4gT24gV2VkLCBPY3QgMjAsIDIwMjEgYXQgMDU6NTM6MDNQTSArMDIwMCwg UGV0ciBCZW5lcyB3cm90ZToKPiA+ID4gPiBPbiBXZWQsIDIwIE9jdCAyMDIxIGF0IDA3OjA1LCBP bGVrc2lqIFJlbXBlbCA8by5yZW1wZWxAcGVuZ3V0cm9uaXguZGU+IHdyb3RlOgo+ID4gPiA+ID4g Cj4gPiA+ID4gPiBIaSBQZXRyIGFuZCBNaWNoYWwsCj4gPiA+ID4gPiAKPiA+ID4gPiA+IEkgZm9y Z290IHRvIGFkZCB5b3UgZm9yIHYyIGluIENDLiBQbGVhc2UgdGVzdC9yZXZpZXcgdGhpcyB2ZXJz aW9uLgo+ID4gPiA+IAo+ID4gPiA+IEhpIE9sZWtzaWosCj4gPiA+ID4gCj4gPiA+ID4gSXQgd29y a3MgZ29vZC4gd2l0aCBQTSBhcyB3ZWxsIGFzIHdpdGhvdXQgUE0uIFRoZSBvbmx5IG1pbm9yIGlz c3VlIEkgZm91bmQgaXMsCj4gPiA+ID4gdGhhdCB0aGUgZmlyc3QgdGVtcGVyYXR1cmUgcmVhZGlu ZyAod2hlbiB0aGUgZHJpdmVyIHByb2JlcykgZmFpbHMuIFRoYXQgaXMKPiA+ID4gPiAodmFsICYg c29jX2RhdGEtPnRlbXBfdmFsaWRfbWFzaykgPT0gMCkgaG9sZHMgdHJ1ZS4gSG93IGRvZXMKPiA+ ID4gPiBwbV9ydW50aW1lX3Jlc3VtZV9hbmRfZ2V0KCkgYmVoYXZlIGluIGlteF90aGVybWFsX3By b2JlKCk/Cj4gPiA+ID4gRG9lcyBpdCBnbyB0aHJvdWdoIGlteF90aGVybWFsX3J1bnRpbWVfcmVz dW1lKCkgd2l0aCB1c2xlZXBfcmFuZ2UoKT8KPiA+ID4gCj4gPiA+IEhvdyBleGFjdGx5IGRpZCB5 b3UgcmVwcm9kdWNlIGl0PyBFdmVuIG1vcmUgb3IgbGVzcyB1bmRlcnN0YW5kaW5nIGhvdwo+ID4g Cj4gPiBJIGp1c3QgcGxhY2VkIG15IGRlYnVnIHByaW50IGludG8gZ2V0X3RlbXAoKQo+ID4gCj4g PiAgICAgIGlmICgodmFsICYgc29jX2RhdGEtPnRlbXBfdmFsaWRfbWFzaykgPT0gMCkgewo+ID4g ICAgICAgICAgZGV2X2RiZygmdHotPmRldmljZSwgInRlbXAgbWVhc3VyZW1lbnQgbmV2ZXIgZmlu aXNoZWRcbiIpOwo+ID4gICAgICAgICAgcHJpbnRrKCJXcm9uZyB0ZW1wZXJhdHVyZSByZWFkaW5n ISEhISEhXG4iKTsKPiA+ICAgICAgICAgIHJldHVybiAtRUFHQUlOOwo+ID4gICAgICB9Cj4gPiAK PiA+ID4gdGhpcyBjYW4gcG90ZW50aWFsbHkgaGFwcGVuLCBpIG5ldmVyIGhhZCB0aGlzIGlzc3Vl IG9uIG15IEhXLiBJcyBpdCBzb21ldGhpbmcKPiA+ID4gSFcgc3BlY2lmaWM/Cj4gPiAKPiA+IElN SE8gaXQgaXMganVzdCBwcm9kdWN0IG9mIHRoZSBmb2xsb3dpbmcgc2VxdWVuY2U6Cj4gPiAKPiA+ IHBtX3J1bnRpbWVfc2V0X2FjdGl2ZSgmcGRldi0+ZGV2KTsKPiA+IHBtX3J1bnRpbWVfZW5hYmxl KGRhdGEtPmRldik7Cj4gPiBwbV9ydW50aW1lX3Jlc3VtZV9hbmRfZ2V0KGRhdGEtPmRldik7Cj4g PiB0aGVybWFsX3pvbmVfZGV2aWNlX2VuYWJsZShkYXRhLT50eik7Cj4gPiAKPiA+IFdpdGggYXNz dW1wdGlvbiBpbXhfdGhlcm1hbF9ydW50aW1lX3Jlc3VtZSgpIGRpZG4ndCBydW4sCj4gPiBoZW5j ZSB0aGUgc2Vuc29yIGRpZG4ndCBnZXQgZW5vdWdoIHRpbWUgdG8gY29tZSB1cC4KPiA+IAo+ID4g SSBkaWRuJ3QgaGF2ZSB0aW1lIHRvIHNwZW5kIGl0IG9uIGFuZCB5b3UgaGF2ZSBiZXR0ZXIga25v d2xlZGdlIG9mIHRoZQo+ID4gYXJlYS4gSWYgaXQgaXMgbm90IHRoYXQgc3RyYWlnaHRmb3J3YXJk IEkgY2FuIHRyeSB0byBkaWFnbm9zZSBpdCBiZXR0ZXIuCj4gPiAKPiBIaSBPbGVrc2lqLAo+IERp ZCB5b3UgbWFuYWdlIHRvIGZ1cnRoZXIgZGVidWcgYW5kIHJlcHJvZHVjZSB0aGlzIHByb2JsZW0/ Cj4gRG8geW91IHBsYW4gdG8gc2VuZCB0aGUgdjM/Cj4gCj4gUmVnYXJkaW5nIHlvdXIgcXVlc3Rp b24gYWJvdXQgdGhlIEhXIC0gdGhpcyBwcm9ibGVtIG9jY3VyZWQgb25jZSB3ZQo+IHVwZ3JhZGVk IHRoZSBTb0Mgb24gb3VyIFNCQyBmcm9tIGkuTVg2REwgdG8gaS5NWDZRL1FQLiBXaXRoIHRoZSBE dWFsTGl0ZQo+IHdlIG5ldmVyIGhhZCB0aGlzIHByb2JsZW0gYnV0IHRoZSBRdWFkIGlzIGdldHRp bmcgaG90IHF1aXRlIGZhc3QuCj4gV2UgaGF2ZSBwcmV0dHkgbGltaXRlZCBjb29saW5nIG9wdGlv bnMgc28gdGhlIGNvcmUgaXMgb3BlcmF0ZWQgYXQgaXRzCj4gdXBwZXIgdGVtcGVyYXR1cmUgbGlt aXRzIHdoZW4gZnVsbHkgbG9hZGVkLgoKSGkgTWljaGFsLAoKU29ycnksIEkgd2FzIGJ1c3kgYW5k IGxvc3QgdGhpcyB0b3BpYyBmcm9tIG15IHJhZGFyLiBJIHdhcyBub3QgYWJsZSB0bwpyZXByb2R1 Y2UgaXQgb24gbXkgaS5NWDZRIGFuZCBpLk1YNlFQIGRpZWQgYWZ0ZXIgb3RoZXIgdGhlcm1hbCB2 b2x0YWdlCmV4cGVyaW1lbnRzLiBQbGVhc2UsIGlmIHlvdSBhYmxlIHRvIHJlcHJvZHVjZSBpdCwg dHJ5IHRvIGludmVzdGlnYXRlCndoYXQgaXMgd3JvbmcsIGZvciBleGFtcGxlIGluY3JlYXNpbmcg d2FrZXVwIHRpbWUgYW5kL29yIGFuZCB0cmFjaW5nCnNsZWFwL3dha2UvZ2V0IHNlcXVlbmNlcy4K ClJlZ2FyZHMsCk9sZWtzaWoKLS0gClBlbmd1dHJvbml4IGUuSy4gICAgICAgICAgICAgICAgICAg ICAgICAgICB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ClN0ZXVlcndhbGRlciBTdHIu IDIxICAgICAgICAgICAgICAgICAgICAgICB8IGh0dHA6Ly93d3cucGVuZ3V0cm9uaXguZGUvICB8 CjMxMTM3IEhpbGRlc2hlaW0sIEdlcm1hbnkgICAgICAgICAgICAgICAgICB8IFBob25lOiArNDkt NTEyMS0yMDY5MTctMCAgICB8CkFtdHNnZXJpY2h0IEhpbGRlc2hlaW0sIEhSQSAyNjg2ICAgICAg ICAgICB8IEZheDogICArNDktNTEyMS0yMDY5MTctNTU1NSB8CgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlz dApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==