From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FEE8C433EF for ; Thu, 11 Nov 2021 15:20:04 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D32CF610C8 for ; Thu, 11 Nov 2021 15:20:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D32CF610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 97E5F80F73; Thu, 11 Nov 2021 15:20:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KTfyzbPb3yfH; Thu, 11 Nov 2021 15:20:02 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 34B5180ED2; Thu, 11 Nov 2021 15:20:02 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0AD7FC0020; Thu, 11 Nov 2021 15:20:02 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7D353C001E for ; Thu, 11 Nov 2021 15:20:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 725FD404E3 for ; Thu, 11 Nov 2021 15:20:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0auHtvF_QeSA for ; Thu, 11 Nov 2021 15:19:59 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id 37EDB404D9 for ; Thu, 11 Nov 2021 15:19:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636643997; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j2K10Q3RYJAYLzZSO7lPYSVevInAJlNcm48b9LQMpGM=; b=g3Sgyui6LVkYhoHH1EUHwrdgkSPgIhvZzZXoUAKviDGrBA76yqVj3ypB747G2p4bXYVi5B Tu0pRp8W+ArOhhXJ3wyr6ohIMEGFzQEpGj3wJjlFYsLEO+nSyux1U03UBQq83+evZXleGk 9cfO8aqm6JO1UxrLO+9v3928Dh6Ax/4= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-400-IT9Y75BKP_GeE-WmVgAjIA-1; Thu, 11 Nov 2021 10:19:55 -0500 X-MC-Unique: IT9Y75BKP_GeE-WmVgAjIA-1 Received: by mail-ed1-f70.google.com with SMTP id y20-20020a056402359400b003e28c9bc02cso5694868edc.9 for ; Thu, 11 Nov 2021 07:19:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=j2K10Q3RYJAYLzZSO7lPYSVevInAJlNcm48b9LQMpGM=; b=6SxJVkf8FM8UQJFqYQZk5PNUiEsxrmj/N/d9d/tuDOXX/yzJlFI5n/UdSSr5WacSrL y5otcyz+eNixBnqhsfo0+ecPbd1Hrskycv1QYschuzI+a+FM0TT/SzQjKAkSgKinQOWM uRQVNBkDsZcVJ/s/+ygwLX21DZUngqeUUn1CC1b3gfxj4GfeHywlihPC/mmofqnfkMzw qCF/8ESBu4cwbzC4c6Oxn03MGPZTUn8w8Hv9HV05SiykdqLwX2+LuIKTPcJite086ZVd tM/d+dxCh6uUXWVH6HMV6LNGm3rHypKFBKx8M5hVsfCEgp21WGTwEevKmD8oj78mciLd ewxA== X-Gm-Message-State: AOAM530e/1bnkCmrgiubdZRRk5atFOGXcXJmN1l4DGOSTwpVvm9dEdqM KIBP2fVMCUpC5wRuvApIPBKbVu5jBprMDwCYN+PqwMZudGRIKEDcn4LZFjOt4sQZ1Xheg+PSspk G9wQ6+P09qGjlKjXZXCC5irhWSMvRLFg4u9nJz7WSWQ== X-Received: by 2002:a17:907:3daa:: with SMTP id he42mr10526827ejc.160.1636643993884; Thu, 11 Nov 2021 07:19:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJyX+KFReiwpzw5VrVHE+1osuTAa+gMpiHonwGnKiRCl72CA5QaAceNd1oRYUsyAX6jJQJbX+Q== X-Received: by 2002:a17:907:3daa:: with SMTP id he42mr10526785ejc.160.1636643993635; Thu, 11 Nov 2021 07:19:53 -0800 (PST) Received: from redhat.com ([2.55.135.246]) by smtp.gmail.com with ESMTPSA id d13sm1682608edv.29.2021.11.11.07.19.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Nov 2021 07:19:52 -0800 (PST) Date: Thu, 11 Nov 2021 10:19:47 -0500 From: "Michael S. Tsirkin" To: "Wang, Wei W" Subject: Re: [RFC] hypercall-vsock: add a new vsock transport Message-ID: <20211111100414-mutt-send-email-mst@kernel.org> References: <71d7b0463629471e9d4887d7fcef1d8d@intel.com> <20211110054121-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: "Yamahata, Isaku" , "srutherford@google.com" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "erdemaktas@google.com" , Stefan Hajnoczi , Paolo Bonzini , "Kleen, Andi" , "kuba@kernel.org" , "davem@davemloft.net" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gVGh1LCBOb3YgMTEsIDIwMjEgYXQgMDc6NTg6MjlBTSArMDAwMCwgV2FuZywgV2VpIFcgd3Jv dGU6Cj4gT24gV2VkbmVzZGF5LCBOb3ZlbWJlciAxMCwgMjAyMSA2OjUwIFBNLCBNaWNoYWVsIFMu IFRzaXJraW4gd3JvdGU6Cj4gPiBPbiBXZWQsIE5vdiAxMCwgMjAyMSBhdCAwNzoxMjozNkFNICsw MDAwLCBXYW5nLCBXZWkgVyB3cm90ZToKPiA+Cj4gPiBoeXBlcmNhbGxzIGFyZSBmdW5kYW1lbnRh bGx5IGh5cGVydmlzb3IgZGVwZW5kZW50IHRob3VnaC4KPiAKPiBZZXMsIGVhY2ggaHlwZXJ2aXNv ciBuZWVkcyB0byBzdXBwb3J0IGl0Lgo+IFdlIGNvdWxkIHNpbXBsaWZ5IHRoZSBkZXNpZ24gYW5k IGltcGxlbWVudGF0aW9uIHRvIHRoZSBtaW5pbWFsLCBzbyB0aGF0IGVhY2ggaHlwZXJ2aXNvciBj YW4gZWFzaWx5IHN1cHBvcnQgaXQuCj4gT25jZSBldmVyeSBoeXBlcnZpc29yIGhhcyB0aGUgc3Vw cG9ydCwgdGhlIGd1ZXN0IChNaWdURCkgY291bGQgYmUgYSB1bmlmaWVkIHZlcnNpb24uCj4gKGUu Zy4gbm8gbmVlZCBmb3IgZWFjaCBoeXBlcnZpc29yIHVzZXIgdG8gZGV2ZWxvcCB0aGVpciBvd24g TWlnVEQgdXNpbmcgdGhlaXIgb3duIHZzb2NrIHRyYW5zcG9ydCkKPiAKPiA+IEFzc3VtaW5nIHlv dSBjYW4gY2FydmUgdXAgYSBoeXBlcnZpc29yIGluZGVwZW5kZW50IGh5cGVyY2FsbCwgdXNpbmcg aXQgZm9yCj4gPiBzb21ldGhpbmcgYXMgbXVuZGFuZSBhbmQgc3BlY2lmaWMgYXMgdnNvY2sgZm9y IFREWCBzZWVtcyBsaWtlIGEgaHVnZSBvdmVya2lsbC4KPiA+IEZvciBleGFtcGxlLCB2aXJ0aW8g Y291bGQgYmVuZWZpdCBmcm9tIGZhc3RlciB2bWV4aXRzIHRoYXQgaHlwZXJjYWxscyBnaXZlIHlv dQo+ID4gZm9yIHNpZ25hbGxpbmcuCj4gPiBIb3cgYWJvdXQgYSBjb21iaW5hdGlvbiBvZiB2aXJ0 aW8tbW1pbyBhbmQgaHlwZXJjYWxscyBmb3IgZmFzdC1wYXRoIHNpZ25hbGxpbmcKPiA+IHRoZW4/ Cj4gCj4gV2UgdGhvdWdodCBhYm91dCB2aXJ0aW8tbW1pby4gVGhlcmUgYXJlIHNvbWUgYmFycmll cnM6Cj4gMSkgSXQgd2Fzbid0IG9yaWdpbmFsbHkgaW50ZW5kZWQgZm9yIHg4NiBtYWNoaW5lcy4g VGhlIG9ubHkgbWFjaGluZSB0eXBlIGluIFFFTVUKPiB0aGF0IHN1cHBvcnRzIGl0ICh0byBydW4g b24geDg2KSBpcyBtaWNyb3ZtLiBCdXQgIm1pY3Jvdm0iIGRvZXNu4oCZdCBzdXBwb3J0IFREWCBj dXJyZW50bHksCj4gYW5kIGFkZGluZyB0aGlzIHN1cHBvcnQgbWlnaHQgbmVlZCBsYXJnZXIgZWZm b3J0Lgo+IDIpIEl0J3Mgc2ltcGxlciB0aGFuIHZpcnRpby1wY2ksIGJ1dCBzdGlsbCBtb3JlIGNv bXBsZXggdGhhbiBoeXBlcmNhbGwuCj4gMykgU29tZSBDU1BzIGRvbid0IGhhdmUgdmlydGlvIHN1 cHBvcnQgaW4gdGhlaXIgc29mdHdhcmUsIHNvIHRoaXMgbWlnaHQgYWRkIHRvbyBtdWNoIGRldmVs b3BtZW50IGVmZm9ydCBmb3IgdGhlbS4KPiAKPiBUaGlzIHVzYWdlIGRvZXNu4oCZdCBuZWVkIGhp Z2ggcGVyZm9ybWFuY2UsIHNvIGZhc3RlciBoeXBlcmNhbGwgZm9yIHNpZ25hbGxpbmcgaXNuJ3Qg cmVxdWlyZWQsIEkgdGhpbmsuCj4gKGJ1dCBpZiBoeXBlcmNhbGwgaGFzIGJlZW4gdmVyaWZpZWQg dG8gYmUgbXVjaCBmYXN0ZXIgdGhhbiB0aGUgY3VycmVudCBFUFQgbWlzY29uZmlnIGJhc2VkIG5v dGlmaWNhdGlvbiwKPiBpdCBjb3VsZCBiZSBhZGRlZCBmb3IgdGhlIGdlbmVyYWwgdmlydGlvIHVz YWdlcykKPiAKPiA+IAo+ID4gPiAyKSAgICAgICBJdCBpcyBzaW1wbGVyLiBJdCBkb2VzbuKAmXQg cmVseSBvbiBhbnkgY29tcGxleCBidXMgZW51bWVyYXRpb24KPiA+ID4KPiA+ID4gKGUuZy4gdmly dGlvLXBjaSBiYXNlZCB2c29jayBkZXZpY2UgbWF5IG5lZWQgdGhlIHdob2xlIGltcGxlbWVudGF0 aW9uIG9mCj4gPiBQQ0kpLgo+ID4gPgo+ID4gCj4gPiBOZXh0IHRoaW5nIHBlb3BsZSB3aWxsIHRy eSB0byBkbyBpcyBpbXBsZW1lbnQgYSBidW5jaCBvZiBvdGhlciBkZXZpY2Ugb24gdG9wIG9mCj4g PiBpdC4gIHZpcnRpbyB1c2VkIHBjaSBzaW1wbHkgYmVjYXVzZSBldmVyeW9uZSBpbXBsZW1lbnRz IHBjaS4gIEFuZCB0aGUgcmVhc29uCj4gPiBmb3IgKnRoYXQqIGlzIGJlY2F1c2UgaW1wbGVtZW50 aW5nIGEgYmFzaWMgcGNpIGJ1cyBpcyBkZWFkIHNpbXBsZSwgd2hvbGUgb2YKPiA+IHBjaS5jIGlu IHFlbXUgaXMgPDMwMDAgTE9DLgo+IAo+IFRoaXMgZG9lc27igJl0IGluY2x1ZGUgdGhlIFBDSSBl bnVtZXJhdGlvbiBpbiBzZWFCSU9TIGFuZCB0aGUgUENJIGRyaXZlciBpbiB0aGUgZ3Vlc3QgdGhv dWdoLgoKRG8gd2UgcmVhbGx5IG5lZWQgdG8gd29ycnkgYWJvdXQgbWlncmF0aW5nIGd1ZXN0cyB0 aGF0IGRpZCBub3QgY29tcGxldGUKUENJIGVudW1lcmF0aW9uIHlldD8KCkFueXdheSwga3ZtIHVu aXQgdGVzdCBoYXMgYSB+NTAwIExPQyBwY2kgZHJpdmVyLiAgSXQgZG9lcyBub3Qgc3VwcG9ydCBw Y2kgYnJpZGdlcwpvciBpbnRlcnJ1cHRzIHRob3VnaCAtIGlmIHlvdSB3YW50IHRvIGRvIHRoYXQg dGhlbiByZXF1aXJpbmcgdGhhdCB0aGUgZGV2aWNlIGluCnF1ZXN0aW9uIGlzIG9uIGJ1cyAwIGFu ZCB1c2luZyBwb2xsaW5nIHNlZW1zIGxpa2UgYSByZWFzb25hYmxlIGxpbWl0YXRpb24/Cgo+IFZp cnRpbyBoYXMgaGlnaCBwZXJmb3JtYW5jZSwgSSB0aGluayB0aGF0J3MgYW4gaW1wb3J0YW50IHJl YXNvbiB0aGF0IG1vcmUgZGV2aWNlcyBhcmUgY29udGludWFsbHkgYWRkZWQuCj4gRm9yIHRoaXMg dHJhbnNwb3J0LCBJIGNvdWxkbuKAmXQgZW52aXNpb24gdGhhdCBhIGJ1bmNoIG9mIGRldmljZXMg d291bGQgYmUgYWRkZWQuIEl0J3MgYSBzaW1wbGUgUFYgbWV0aG9kLgoKRmFtb3VzIGxhc3Qgd29y ZHMuIE15IHBvaW50IGlzIGFkZGluZyBhIHZlbmRvciBhZ25vc3RpYyBoeXBlcmNhbGwgbmVlZHMK YSBidW5jaCBvZiBuZWdvdGlhdGlvbiBhbmQgYWdyZWVtZW50IGJldHdlZW4gdmVuZG9ycy4gSWYg eW91IGFyZSBnb2luZwp0byBhbGwgdGhlIHRyb3VibGUsIGl0IHNlZW1zIGxpa2UgYSB3YXN0ZSB0 byBtYWtlIGl0IHNpbmdsZSB1c2UuCgo+IAo+ID4gCj4gPiA+Cj4gPiA+IEFuIGV4YW1wbGUgdXNh Z2UgaXMgdGhlIGNvbW11bmljYXRpb24gYmV0d2VlbiBNaWdURCBhbmQgaG9zdCAoUGFnZSA4Cj4g PiA+IGF0Cj4gPiA+Cj4gPiA+IGh0dHBzOi8vc3RhdGljLnNjaGVkLmNvbS9ob3N0ZWRfZmlsZXMv a3ZtZm9ydW0yMDIxL2VmLwo+ID4gPiBURFglMjBMaXZlJTIwTWlncmF0aW9uX1dlaSUyMFdhbmcu cGRmKS4KPiA+ID4KPiA+ID4gTWlnVEQgY29tbXVuaWNhdGVzIHRvIGhvc3QgdG8gYXNzaXN0IHRo ZSBtaWdyYXRpb24gb2YgdGhlIHRhcmdldCAodXNlcikgVEQuCj4gPiA+Cj4gPiA+IE1pZ1REIGlz IHBhcnQgb2YgdGhlIFRDQiwgc28gaXRzIGltcGxlbWVudGF0aW9uIGlzIGV4cGVjdGVkIHRvIGJl IGFzCj4gPiA+IHNpbXBsZSBhcyBwb3NzaWJsZQo+ID4gPgo+ID4gPiAoZS5nLiBiYXJlIG1lbnRh bCBpbXBsZW1lbnRhdGlvbiB3aXRob3V0IE9TLCBubyBQQ0kgZHJpdmVyIHN1cHBvcnQpLgo+ID4g Pgo+ID4gPgo+ID4gCj4gPiBUcnkgdG8gbGlzdCBkcmF3YmFja3M/IEZvciBleGFtcGxlLCBwYXNz dGhyb3VnaCBmb3IgbmVzdGVkIHZpcnQgaXNuJ3QgcG9zc2libGUKPiA+IHVubGlrZSBwY2ksIG5l aXRoZXIgYXJlIGhhcmR3YXJlIGltcGxlbWVudGF0aW9ucy4KPiA+IAo+IAo+IFdoeSBoeXBlcmNh bGwgd291bGRuJ3QgYmUgcG9zc2libGUgZm9yIG5lc3RlZCB2aXJ0Pwo+IEwyIGh5cGVyY2FsbCBn b2VzIHRvIEwwIGRpcmVjdGx5IGFuZCBMMCBjYW4gZGVjaWRlIHdoZXRoZXIgdG8gZm9yd2FyZCB0 aGUgY2FsbCB0aGUgTDEgKGluIG91ciBjYXNlLCBJIHRoaW5rIG5vIG5lZWQgYXMgdGhlIHBhY2tl dCB3aWxsIGdvIG91dCksIHJpZ2h0Pwo+IAo+IEl0cyBkcmF3YmFja3MgYXJlIG9idmlvdXMgKGUu Zy4gbG93IHBlcmZvcm1hbmNlKS4gCgpFeGFjdGx5LgoKPiBJbiBnZW5lcmFsLCBJIHRoaW5rIGl0 IGNvdWxkIGJlIGNvbnNpZGVyZWQgYXMgYSBjb21wbGVtZW50IHRvIHZpcnRpby4KPiBJIHRoaW5r IG1vc3QgdXNhZ2VzIHdvdWxkIGNob29zZSB2aXJ0aW8gYXMgdGhleSBkb27igJl0IHdvcnJ5IGFi b3V0IHRoZSBjb21wbGV4aXR5IGFuZCB0aGV5IHB1cnNlIGhpZ2ggcGVyZm9ybWFuY2UuCj4gRm9y IHNvbWUgc3BlY2lhbCB1c2FnZXMgdGhhdCB0aGluayB2aXJ0aW8gaXMgdG9vIGNvbXBsZXggdG8g c3VmZmljZSBhbmQgdGhleSB3YW50IHNvbWV0aGluZyBzaW1wbGVyLCB0aGV5IHdvdWxkIGNvbnNp ZGVyIHRvIHVzZSB0aGlzIHRyYW5zcG9ydOOAggo+IAo+IFRoYW5rcywKPiBXZWkKClNvIGltcGxl bWVudCBhIHNtYWxsIHN1YnNldCBvZiB2aXJ0aW8gdGhlbiwgbm8gb25lIGZvcmNlcyB5b3UgdG8g dXNlIGFsbAppdHMgZmVhdHVyZXMuIHZpcnRpbyBtbWlvIGlzIGFib3V0IDMwIHJlZ2lzdGVycywg bW9zdCBjYW4gYmUgc3R1YmJlZCB0bwpjb25zdGFudHMuIHBhY2tlZCByaW5nIGlzIG11Y2ggc2lt cGxlciB0aGFuIHNwbGl0IG9uZS4KCi0tIApNU1QKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFs aXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91 bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16689C433EF for ; Thu, 11 Nov 2021 15:20:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE1DF61268 for ; Thu, 11 Nov 2021 15:20:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233856AbhKKPWt (ORCPT ); Thu, 11 Nov 2021 10:22:49 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21055 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230177AbhKKPWp (ORCPT ); Thu, 11 Nov 2021 10:22:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636643996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j2K10Q3RYJAYLzZSO7lPYSVevInAJlNcm48b9LQMpGM=; b=KWv+1+rlFcg7DI0aDvp3RDzsxTBMOVM5H6f6T83cki83NB0I3VhpS44EDiXaHh8hchXakb C4sUlj/8DD3f1FQuC7/udtcFvDNeo+BVLFK4ZXY9PVnXKGFzNxc4HjnLy3tEjdSZ2/1feO WVQssfXz1BttWzLN/DaWSItilpp6iHY= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-128-v6nKBjEwPdOuECQSEpVSDg-1; Thu, 11 Nov 2021 10:19:55 -0500 X-MC-Unique: v6nKBjEwPdOuECQSEpVSDg-1 Received: by mail-ed1-f69.google.com with SMTP id t20-20020a056402525400b003e2ad6b5ee7so5682718edd.8 for ; Thu, 11 Nov 2021 07:19:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=j2K10Q3RYJAYLzZSO7lPYSVevInAJlNcm48b9LQMpGM=; b=TuwhIU3YOcKsbdiaq3tqMzLAnlOn1UFuDcayjoXQzkKu/iLtfMUdHPc8GYP78WBXK0 5LcDSz484rPuE6nFKlO+LVBNeCm8Cnz77vL5TNDab34Jl37U3SUvP18FQgC1lwlBtCYG U30OxRs0nF2isk+lyE6H6dEK8bpa5sx/h2LxqEFbmxGA3rkh4JHzfHfjeh/QSqi2hHNW degglY7ltvxbaUnck97KGxJyHhFi6kmcr38jP5vAMrdH0Gvt/xcZhMGCWAy4XH31MKjU hRzqHsuhvaBliDxOGgiT2KA0zmDUMcyLKIRnrEQw01aaQGevHwaBIKMMEc0/nwWAOoSN 4CxA== X-Gm-Message-State: AOAM530U83xePh41d05UpM1UzhTkLYspWNa8TlFdy4PgNI/5pLYow7aW 3ORhtsT6008+1zcbnWgIOrD9+M4Zy/hQAcS2B3yI4bIjoAhG1Ro8wFdOCOV/2YPiU2OpQfttzV7 obysyakupfHavtaFBqD/NPOfL X-Received: by 2002:a17:907:3daa:: with SMTP id he42mr10526834ejc.160.1636643993890; Thu, 11 Nov 2021 07:19:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJyX+KFReiwpzw5VrVHE+1osuTAa+gMpiHonwGnKiRCl72CA5QaAceNd1oRYUsyAX6jJQJbX+Q== X-Received: by 2002:a17:907:3daa:: with SMTP id he42mr10526785ejc.160.1636643993635; Thu, 11 Nov 2021 07:19:53 -0800 (PST) Received: from redhat.com ([2.55.135.246]) by smtp.gmail.com with ESMTPSA id d13sm1682608edv.29.2021.11.11.07.19.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Nov 2021 07:19:52 -0800 (PST) Date: Thu, 11 Nov 2021 10:19:47 -0500 From: "Michael S. Tsirkin" To: "Wang, Wei W" Cc: "sgarzare@redhat.com" , "davem@davemloft.net" , "kuba@kernel.org" , Stefan Hajnoczi , Paolo Bonzini , "kys@microsoft.com" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "Yamahata, Isaku" , "Nakajima, Jun" , "Kleen, Andi" , "srutherford@google.com" , "erdemaktas@google.com" Subject: Re: [RFC] hypercall-vsock: add a new vsock transport Message-ID: <20211111100414-mutt-send-email-mst@kernel.org> References: <71d7b0463629471e9d4887d7fcef1d8d@intel.com> <20211110054121-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 11, 2021 at 07:58:29AM +0000, Wang, Wei W wrote: > On Wednesday, November 10, 2021 6:50 PM, Michael S. Tsirkin wrote: > > On Wed, Nov 10, 2021 at 07:12:36AM +0000, Wang, Wei W wrote: > > > > hypercalls are fundamentally hypervisor dependent though. > > Yes, each hypervisor needs to support it. > We could simplify the design and implementation to the minimal, so that each hypervisor can easily support it. > Once every hypervisor has the support, the guest (MigTD) could be a unified version. > (e.g. no need for each hypervisor user to develop their own MigTD using their own vsock transport) > > > Assuming you can carve up a hypervisor independent hypercall, using it for > > something as mundane and specific as vsock for TDX seems like a huge overkill. > > For example, virtio could benefit from faster vmexits that hypercalls give you > > for signalling. > > How about a combination of virtio-mmio and hypercalls for fast-path signalling > > then? > > We thought about virtio-mmio. There are some barriers: > 1) It wasn't originally intended for x86 machines. The only machine type in QEMU > that supports it (to run on x86) is microvm. But "microvm" doesn’t support TDX currently, > and adding this support might need larger effort. > 2) It's simpler than virtio-pci, but still more complex than hypercall. > 3) Some CSPs don't have virtio support in their software, so this might add too much development effort for them. > > This usage doesn’t need high performance, so faster hypercall for signalling isn't required, I think. > (but if hypercall has been verified to be much faster than the current EPT misconfig based notification, > it could be added for the general virtio usages) > > > > > > 2) It is simpler. It doesn’t rely on any complex bus enumeration > > > > > > (e.g. virtio-pci based vsock device may need the whole implementation of > > PCI). > > > > > > > Next thing people will try to do is implement a bunch of other device on top of > > it. virtio used pci simply because everyone implements pci. And the reason > > for *that* is because implementing a basic pci bus is dead simple, whole of > > pci.c in qemu is <3000 LOC. > > This doesn’t include the PCI enumeration in seaBIOS and the PCI driver in the guest though. Do we really need to worry about migrating guests that did not complete PCI enumeration yet? Anyway, kvm unit test has a ~500 LOC pci driver. It does not support pci bridges or interrupts though - if you want to do that then requiring that the device in question is on bus 0 and using polling seems like a reasonable limitation? > Virtio has high performance, I think that's an important reason that more devices are continually added. > For this transport, I couldn’t envision that a bunch of devices would be added. It's a simple PV method. Famous last words. My point is adding a vendor agnostic hypercall needs a bunch of negotiation and agreement between vendors. If you are going to all the trouble, it seems like a waste to make it single use. > > > > > > > > > An example usage is the communication between MigTD and host (Page 8 > > > at > > > > > > https://static.sched.com/hosted_files/kvmforum2021/ef/ > > > TDX%20Live%20Migration_Wei%20Wang.pdf). > > > > > > MigTD communicates to host to assist the migration of the target (user) TD. > > > > > > MigTD is part of the TCB, so its implementation is expected to be as > > > simple as possible > > > > > > (e.g. bare mental implementation without OS, no PCI driver support). > > > > > > > > > > Try to list drawbacks? For example, passthrough for nested virt isn't possible > > unlike pci, neither are hardware implementations. > > > > Why hypercall wouldn't be possible for nested virt? > L2 hypercall goes to L0 directly and L0 can decide whether to forward the call the L1 (in our case, I think no need as the packet will go out), right? > > Its drawbacks are obvious (e.g. low performance). Exactly. > In general, I think it could be considered as a complement to virtio. > I think most usages would choose virtio as they don’t worry about the complexity and they purse high performance. > For some special usages that think virtio is too complex to suffice and they want something simpler, they would consider to use this transport。 > > Thanks, > Wei So implement a small subset of virtio then, no one forces you to use all its features. virtio mmio is about 30 registers, most can be stubbed to constants. packed ring is much simpler than split one. -- MST