All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Mike Leach <mike.leach@linaro.org>
Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	suzuki.poulose@arm.com, leo.yan@linaro.org
Subject: Re: [PATCH v2 0/5] coresight: syscfg: dynamic load
Date: Thu, 11 Nov 2021 10:35:21 -0700	[thread overview]
Message-ID: <20211111173521.GB2123533@p14s> (raw)
In-Reply-To: <20211019191351.10242-1-mike.leach@linaro.org>

On Tue, Oct 19, 2021 at 08:13:46PM +0100, Mike Leach wrote:
> 1) API updated to allow dynamic load and unload of configurations and
> features. Dependency management between loaded sets is added.
> 
> 2) New configuration and feature sets can be added using a loadable module.
> An example in /samples/coresight is provided to demonstrate this.
> 
> 3) configfs can be used to activate a configuration which will then be used
> when controlling tracing using sysfs.
> 
> Applies and tested on coresight/next - which is 5.15-rc1

I am done reviewing this set.  Other than the minor comments for patches 1 and 4
I think it is ready.  I would like to merge this set before reviewing the rest of
your work [1].  

Thanks,
Mathieu

[1]. "coresight: syscfg: Extend configfs for config load"

> 
> 
> Changes since v1:
> 
> a) Original set split to divide related changes into smaller sets.
> Removed RFC flag.
> 
> b) Revised config activation for sysfs to simplify common function.
> (patch 4). 
> 
> c) Minor changes requested by Mathieu added.
> 
> Mike Leach (5):
>   coresight: syscfg: Update API to allow dynamic load and unload
>   coresight: syscfg: Update load API for config loadable modules
>   coresight: syscfg: Example CoreSight configuration loadable module
>   coresight: configfs: Allow configfs to activate configuration
>   Documentation: coresight: Update coresight configuration docs
> 
>  .../trace/coresight/coresight-config.rst      |  19 ++
>  MAINTAINERS                                   |   1 +
>  .../coresight/coresight-cfg-preload.c         |   9 +-
>  .../hwtracing/coresight/coresight-config.h    |   9 +-
>  .../coresight/coresight-etm4x-core.c          |  11 +-
>  .../coresight/coresight-syscfg-configfs.c     |  87 +++++
>  .../coresight/coresight-syscfg-configfs.h     |   4 +
>  .../hwtracing/coresight/coresight-syscfg.c    | 315 ++++++++++++++++--
>  .../hwtracing/coresight/coresight-syscfg.h    |  39 ++-
>  samples/Kconfig                               |   9 +
>  samples/Makefile                              |   1 +
>  samples/coresight/Makefile                    |   4 +
>  samples/coresight/coresight-cfg-sample.c      |  73 ++++
>  13 files changed, 546 insertions(+), 35 deletions(-)
>  create mode 100644 samples/coresight/Makefile
>  create mode 100644 samples/coresight/coresight-cfg-sample.c
> 
> -- 
> 2.17.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-11-11 17:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19 19:13 [PATCH v2 0/5] coresight: syscfg: dynamic load Mike Leach
2021-10-19 19:13 ` [PATCH v2 1/5] coresight: syscfg: Update API to allow dynamic load and unload Mike Leach
2021-11-09 17:59   ` Mathieu Poirier
2021-10-19 19:13 ` [PATCH v2 2/5] coresight: syscfg: Update load API for config loadable modules Mike Leach
2021-10-19 19:13 ` [PATCH v2 3/5] coresight: syscfg: Example CoreSight configuration loadable module Mike Leach
2021-10-19 19:13 ` [PATCH v2 4/5] coresight: configfs: Allow configfs to activate configuration Mike Leach
2021-11-11 17:23   ` Mathieu Poirier
2021-10-19 19:13 ` [PATCH v2 5/5] Documentation: coresight: Update coresight configuration docs Mike Leach
2021-10-20 10:08   ` German Gomez
2021-10-20 14:00     ` Mike Leach
2021-11-11 17:35 ` Mathieu Poirier [this message]
2021-11-17 13:59   ` [PATCH v2 0/5] coresight: syscfg: dynamic load Mike Leach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211111173521.GB2123533@p14s \
    --to=mathieu.poirier@linaro.org \
    --cc=coresight@lists.linaro.org \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mike.leach@linaro.org \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.