From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13723C433F5 for ; Thu, 11 Nov 2021 22:02:52 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D40ED61452 for ; Thu, 11 Nov 2021 22:02:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D40ED61452 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9561D6E94B; Thu, 11 Nov 2021 22:02:36 +0000 (UTC) Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by gabe.freedesktop.org (Postfix) with ESMTPS id EF13F6E486; Thu, 11 Nov 2021 22:02:33 +0000 (UTC) Received: by mail-il1-x132.google.com with SMTP id l19so7261751ilk.0; Thu, 11 Nov 2021 14:02:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RyfWj4lDBm5JLTztNtdXlP2pvw82NplVvLHkINaddHI=; b=Kvi2EAdCdWaXJ6kJgQk1VrgqcTWkikERMgmlUhPlj9CaRDRDFG8Ud22y5A3dr2BTba P9hHkboLf6pReDaX4Xqgy+THgOV2hs7LHYQPsSPDrY3Ps+rzG+I/EG5+Sv9nCqx9pvDI o98MLJ1jBX6jcScTV+opGDb/FasBDTSLuyoLNqjixwjc4Zgq9bUeTt6D4SxIn0oiJfNq Rv/8Bc0d9uduhOM8YMbxhqRQ3yJLxsy1T+HfXdMj8ORsNi5ec+6aTRaC1kh/IHs2TBsK y7xSMofBrI6K0Onm+wtsu/DJnbv+pjpDn5twnIW8pXYpxuZBhJmAC9vciYeBk3qotqC9 6F5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RyfWj4lDBm5JLTztNtdXlP2pvw82NplVvLHkINaddHI=; b=CIm4zkm8dCfj/vQoZWW0Kf/FJ5f+iyeWH4mxxcFK86UF8v7DaTlZHhFyOg2A72M4cD /MMPmCvJwMjMgQPswAY6UpAwVJDubhI8CO2+mUUlulcgw/unogc2EtoMQbUWMC4rKp7i GIelv3AcpENF588xNaBJAMAZvRVUqYv4o8KGUw3fWFPCiraWqMh2EPOpllrpv+3o8ZG8 ks7fWq73lZdI3fBmaTCYyxXgjkQwqEGsHOWwO3aBnN8J9DGBzC8/Xkc1wF59M6wOERxa K0UHofxcghD9QSf6znuTfA3oqpBIWi7fUd1cjtJR/Y/51xp7rAShxC+0+MQYSlwfd1dd iPsQ== X-Gm-Message-State: AOAM530WkK2LQxWyC/jjrFGzpR3EacFfNFL5I/Su4ieyUkIir52T207L mTP99FqlQdQkWjZ1gvdL8g8= X-Google-Smtp-Source: ABdhPJxis7a3Rv7SiZn5oIuzy4jt/6RHfyGEQvTemYeJX0kELCbQ+OJl6ZWlJ1TfCSFqvg8e36VzZg== X-Received: by 2002:a05:6e02:1c0e:: with SMTP id l14mr6078084ilh.8.1636668153212; Thu, 11 Nov 2021 14:02:33 -0800 (PST) Received: from frodo.. (c-24-9-77-57.hsd1.co.comcast.net. [24.9.77.57]) by smtp.googlemail.com with ESMTPSA id t5sm2612315ilp.8.2021.11.11.14.02.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Nov 2021 14:02:32 -0800 (PST) From: Jim Cromie To: jbaron@akamai.com, gregkh@linuxfoundation.org, robdclark@gmail.com, sean@poorly.run, daniel.vetter@ffwll.ch, seanpaul@chromium.org, lyude@redhat.com, linux-kernel@vger.kernel.org, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: [PATCH v10 04/10] i915/gvt: trim spaces from pr_debug "gvt: core:" prefixes Date: Thu, 11 Nov 2021 15:02:00 -0700 Message-Id: <20211111220206.121610-5-jim.cromie@gmail.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211111220206.121610-1-jim.cromie@gmail.com> References: <20211111220206.121610-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quic_saipraka@quicinc.com, arnd@arndb.de, jim.cromie@gmail.com, catalin.marinas@arm.com, linux-arm-msm@vger.kernel.org, mingo@redhat.com, quic_psodagud@quicinc.com, maz@kernel.org, will@kernel.org, linux-arm-kernel@lists.infradead.org Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Taking embedded spaces out of existing prefixes makes them more easily searchable; simplifying the extra quoting needed otherwise: $> echo format "^gvt: core:" +p >control Dropping the internal spaces means any trailing space in a query will more clearly terminate the prefix being searched for. Consider a generic drm-debug example: # turn off ATOMIC reports echo format "^drm:atomic: " -p > control # turn off all ATOMIC:* reports, including any sub-categories echo format "^drm:atomic:" -p > control # turn on ATOMIC:FAIL: reports echo format "^drm:atomic:fail: " +p > control Removing embedded spaces in the format prefixes simplifies the corresponding match string. This means that "quoted" match-prefixes are only needed when the trailing space is desired, in order to exclude explicitly sub-categorized pr-debugs; in this example, "drm:atomic:fail:". Signed-off-by: Jim Cromie --- drivers/gpu/drm/i915/gvt/debug.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/debug.h b/drivers/gpu/drm/i915/gvt/debug.h index c6027125c1ec..bbecc279e077 100644 --- a/drivers/gpu/drm/i915/gvt/debug.h +++ b/drivers/gpu/drm/i915/gvt/debug.h @@ -36,30 +36,30 @@ do { \ } while (0) #define gvt_dbg_core(fmt, args...) \ - pr_debug("gvt: core: "fmt, ##args) + pr_debug("gvt:core: " fmt, ##args) #define gvt_dbg_irq(fmt, args...) \ - pr_debug("gvt: irq: "fmt, ##args) + pr_debug("gvt:irq: " fmt, ##args) #define gvt_dbg_mm(fmt, args...) \ - pr_debug("gvt: mm: "fmt, ##args) + pr_debug("gvt:mm: " fmt, ##args) #define gvt_dbg_mmio(fmt, args...) \ - pr_debug("gvt: mmio: "fmt, ##args) + pr_debug("gvt:mmio: " fmt, ##args) #define gvt_dbg_dpy(fmt, args...) \ - pr_debug("gvt: dpy: "fmt, ##args) + pr_debug("gvt:dpy: " fmt, ##args) #define gvt_dbg_el(fmt, args...) \ - pr_debug("gvt: el: "fmt, ##args) + pr_debug("gvt:el: " fmt, ##args) #define gvt_dbg_sched(fmt, args...) \ - pr_debug("gvt: sched: "fmt, ##args) + pr_debug("gvt:sched: " fmt, ##args) #define gvt_dbg_render(fmt, args...) \ - pr_debug("gvt: render: "fmt, ##args) + pr_debug("gvt:render: " fmt, ##args) #define gvt_dbg_cmd(fmt, args...) \ - pr_debug("gvt: cmd: "fmt, ##args) + pr_debug("gvt:cmd: " fmt, ##args) #endif -- 2.31.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00545C433FE for ; Thu, 11 Nov 2021 22:02:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C676361215 for ; Thu, 11 Nov 2021 22:02:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C676361215 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B29156E977; Thu, 11 Nov 2021 22:02:35 +0000 (UTC) Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by gabe.freedesktop.org (Postfix) with ESMTPS id EF13F6E486; Thu, 11 Nov 2021 22:02:33 +0000 (UTC) Received: by mail-il1-x132.google.com with SMTP id l19so7261751ilk.0; Thu, 11 Nov 2021 14:02:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RyfWj4lDBm5JLTztNtdXlP2pvw82NplVvLHkINaddHI=; b=Kvi2EAdCdWaXJ6kJgQk1VrgqcTWkikERMgmlUhPlj9CaRDRDFG8Ud22y5A3dr2BTba P9hHkboLf6pReDaX4Xqgy+THgOV2hs7LHYQPsSPDrY3Ps+rzG+I/EG5+Sv9nCqx9pvDI o98MLJ1jBX6jcScTV+opGDb/FasBDTSLuyoLNqjixwjc4Zgq9bUeTt6D4SxIn0oiJfNq Rv/8Bc0d9uduhOM8YMbxhqRQ3yJLxsy1T+HfXdMj8ORsNi5ec+6aTRaC1kh/IHs2TBsK y7xSMofBrI6K0Onm+wtsu/DJnbv+pjpDn5twnIW8pXYpxuZBhJmAC9vciYeBk3qotqC9 6F5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RyfWj4lDBm5JLTztNtdXlP2pvw82NplVvLHkINaddHI=; b=CIm4zkm8dCfj/vQoZWW0Kf/FJ5f+iyeWH4mxxcFK86UF8v7DaTlZHhFyOg2A72M4cD /MMPmCvJwMjMgQPswAY6UpAwVJDubhI8CO2+mUUlulcgw/unogc2EtoMQbUWMC4rKp7i GIelv3AcpENF588xNaBJAMAZvRVUqYv4o8KGUw3fWFPCiraWqMh2EPOpllrpv+3o8ZG8 ks7fWq73lZdI3fBmaTCYyxXgjkQwqEGsHOWwO3aBnN8J9DGBzC8/Xkc1wF59M6wOERxa K0UHofxcghD9QSf6znuTfA3oqpBIWi7fUd1cjtJR/Y/51xp7rAShxC+0+MQYSlwfd1dd iPsQ== X-Gm-Message-State: AOAM530WkK2LQxWyC/jjrFGzpR3EacFfNFL5I/Su4ieyUkIir52T207L mTP99FqlQdQkWjZ1gvdL8g8= X-Google-Smtp-Source: ABdhPJxis7a3Rv7SiZn5oIuzy4jt/6RHfyGEQvTemYeJX0kELCbQ+OJl6ZWlJ1TfCSFqvg8e36VzZg== X-Received: by 2002:a05:6e02:1c0e:: with SMTP id l14mr6078084ilh.8.1636668153212; Thu, 11 Nov 2021 14:02:33 -0800 (PST) Received: from frodo.. (c-24-9-77-57.hsd1.co.comcast.net. [24.9.77.57]) by smtp.googlemail.com with ESMTPSA id t5sm2612315ilp.8.2021.11.11.14.02.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Nov 2021 14:02:32 -0800 (PST) From: Jim Cromie To: jbaron@akamai.com, gregkh@linuxfoundation.org, robdclark@gmail.com, sean@poorly.run, daniel.vetter@ffwll.ch, seanpaul@chromium.org, lyude@redhat.com, linux-kernel@vger.kernel.org, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Date: Thu, 11 Nov 2021 15:02:00 -0700 Message-Id: <20211111220206.121610-5-jim.cromie@gmail.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211111220206.121610-1-jim.cromie@gmail.com> References: <20211111220206.121610-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Intel-gfx] [PATCH v10 04/10] i915/gvt: trim spaces from pr_debug "gvt: core:" prefixes X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quic_saipraka@quicinc.com, arnd@arndb.de, jim.cromie@gmail.com, catalin.marinas@arm.com, linux-arm-msm@vger.kernel.org, mingo@redhat.com, quic_psodagud@quicinc.com, maz@kernel.org, will@kernel.org, linux-arm-kernel@lists.infradead.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Taking embedded spaces out of existing prefixes makes them more easily searchable; simplifying the extra quoting needed otherwise: $> echo format "^gvt: core:" +p >control Dropping the internal spaces means any trailing space in a query will more clearly terminate the prefix being searched for. Consider a generic drm-debug example: # turn off ATOMIC reports echo format "^drm:atomic: " -p > control # turn off all ATOMIC:* reports, including any sub-categories echo format "^drm:atomic:" -p > control # turn on ATOMIC:FAIL: reports echo format "^drm:atomic:fail: " +p > control Removing embedded spaces in the format prefixes simplifies the corresponding match string. This means that "quoted" match-prefixes are only needed when the trailing space is desired, in order to exclude explicitly sub-categorized pr-debugs; in this example, "drm:atomic:fail:". Signed-off-by: Jim Cromie --- drivers/gpu/drm/i915/gvt/debug.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/debug.h b/drivers/gpu/drm/i915/gvt/debug.h index c6027125c1ec..bbecc279e077 100644 --- a/drivers/gpu/drm/i915/gvt/debug.h +++ b/drivers/gpu/drm/i915/gvt/debug.h @@ -36,30 +36,30 @@ do { \ } while (0) #define gvt_dbg_core(fmt, args...) \ - pr_debug("gvt: core: "fmt, ##args) + pr_debug("gvt:core: " fmt, ##args) #define gvt_dbg_irq(fmt, args...) \ - pr_debug("gvt: irq: "fmt, ##args) + pr_debug("gvt:irq: " fmt, ##args) #define gvt_dbg_mm(fmt, args...) \ - pr_debug("gvt: mm: "fmt, ##args) + pr_debug("gvt:mm: " fmt, ##args) #define gvt_dbg_mmio(fmt, args...) \ - pr_debug("gvt: mmio: "fmt, ##args) + pr_debug("gvt:mmio: " fmt, ##args) #define gvt_dbg_dpy(fmt, args...) \ - pr_debug("gvt: dpy: "fmt, ##args) + pr_debug("gvt:dpy: " fmt, ##args) #define gvt_dbg_el(fmt, args...) \ - pr_debug("gvt: el: "fmt, ##args) + pr_debug("gvt:el: " fmt, ##args) #define gvt_dbg_sched(fmt, args...) \ - pr_debug("gvt: sched: "fmt, ##args) + pr_debug("gvt:sched: " fmt, ##args) #define gvt_dbg_render(fmt, args...) \ - pr_debug("gvt: render: "fmt, ##args) + pr_debug("gvt:render: " fmt, ##args) #define gvt_dbg_cmd(fmt, args...) \ - pr_debug("gvt: cmd: "fmt, ##args) + pr_debug("gvt:cmd: " fmt, ##args) #endif -- 2.31.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 562D6C4332F for ; Thu, 11 Nov 2021 22:02:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3843960FC2 for ; Thu, 11 Nov 2021 22:02:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234114AbhKKWF0 (ORCPT ); Thu, 11 Nov 2021 17:05:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234209AbhKKWFX (ORCPT ); Thu, 11 Nov 2021 17:05:23 -0500 Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD4BCC061767; Thu, 11 Nov 2021 14:02:33 -0800 (PST) Received: by mail-il1-x134.google.com with SMTP id s15so7188215ild.9; Thu, 11 Nov 2021 14:02:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RyfWj4lDBm5JLTztNtdXlP2pvw82NplVvLHkINaddHI=; b=Kvi2EAdCdWaXJ6kJgQk1VrgqcTWkikERMgmlUhPlj9CaRDRDFG8Ud22y5A3dr2BTba P9hHkboLf6pReDaX4Xqgy+THgOV2hs7LHYQPsSPDrY3Ps+rzG+I/EG5+Sv9nCqx9pvDI o98MLJ1jBX6jcScTV+opGDb/FasBDTSLuyoLNqjixwjc4Zgq9bUeTt6D4SxIn0oiJfNq Rv/8Bc0d9uduhOM8YMbxhqRQ3yJLxsy1T+HfXdMj8ORsNi5ec+6aTRaC1kh/IHs2TBsK y7xSMofBrI6K0Onm+wtsu/DJnbv+pjpDn5twnIW8pXYpxuZBhJmAC9vciYeBk3qotqC9 6F5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RyfWj4lDBm5JLTztNtdXlP2pvw82NplVvLHkINaddHI=; b=CXOYBCFCmUW/9xdwoB4nSwA/Tr7hjnRUk62CXY88I+8DmszbC6Q8YW/AQ2bl0stzcp HS4fohohHKpf7dP3A1e8uZ2R6Kp9JHLOlPtbeTZ+TYxeMSn4LTjjF+sOaYy2ugeBhOXu 9TVSc5J5IZrGGrcWVK+JNQq/kkvRniwbVEUqk55PHjG2FdTUYjGr4SrCAvYsX8bUntwJ W123nKuzNiYW0Btlmot3DRjLmPoP5gq176UvpSXSAUHFzBFN0j4VhvhlWYFkAuHSpofR +S8acMynf/hQQTZxgl7QUgJmLNxHUfJuozz0ltLgwNC4e+0NThQxvE14AmhP59uanwAA Fh5w== X-Gm-Message-State: AOAM532I5al1TnFGSvw1kqyBxyqjCBBC6h1zfrV+Jo8DkoscNAunH+7l 22CuUwaBdB8+7TPxwv+nyhU= X-Google-Smtp-Source: ABdhPJxis7a3Rv7SiZn5oIuzy4jt/6RHfyGEQvTemYeJX0kELCbQ+OJl6ZWlJ1TfCSFqvg8e36VzZg== X-Received: by 2002:a05:6e02:1c0e:: with SMTP id l14mr6078084ilh.8.1636668153212; Thu, 11 Nov 2021 14:02:33 -0800 (PST) Received: from frodo.. (c-24-9-77-57.hsd1.co.comcast.net. [24.9.77.57]) by smtp.googlemail.com with ESMTPSA id t5sm2612315ilp.8.2021.11.11.14.02.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Nov 2021 14:02:32 -0800 (PST) From: Jim Cromie To: jbaron@akamai.com, gregkh@linuxfoundation.org, robdclark@gmail.com, sean@poorly.run, daniel.vetter@ffwll.ch, seanpaul@chromium.org, lyude@redhat.com, linux-kernel@vger.kernel.org, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: quic_saipraka@quicinc.com, will@kernel.org, catalin.marinas@arm.com, quic_psodagud@quicinc.com, maz@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, mingo@redhat.com, jim.cromie@gmail.com Subject: [PATCH v10 04/10] i915/gvt: trim spaces from pr_debug "gvt: core:" prefixes Date: Thu, 11 Nov 2021 15:02:00 -0700 Message-Id: <20211111220206.121610-5-jim.cromie@gmail.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211111220206.121610-1-jim.cromie@gmail.com> References: <20211111220206.121610-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Taking embedded spaces out of existing prefixes makes them more easily searchable; simplifying the extra quoting needed otherwise: $> echo format "^gvt: core:" +p >control Dropping the internal spaces means any trailing space in a query will more clearly terminate the prefix being searched for. Consider a generic drm-debug example: # turn off ATOMIC reports echo format "^drm:atomic: " -p > control # turn off all ATOMIC:* reports, including any sub-categories echo format "^drm:atomic:" -p > control # turn on ATOMIC:FAIL: reports echo format "^drm:atomic:fail: " +p > control Removing embedded spaces in the format prefixes simplifies the corresponding match string. This means that "quoted" match-prefixes are only needed when the trailing space is desired, in order to exclude explicitly sub-categorized pr-debugs; in this example, "drm:atomic:fail:". Signed-off-by: Jim Cromie --- drivers/gpu/drm/i915/gvt/debug.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/debug.h b/drivers/gpu/drm/i915/gvt/debug.h index c6027125c1ec..bbecc279e077 100644 --- a/drivers/gpu/drm/i915/gvt/debug.h +++ b/drivers/gpu/drm/i915/gvt/debug.h @@ -36,30 +36,30 @@ do { \ } while (0) #define gvt_dbg_core(fmt, args...) \ - pr_debug("gvt: core: "fmt, ##args) + pr_debug("gvt:core: " fmt, ##args) #define gvt_dbg_irq(fmt, args...) \ - pr_debug("gvt: irq: "fmt, ##args) + pr_debug("gvt:irq: " fmt, ##args) #define gvt_dbg_mm(fmt, args...) \ - pr_debug("gvt: mm: "fmt, ##args) + pr_debug("gvt:mm: " fmt, ##args) #define gvt_dbg_mmio(fmt, args...) \ - pr_debug("gvt: mmio: "fmt, ##args) + pr_debug("gvt:mmio: " fmt, ##args) #define gvt_dbg_dpy(fmt, args...) \ - pr_debug("gvt: dpy: "fmt, ##args) + pr_debug("gvt:dpy: " fmt, ##args) #define gvt_dbg_el(fmt, args...) \ - pr_debug("gvt: el: "fmt, ##args) + pr_debug("gvt:el: " fmt, ##args) #define gvt_dbg_sched(fmt, args...) \ - pr_debug("gvt: sched: "fmt, ##args) + pr_debug("gvt:sched: " fmt, ##args) #define gvt_dbg_render(fmt, args...) \ - pr_debug("gvt: render: "fmt, ##args) + pr_debug("gvt:render: " fmt, ##args) #define gvt_dbg_cmd(fmt, args...) \ - pr_debug("gvt: cmd: "fmt, ##args) + pr_debug("gvt:cmd: " fmt, ##args) #endif -- 2.31.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2453DC433EF for ; Thu, 11 Nov 2021 22:06:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB85161215 for ; Thu, 11 Nov 2021 22:06:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DB85161215 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pQODZySWUFPNADpo62X7AEeRB4yqM1HPqaxvK16kx/8=; b=zO2G1YPZluyYp4 zQpXnF+imWoYM/y4dUvsM69Cdkl7eijd/OFQ44gnxuV7NV9SrGt5GM96B0WPi6EMKgM6ik7RBjdLk wGzre/npj9w6fTNfsG4mudfd2JBAcrEx1wTJDiFnNtFcqjMGiUSQnZCbjjAapSl2pmujgp3eA6ZWA I62XOYovjDH4fxCrNagOXRqt11CGHPyApiaQ8uk8mPgh8lvjaUBoMFkjAybJvlnwvpYC6smZD92ed RCHo1jIaAHM/eB+dlnjNPNpudF+aJyNvmp8lYjPUd6dKsi5fbnIfDir9IIvIneWvW87Fgg4jY9LOP OVq7acUCaIQT2h3bN2yQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlIAx-008qJh-Sl; Thu, 11 Nov 2021 22:04:09 +0000 Received: from mail-il1-x12e.google.com ([2607:f8b0:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlI9S-008pe1-5g for linux-arm-kernel@lists.infradead.org; Thu, 11 Nov 2021 22:02:35 +0000 Received: by mail-il1-x12e.google.com with SMTP id h2so7163815ili.11 for ; Thu, 11 Nov 2021 14:02:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RyfWj4lDBm5JLTztNtdXlP2pvw82NplVvLHkINaddHI=; b=Kvi2EAdCdWaXJ6kJgQk1VrgqcTWkikERMgmlUhPlj9CaRDRDFG8Ud22y5A3dr2BTba P9hHkboLf6pReDaX4Xqgy+THgOV2hs7LHYQPsSPDrY3Ps+rzG+I/EG5+Sv9nCqx9pvDI o98MLJ1jBX6jcScTV+opGDb/FasBDTSLuyoLNqjixwjc4Zgq9bUeTt6D4SxIn0oiJfNq Rv/8Bc0d9uduhOM8YMbxhqRQ3yJLxsy1T+HfXdMj8ORsNi5ec+6aTRaC1kh/IHs2TBsK y7xSMofBrI6K0Onm+wtsu/DJnbv+pjpDn5twnIW8pXYpxuZBhJmAC9vciYeBk3qotqC9 6F5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RyfWj4lDBm5JLTztNtdXlP2pvw82NplVvLHkINaddHI=; b=iYGd96Lu8AyuuLdaN7osTAgXgeOsUzuOnZOci5pJEsw9pqhnVqKEnF0uwuR/6t5XmG nAjscOA5FM0LLsXVMdHlgIHV+ht5pIwHlFgnl6RxBnW+7qpHCz6VEtXR03Io7sAORdrN uwhWT18SfHVweL8A857HGSzuE6fyyW+u4hTDp1PQu0/xInhnU9kIE+TzT5OUcJ43sla7 roAALYFk1BeaKyJ02dOmCNUW/A7aHiSm88v3Uxw1bx6eneI4o+OQE4BG4i5zv5QL+PRl SdpRE30EJYHOfDlew3/LdKqzvWGq7NFIcjy/iwdkwSi4IhiyZMPIGUKq9WLd7bdq0Ca3 sxPg== X-Gm-Message-State: AOAM531P2BMwHR/ncZ9ACdg7KMPhWnQfsl/s1Y4Oy8pLUBbVOZkZfx4v q5n4HvQ1pjYUibNMGcvsv1Q= X-Google-Smtp-Source: ABdhPJxis7a3Rv7SiZn5oIuzy4jt/6RHfyGEQvTemYeJX0kELCbQ+OJl6ZWlJ1TfCSFqvg8e36VzZg== X-Received: by 2002:a05:6e02:1c0e:: with SMTP id l14mr6078084ilh.8.1636668153212; Thu, 11 Nov 2021 14:02:33 -0800 (PST) Received: from frodo.. (c-24-9-77-57.hsd1.co.comcast.net. [24.9.77.57]) by smtp.googlemail.com with ESMTPSA id t5sm2612315ilp.8.2021.11.11.14.02.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Nov 2021 14:02:32 -0800 (PST) From: Jim Cromie To: jbaron@akamai.com, gregkh@linuxfoundation.org, robdclark@gmail.com, sean@poorly.run, daniel.vetter@ffwll.ch, seanpaul@chromium.org, lyude@redhat.com, linux-kernel@vger.kernel.org, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: quic_saipraka@quicinc.com, will@kernel.org, catalin.marinas@arm.com, quic_psodagud@quicinc.com, maz@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, mingo@redhat.com, jim.cromie@gmail.com Subject: [PATCH v10 04/10] i915/gvt: trim spaces from pr_debug "gvt: core:" prefixes Date: Thu, 11 Nov 2021 15:02:00 -0700 Message-Id: <20211111220206.121610-5-jim.cromie@gmail.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211111220206.121610-1-jim.cromie@gmail.com> References: <20211111220206.121610-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211111_140234_302545_F28C9665 X-CRM114-Status: GOOD ( 10.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Taking embedded spaces out of existing prefixes makes them more easily searchable; simplifying the extra quoting needed otherwise: $> echo format "^gvt: core:" +p >control Dropping the internal spaces means any trailing space in a query will more clearly terminate the prefix being searched for. Consider a generic drm-debug example: # turn off ATOMIC reports echo format "^drm:atomic: " -p > control # turn off all ATOMIC:* reports, including any sub-categories echo format "^drm:atomic:" -p > control # turn on ATOMIC:FAIL: reports echo format "^drm:atomic:fail: " +p > control Removing embedded spaces in the format prefixes simplifies the corresponding match string. This means that "quoted" match-prefixes are only needed when the trailing space is desired, in order to exclude explicitly sub-categorized pr-debugs; in this example, "drm:atomic:fail:". Signed-off-by: Jim Cromie --- drivers/gpu/drm/i915/gvt/debug.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/debug.h b/drivers/gpu/drm/i915/gvt/debug.h index c6027125c1ec..bbecc279e077 100644 --- a/drivers/gpu/drm/i915/gvt/debug.h +++ b/drivers/gpu/drm/i915/gvt/debug.h @@ -36,30 +36,30 @@ do { \ } while (0) #define gvt_dbg_core(fmt, args...) \ - pr_debug("gvt: core: "fmt, ##args) + pr_debug("gvt:core: " fmt, ##args) #define gvt_dbg_irq(fmt, args...) \ - pr_debug("gvt: irq: "fmt, ##args) + pr_debug("gvt:irq: " fmt, ##args) #define gvt_dbg_mm(fmt, args...) \ - pr_debug("gvt: mm: "fmt, ##args) + pr_debug("gvt:mm: " fmt, ##args) #define gvt_dbg_mmio(fmt, args...) \ - pr_debug("gvt: mmio: "fmt, ##args) + pr_debug("gvt:mmio: " fmt, ##args) #define gvt_dbg_dpy(fmt, args...) \ - pr_debug("gvt: dpy: "fmt, ##args) + pr_debug("gvt:dpy: " fmt, ##args) #define gvt_dbg_el(fmt, args...) \ - pr_debug("gvt: el: "fmt, ##args) + pr_debug("gvt:el: " fmt, ##args) #define gvt_dbg_sched(fmt, args...) \ - pr_debug("gvt: sched: "fmt, ##args) + pr_debug("gvt:sched: " fmt, ##args) #define gvt_dbg_render(fmt, args...) \ - pr_debug("gvt: render: "fmt, ##args) + pr_debug("gvt:render: " fmt, ##args) #define gvt_dbg_cmd(fmt, args...) \ - pr_debug("gvt: cmd: "fmt, ##args) + pr_debug("gvt:cmd: " fmt, ##args) #endif -- 2.31.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel