Re: [PATCH v4] glibc: ptest: Add running glibc time related test suite (Y2038) with ptest

[Lukasz Majewski <lukma@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 4485 bytes --]

Hi Richard, Khem

> On Thu, 2021-11-11 at 05:51 -0800, Khem Raj wrote:
> > On Tue, Nov 9, 2021 at 7:29 AM Lukasz Majewski <lukma@denx.de>
> > wrote:  
> > > 
> > > This patch introduces new recipe - namely 'glibc-tests', which
> > > builds and installs time related (to check if Y2038 support
> > > works) glibc test suite to OE/Yocto built image.
> > > 
> > > It reuses code from already available 'glibc-testsuite' recipe,
> > > which is run with 'bitbake glibc-testsuite -c check' and uses qemu
> > > to execute remotely (via SSH) tests on some emulated machine.
> > > 
> > > This recipe installs time related glibc tests on some rootfs
> > > image. Afterwards, those tests can be executed on the real
> > > hardware, to facilitate validation of it with Y2038 problem
> > > compliance.
> > > 
> > > To test time related subset - one needs to call:
> > > ptest-runner glibc-tests
> > > then change the date after Y2038 threshold for 32 bit systems:
> > > date -s "20 JAN 2038 18:00:00"
> > > and then run ptest-runner again.
> > > 
> > > To facilitate debugging, source files are provided by default with
> > > the unstripped debugging symbols. Such approach would reduce the
> > > already complex recipe (as it inherits base glibc one), so there
> > > is no need to also install *-dbg and *-src packages.
> > > 
> > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > > 
> > > ---
> > > Changes for v4:
> > > - Add entry for 'glibc-tests' in the maintainers.inc file
> > > - Remove nativesdk from BBCLASSEXTEND as this resipe is not
> > > supposed to be the part of SDK
> > > 
> > > Changes for v3:
> > > - Provide missing ${PN}-ptest for PACKAGES, PROVIDES and
> > >   RPROVIDES variables
> > > 
> > > Changes for v2:
> > > - Just focus on time related set of tests as those can be run as
> > >   standalone
> > > - Reuse of already built tests (from glibc-tests.inc) and depoloy
> > >   them on the HW target.
> > > - Provide single 'run-ptest' script.
> > > - Update the recipe to run with newest poky's -master
> > > ---
> > >  meta/conf/distro/include/maintainers.inc      |   1 +
> > >  .../distro/include/ptest-packagelists.inc     |   1 +
> > >  meta/recipes-core/glibc/glibc-tests_2.34.bb   | 113
> > > ++++++++++++++++++ meta/recipes-core/glibc/glibc/run-ptest
> > > |  37 ++++++ 4 files changed, 152 insertions(+)
> > >  create mode 100644 meta/recipes-core/glibc/glibc-tests_2.34.bb
> > >  create mode 100755 meta/recipes-core/glibc/glibc/run-ptest
> > > 
> > > diff --git a/meta/conf/distro/include/maintainers.inc
> > > b/meta/conf/distro/include/maintainers.inc index
> > > baec2bef4d..7104e091fc 100644 ---
> > > a/meta/conf/distro/include/maintainers.inc +++
> > > b/meta/conf/distro/include/maintainers.inc @@ -209,6 +209,7 @@
> > > RECIPE_MAINTAINER:pn-glibc = "Khem Raj <raj.khem@gmail.com>"
> > > RECIPE_MAINTAINER:pn-glibc-locale = "Khem Raj
> > > <raj.khem@gmail.com>" RECIPE_MAINTAINER:pn-glibc-mtrace = "Khem
> > > Raj <raj.khem@gmail.com>" RECIPE_MAINTAINER:pn-glibc-scripts =
> > > "Khem Raj <raj.khem@gmail.com>" +RECIPE_MAINTAINER:pn-glibc-tests
> > > = "Lukasz Majewski <lukma@denx.de>"
> > > RECIPE_MAINTAINER:pn-glibc-testsuite = "Khem Raj
> > > <raj.khem@gmail.com>" RECIPE_MAINTAINER:pn-glide = "Otavio
> > > Salvador <otavio.salvador@ossystems.com.br>"
> > > RECIPE_MAINTAINER:pn-gmp = "Khem Raj <raj.khem@gmail.com>" diff
> > > --git a/meta/conf/distro/include/ptest-packagelists.inc
> > > b/meta/conf/distro/include/ptest-packagelists.inc index
> > > 2e324f8da4..fd52fa72a4 100644 ---
> > > a/meta/conf/distro/include/ptest-packagelists.inc +++
> > > b/meta/conf/distro/include/ptest-packagelists.inc @@ -61,6 +61,7
> > > @@ PTESTS_FAST = "\ slang-ptest \ wayland-ptest \ zlib-ptest \
> > > +    glibc-tests-ptest \  
> > 
> > this will break musl. So lets change this to
> > 
> > PTESTS_FAST:append:libc-glibc = " glibc-tests-ptest"  
> 
> FWIW I tested a tweak in master-next for that...
> 

Shall I prepare v5 with fix for that, or will you keep patches from
master-next (with your fix for this) ?

(I would prefer personally the latter option :-) ).

> Cheers,
> 
> Richard
> 




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]