From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1594430464166957806==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: misc: fix swap.cocci warnings Date: Fri, 12 Nov 2021 18:32:36 +0800 Message-ID: <20211112103236.GA81230@a78ca601fa50> In-Reply-To: <202111121846.5c9ZGPbP-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============1594430464166957806== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Denis Efremov CC: Julia Lawall CC: Pavel Machek CC: linux-leds(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/leds/leds-tca6507.c:246:14-15: WARNING opportunity for swap() Check for opencoded swap() implementation. Generated by: scripts/coccinelle/misc/swap.cocci CC: Denis Efremov Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 5833291ab6de9c3e2374336b51c814e515e8f3a5 commit: 7845daa8bd72efa8bbc1de122edfce6e058bbe41 coccinelle: misc: add swap= script :::::: branch date: 11 hours ago :::::: commit date: 7 months ago Please take the patch only if it's a positive warning. Thanks! leds-tca6507.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) --- a/drivers/leds/leds-tca6507.c +++ b/drivers/leds/leds-tca6507.c @@ -241,11 +241,9 @@ static int choose_times(int msec, int *c } if (diff < 65536) { int actual; - if (msec & 1) { - c1 =3D *c2p; - *c2p =3D *c1p; - *c1p =3D c1; - } + if (msec & 1) + = + swap(*c2p, *c1p); actual =3D time_codes[*c1p] + time_codes[*c2p]; if (*c1p < *c2p) return actual + 1; --===============1594430464166957806==--