From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Romain Naour <romain.naour@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 4/6] package/luajit: building for 64-bit target requires a 64-bit host for all platform
Date: Fri, 12 Nov 2021 13:56:08 +0100 [thread overview]
Message-ID: <20211112125608.GJ2609@scaer> (raw)
In-Reply-To: <20211112110007.787836-5-romain.naour@gmail.com>
Romain, All,
On 2021-11-12 12:00 +0100, Romain Naour spake thusly:
> Currently only x86_64 target requires a 64-bit host but building
> aarch64 target with a 32-bit host is allowed.
>
> This constraint is for all architectures [1].
>
> [1] http://lists.busybox.net/pipermail/buildroot/2021-November/628301.html
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Francois Perrad <francois.perrad@gadz.org>
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> ---
> package/luajit/Config.in | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/package/luajit/Config.in b/package/luajit/Config.in
> index f6d01ed09a..bf98260c31 100644
> --- a/package/luajit/Config.in
> +++ b/package/luajit/Config.in
> @@ -1,13 +1,15 @@
> config BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
> bool
> default y if BR2_arm || BR2_armeb || BR2_aarch64
> - default y if BR2_i386 || (BR2_x86_64 && BR2_HOSTARCH='x86_64')
,^^^^^^^^^^^^
You removed that _________________________/
> + default y if BR2_i386 || BR2_x86_64
> default y if BR2_powerpc
> default y if (BR2_mips || BR2_mipsel) && !BR2_MIPS_SOFT_FLOAT \
> && !BR2_MIPS_CPU_MIPS32R6 && !BR2_MIPS_CPU_MIPS64R6
> # -m32 flag is used for 32bit builds and host-luajit has
> # limited architecture support
> depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
> + # Building for 64-bit target requires a 64-bit host
> + depends on !BR2_ARCH_IS_64 || BR_HOST_ARCH="x86_64"
^^^^^^^^^^^^._____
\
... but you borked it when adding it back here _____/
You should not have blindly copy-pasted my poor code snippet from the
previous review! ;-]
Regards,
Yann E. MORIN.
> config BR2_PACKAGE_LUAJIT
> bool "luajit"
> --
> 2.31.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-11-12 12:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 11:00 [Buildroot] [PATCH 0/6] rework luvi test in gitlab after luajit version bump Romain Naour
2021-11-12 11:00 ` [Buildroot] [PATCH 1/6] package/luvi: don't use LUAJIT_VERSION for the luajit installation path Romain Naour
2021-11-12 13:02 ` Yann E. MORIN
2021-11-12 13:07 ` Yann E. MORIN
2021-11-12 18:50 ` Romain Naour
2021-11-12 11:00 ` [Buildroot] [PATCH 2/6] support/testing: test_luvi: switch to armv5 to boot with rng support enabled Romain Naour
2021-11-12 11:00 ` [Buildroot] [PATCH 3/6] package/luajit: rework BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS Romain Naour
2021-11-12 11:00 ` [Buildroot] [PATCH 4/6] package/luajit: building for 64-bit target requires a 64-bit host for all platform Romain Naour
2021-11-12 12:56 ` Yann E. MORIN [this message]
2021-11-12 18:38 ` Romain Naour
2021-11-12 11:00 ` [Buildroot] [PATCH 5/6] package/luajit: disable 64 bit GC objects Romain Naour
2021-11-12 11:00 ` [Buildroot] [PATCH 6/6] support/testing: test_luvi: make luvi test reproducible Romain Naour
2021-11-12 12:51 ` Yann E. MORIN
2021-11-12 18:35 ` Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211112125608.GJ2609@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=romain.naour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.