From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7885414690052194424==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings Date: Fri, 12 Nov 2021 21:26:48 +0800 Message-ID: <20211112132648.GA59341@a78ca601fa50> In-Reply-To: <202111122139.5EvsRsN8-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============7885414690052194424== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Krzysztof Kozlowski CC: Julia Lawall CC: Liam Girdwood CC: Mark Brown CC: Matthias Brugger CC: linux-kernel(a)vger.kernel.org CC: linux-arm-kernel(a)lists.infradead.org CC: linux-mediatek(a)lists.infradead.org From: kernel test robot drivers/regulator/mt6360-regulator.c:386:8-33: WARNING: Threaded IRQ with n= o primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Krzysztof Kozlowski Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 5833291ab6de9c3e2374336b51c814e515e8f3a5 commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: = reduce the severity due to false positives :::::: branch date: 14 hours ago :::::: commit date: 7 months ago Please take the patch only if it's a positive warning. Thanks! mt6360-regulator.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/regulator/mt6360-regulator.c +++ b/drivers/regulator/mt6360-regulator.c @@ -383,7 +383,8 @@ static int mt6360_regulator_irq_register if (irq < 0) return irq; = - ret =3D devm_request_threaded_irq(&pdev->dev, irq, NULL, irq_desc->handl= er, 0, + ret =3D devm_request_threaded_irq(&pdev->dev, irq, NULL, irq_desc->handl= er, + IRQF_ONESHOT, irq_desc->name, rdev); if (ret) { dev_err(&pdev->dev, "Fail to request %s irq\n", irq_desc->name); --===============7885414690052194424==--