Re: [Buildroot] [PATCH 1/1] package/pipewire: fix build on arm926ej-s

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: James Hilliard <james.hilliard1@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/pipewire: fix build on arm926ej-s
Date: Fri, 12 Nov 2021 14:37:21 +0100	[thread overview]
Message-ID: <20211112133721.GO2609@scaer> (raw)
In-Reply-To: <20211106134108.3015865-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2021-11-06 14:41 +0100, Fabrice Fontaine spake thusly:
> Fix the following build failure raised since bump to version 0.3.39 in
> commit d9796f2db9866060b916487784b046bb6b76f9b6:
> 
> /tmp/ccsZ6haQ.s:467: Error: selected processor does not support `vmrs r3,fpscr' in ARM mode
> /tmp/ccsZ6haQ.s:469: Error: selected processor does not support `vmsr fpscr,r3' in ARM mode
> /tmp/ccsZ6haQ.s:490: Error: selected processor does not support `vmrs r3,fpscr' in ARM mode
> /tmp/ccsZ6haQ.s:492: Error: selected processor does not support `vmsr fpscr,r3' in ARM mode
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/d449095c67b9477fc95ebbab5eb628e5eb4ea5c6
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  ...u-disable-VFP-asm-when-not-available.patch | 30 +++++++++++++++++++
>  1 file changed, 30 insertions(+)
>  create mode 100644 package/pipewire/0002-cpu-disable-VFP-asm-when-not-available.patch
> 
> diff --git a/package/pipewire/0002-cpu-disable-VFP-asm-when-not-available.patch b/package/pipewire/0002-cpu-disable-VFP-asm-when-not-available.patch
> new file mode 100644
> index 0000000000..297016edc2
> --- /dev/null
> +++ b/package/pipewire/0002-cpu-disable-VFP-asm-when-not-available.patch
> @@ -0,0 +1,30 @@
> +From 2cddd4a775c145570f4a8a30d28b57f551d43206 Mon Sep 17 00:00:00 2001
> +From: Wim Taymans <wtaymans@redhat.com>
> +Date: Mon, 25 Oct 2021 16:32:16 +0200
> +Subject: [PATCH] cpu: disable VFP asm when not available
> +
> +Fixes #1746
> +
> +[Retrieved from:
> +https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/2cddd4a775c145570f4a8a30d28b57f551d43206]
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +---
> + spa/plugins/support/cpu-arm.c | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/spa/plugins/support/cpu-arm.c b/spa/plugins/support/cpu-arm.c
> +index c07711f70..fe6222f7c 100644
> +--- a/spa/plugins/support/cpu-arm.c
> ++++ b/spa/plugins/support/cpu-arm.c
> +@@ -143,7 +143,7 @@ static int arm_zero_denormals(void *object, bool enable)
> + 			"msr	fpcr, %0		\n"
> + 			"isb				\n"
> + 			: "=r"(cw)::"memory");
> +-#else
> ++#elif (defined(__VFP_FP__) && !defined(__SOFTFP__))
> + 	uint32_t cw;
> + 	if (enable)
> + 		__asm__ __volatile__(
> +-- 
> +GitLab
> +
> -- 
> 2.33.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot