From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Bernd Kuhls <bernd.kuhls@t-online.de>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/3] package/glmark2: drm-glesv2 needs libdrm
Date: Sat, 13 Nov 2021 10:53:16 +0100 [thread overview]
Message-ID: <20211113095316.GP247986@scaer> (raw)
In-Reply-To: <20211113093009.6915-1-bernd.kuhls@t-online.de>
Bernd, All,
On 2021-11-13 10:30 +0100, Bernd Kuhls spake thusly:
> Fixes:
> http://autobuild.buildroot.net/results/58a/58a498fac83cbb55b252ab54cd8db04570bb5ec9/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> v2: moved libdrm select to main symbol (Yann)
>
> package/glmark2/Config.in | 3 +++
> package/glmark2/glmark2.mk | 2 +-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/package/glmark2/Config.in b/package/glmark2/Config.in
> index 40d0adcc8a..3ef3a0e8e3 100644
> --- a/package/glmark2/Config.in
> +++ b/package/glmark2/Config.in
> @@ -7,6 +7,8 @@ config BR2_PACKAGE_GLMARK2_FLAVOR_DRM_GLESV2
> depends on BR2_PACKAGE_HAS_LIBEGL
> depends on BR2_PACKAGE_HAS_LIBGLES
> depends on BR2_PACKAGE_HAS_UDEV
> + # libpthread-stubs -> libdrm
> + depends on BR2_TOOLCHAIN_HAS_THREADS
The comment to explain the dependency goes on the same line as the
dependency.
Applied to master, thanks.
Regards,
Yann E. MORIN.
> select BR2_PACKAGE_GLMARK2_FLAVOR_ANY
>
> config BR2_PACKAGE_GLMARK2_FLAVOR_DRM_GL
> @@ -63,6 +65,7 @@ config BR2_PACKAGE_GLMARK2
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++14
> depends on BR2_PACKAGE_GLMARK2_FLAVOR_ANY
> select BR2_PACKAGE_JPEG
> + select BR2_PACKAGE_LIBDRM if BR2_PACKAGE_GLMARK2_FLAVOR_DRM_GLESV2
> select BR2_PACKAGE_LIBPNG
> help
> glmark2 is an OpenGL 2.0 and ES 2.0 benchmark.
> diff --git a/package/glmark2/glmark2.mk b/package/glmark2/glmark2.mk
> index 5c2dd06362..5ad3ea2cb4 100644
> --- a/package/glmark2/glmark2.mk
> +++ b/package/glmark2/glmark2.mk
> @@ -11,7 +11,7 @@ GLMARK2_LICENSE_FILES = COPYING COPYING.SGI
> GLMARK2_DEPENDENCIES = host-pkgconf jpeg libegl libpng
>
> ifeq ($(BR2_PACKAGE_GLMARK2_FLAVOR_DRM_GLESV2),y)
> -GLMARK2_DEPENDENCIES += libgles udev
> +GLMARK2_DEPENDENCIES += libdrm libgles udev
> GLMARK2_FLAVORS += drm-glesv2
> endif
>
> --
> 2.30.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-11-13 9:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 9:30 [Buildroot] [PATCH v2 1/3] package/glmark2: drm-glesv2 needs libdrm Bernd Kuhls
2021-11-13 9:30 ` [Buildroot] [PATCH v2 2/3] package/glmark2: drm-glesv2 needs libgbm Bernd Kuhls
2021-11-13 9:53 ` Yann E. MORIN
2021-11-17 22:01 ` Peter Korsgaard
[not found] ` <87h7catpaz.fsf__1784.76354792423$1637186493$gmane$org@dell.be.48ers.dk>
2021-11-18 6:30 ` Bernd Kuhls
2021-11-13 9:30 ` [Buildroot] [PATCH 3/3] package/glmark2: fix selection of dependencies Bernd Kuhls
2021-11-13 9:52 ` Yann E. MORIN
2021-11-17 21:59 ` Peter Korsgaard
2021-11-13 9:53 ` Yann E. MORIN [this message]
2021-11-17 22:00 ` [Buildroot] [PATCH v2 1/3] package/glmark2: drm-glesv2 needs libdrm Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211113095316.GP247986@scaer \
--to=yann.morin.1998@free.fr \
--cc=bernd.kuhls@t-online.de \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.