From: Johannes Altmanninger <aclopte@gmail.com>
To: Saksham Mittal <gotlouemail@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] MyFirstContribution.txt: fix undeclared variable i in sample code
Date: Sat, 13 Nov 2021 14:05:08 +0100 [thread overview]
Message-ID: <20211113130508.zziheannky6dcilj@gmail.com> (raw)
In-Reply-To: <20211113122833.174330-1-gotlouemail@gmail.com>
On Sat, Nov 13, 2021 at 05:58:35PM +0530, Saksham Mittal wrote:
> In the sample code given to print the arguments given to ```git psuh```,
> the iterating variable i is not declared as integer. I have fixed it so
> the error is no longer there.
>
> Signed-off-by: Saksham Mittal <gotlouemail@gmail.com>
> ---
> Documentation/MyFirstContribution.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt
> index 015cf24631..434a833a0b 100644
> --- a/Documentation/MyFirstContribution.txt
> +++ b/Documentation/MyFirstContribution.txt
> @@ -297,7 +297,7 @@ existing `printf()` calls in place:
> "Your args (there are %d):\n",
> argc),
> argc);
> - for (i = 0; i < argc; i++)
> + for (int i = 0; i < argc; i++)
It is declared, there is an "int i;" a few lines up.
next prev parent reply other threads:[~2021-11-13 13:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 12:28 [PATCH] MyFirstContribution.txt: fix undeclared variable i in sample code Saksham Mittal
2021-11-13 13:05 ` Johannes Altmanninger [this message]
2021-11-13 13:08 ` Saksham Mittal
2021-11-14 6:41 ` Junio C Hamano
2021-11-14 14:28 ` Is 'for (int i = [...]' bad for C STD compliance reasons? (was: [PATCH] MyFirstContribution.txt: fix undeclared variable i in sample code) Ævar Arnfjörð Bjarmason
2021-11-14 18:03 ` Is 'for (int i = [...]' bad for C STD compliance reasons? Junio C Hamano
2021-11-14 18:25 ` Ævar Arnfjörð Bjarmason
2021-11-14 18:57 ` brian m. carlson
2021-11-14 19:33 ` Carlo Arenas
2021-11-14 19:01 ` Carlo Arenas
2021-11-15 6:27 ` [PATCH] revision: use C99 declaration of variable in for() loop Junio C Hamano
2021-11-15 7:44 ` Martin Ågren
2021-11-16 8:29 ` Junio C Hamano
2021-11-15 22:26 ` brian m. carlson
2021-11-17 11:03 ` Phillip Wood
2021-11-17 12:39 ` Ævar Arnfjörð Bjarmason
2021-11-17 22:30 ` SZEDER Gábor
2021-11-18 7:09 ` Junio C Hamano
2021-12-07 11:10 ` Phillip Wood
2021-12-07 20:37 ` Junio C Hamano
2021-12-08 12:17 ` Removing -Wdeclaration-after-statement (was: [PATCH] revision: use C99 declaration of variable in for() loop) Ævar Arnfjörð Bjarmason
2021-12-08 17:05 ` Removing -Wdeclaration-after-statement Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211113130508.zziheannky6dcilj@gmail.com \
--to=aclopte@gmail.com \
--cc=git@vger.kernel.org \
--cc=gotlouemail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.