From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7708773494036147441==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: [PATCH] KVM: x86: fix noderef.cocci warnings Date: Sun, 14 Nov 2021 09:58:50 +0800 Message-ID: <20211114015850.GA80620@8cc62eeb93da> In-Reply-To: <202111140928.m6dhOooE-lkp@intel.com> List-Id: --===============7708773494036147441== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: kernel test robot arch/x86/kvm/mmu/page_track.c:95:39-45: ERROR: application of sizeof to poi= nter sizeof when applied to a pointer typed expression gives the size of the pointer Generated by: scripts/coccinelle/misc/noderef.cocci CC: David Stevens Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://github.com/0day-ci/linux/commits/David-Stevens/KVM-x86-skip= -gfn_track-allocation-when-possible/20210922-134429 head: e8c58ba667b80c8c238fb54320c7f774c631dfd5 commit: e8c58ba667b80c8c238fb54320c7f774c631dfd5 KVM: x86: only allocate gf= n_track when necessary :::::: branch date: 8 weeks ago :::::: commit date: 8 weeks ago page_track.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/arch/x86/kvm/mmu/page_track.c +++ b/arch/x86/kvm/mmu/page_track.c @@ -92,7 +92,8 @@ int kvm_page_track_enable_mmu_write_trac slots =3D __kvm_memslots(kvm, i); kvm_for_each_memslot(slot, slots) { gfn_track =3D slot->arch.gfn_track + KVM_PAGE_TRACK_WRITE; - *gfn_track =3D kvcalloc(slot->npages, sizeof(*gfn_track), + *gfn_track =3D kvcalloc(slot->npages, + sizeof(**gfn_track), GFP_KERNEL_ACCOUNT); if (*gfn_track =3D=3D NULL) { mutex_unlock(&kvm->slots_arch_lock); --===============7708773494036147441==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAA8BC433EF for ; Sun, 14 Nov 2021 01:59:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A565F6103A for ; Sun, 14 Nov 2021 01:59:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236112AbhKNCC0 (ORCPT ); Sat, 13 Nov 2021 21:02:26 -0500 Received: from mga01.intel.com ([192.55.52.88]:34440 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236070AbhKNCCW (ORCPT ); Sat, 13 Nov 2021 21:02:22 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10167"; a="257024024" X-IronPort-AV: E=Sophos;i="5.87,233,1631602800"; d="scan'208";a="257024024" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2021 17:59:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,233,1631602800"; d="scan'208";a="505418557" Received: from lkp-server02.sh.intel.com (HELO c20d8bc80006) ([10.239.97.151]) by orsmga008.jf.intel.com with ESMTP; 13 Nov 2021 17:59:23 -0800 Received: from kbuild by c20d8bc80006 with local (Exim 4.92) (envelope-from ) id 1mm4ni-000Ko3-Lt; Sun, 14 Nov 2021 01:59:22 +0000 Date: Sun, 14 Nov 2021 09:58:50 +0800 From: kernel test robot To: David Stevens Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, 0day robot Subject: [PATCH] KVM: x86: fix noderef.cocci warnings Message-ID: <20211114015850.GA80620@8cc62eeb93da> References: <202111140928.m6dhOooE-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202111140928.m6dhOooE-lkp@intel.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kernel test robot arch/x86/kvm/mmu/page_track.c:95:39-45: ERROR: application of sizeof to pointer sizeof when applied to a pointer typed expression gives the size of the pointer Generated by: scripts/coccinelle/misc/noderef.cocci CC: David Stevens Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://github.com/0day-ci/linux/commits/David-Stevens/KVM-x86-skip-gfn_track-allocation-when-possible/20210922-134429 head: e8c58ba667b80c8c238fb54320c7f774c631dfd5 commit: e8c58ba667b80c8c238fb54320c7f774c631dfd5 KVM: x86: only allocate gfn_track when necessary :::::: branch date: 8 weeks ago :::::: commit date: 8 weeks ago page_track.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/arch/x86/kvm/mmu/page_track.c +++ b/arch/x86/kvm/mmu/page_track.c @@ -92,7 +92,8 @@ int kvm_page_track_enable_mmu_write_trac slots = __kvm_memslots(kvm, i); kvm_for_each_memslot(slot, slots) { gfn_track = slot->arch.gfn_track + KVM_PAGE_TRACK_WRITE; - *gfn_track = kvcalloc(slot->npages, sizeof(*gfn_track), + *gfn_track = kvcalloc(slot->npages, + sizeof(**gfn_track), GFP_KERNEL_ACCOUNT); if (*gfn_track == NULL) { mutex_unlock(&kvm->slots_arch_lock);